From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE68366577 for ; Fri, 6 Feb 2026 13:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770384218; cv=none; b=a8Y3tAh9yk1KoRwF/H+hQIcF5KALJ9dLazeT2x7TGsp9jU5hEA8gQFg23N26kgnKwb6gHSvjBIvRY+UYVhB4Yw3janTNvrx11mOOsBtj6s6COMZI0Pn6wTXD7iX/JkwrFXeLy8F3X3PZ7XFKZn0OGGiG+cp3qyu9PsJbrvYNGj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770384218; c=relaxed/simple; bh=fqZ8bqAlwUxBwe4Z1+H16jnykQV8yO9H8sw0Vqob/0g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tjQd6fqZd8WkPIrQEBt+a+9Gt5QaqxcVXCme95+hpy6jyzD9cMALVv6l2D/h+tAwY/4iHd6P4WYq7MOEg2J6A8FGP6qldjPaHi1VG1FUay7FlHs1iFoK2tcMETYFmnYjhQUWfGEZBMF+gY/cRKYi6PosGUXHp0Rco2/qOUJ9cps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oYLKpI92; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YuVg3Ixy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oYLKpI92"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YuVg3Ixy" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6168ZOaV2314345 for ; Fri, 6 Feb 2026 13:23:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Qcbx8hOqgZKgbdxSnQdVeh45 s4d6AAaaCPjmsAiQNIM=; b=oYLKpI92S6Q7d7Cf1DrAwDVbpDZdYaJQHEEYEz8i q7+upvosTjWwB73AvGT/DpOKcSWDuqZsIRNc3KnITrFiQLJ9IuzuwLK1Qfe8SWt0 xPKxsdF9JGSpyQg0voI3pl0/RVSfz+qXq5gSgvObQ/RiECziXWgbdOst8cR9u5jj VyrWYjteW0DrTXIcgYG0io0DMfwjIsWLAZaB2jGQQBJZjYo3mhq2bdmMDiGyAXfq jONDLiC8TLq+60zWtaHleduCLB62m34ekmTP6UM3zy19XRfBebWJeZ4HjjFecNsT YIduTS67LujAYsfXJfj4LtxXw00N9peEy8qZ1FjldKVPFQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c52mrjysc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 13:23:37 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a76f2d7744so22487785ad.3 for ; Fri, 06 Feb 2026 05:23:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770384217; x=1770989017; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Qcbx8hOqgZKgbdxSnQdVeh45s4d6AAaaCPjmsAiQNIM=; b=YuVg3IxyTS7DKgG4lVjz54J14oaNIMAFgY2VXC03zh1iYNiftCB5w/t5Uk9Dl/Edbk Asd5g/cRj7xPa2XAHV+SuRIFToUzeUlSnyYqdn/gHJqGdVrhmDkKQZ9vT29ntf/iIoFw S8+ySBkNtRM2ZWsMSr0kSXf14xxziFu0n1TO/G6UTryadQE1YHcaAXiHG6ZRFmxa0/Z3 YHtxFaHL3L0oSMnKo98az484CkD6VK3NNGVvSzc/EdgZBzoz7DreaywLWgktu1um0dce CN9mA3MYk2VCSpsbMLs/B/rWkVEoe4A0XWrU26l66roVDSrh+BWCIr+vHMKqc+OXav17 g+Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770384217; x=1770989017; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qcbx8hOqgZKgbdxSnQdVeh45s4d6AAaaCPjmsAiQNIM=; b=ZQvIofLyPkT/g4oS0lFTYRWpVbV56G+Rz/9fR8fYRgb1BJgnGA5Q0NOkBPdrAvF/2H Ja5YuI3uo3J9+6DbF3kx6HcD8cC/OKZCCl3wrU2gFCKaXOD7ggJL1haJvc/e17Rn6Smt F5VRkKI2GEfglN1VTcAM6g4F0QcZu+J3S0AteUv+AoGdnUSFIFvJLLxMe34/PIi9xHiX A8BbmUR+AzRyKpWRSt7kYJ9WyfbrTUo26ORdABqCksNy5+js3gxLxMsG+cXjDbt5Tf6Q UzYe4QeAQjT1pyAZAAGC/LmU/DwDduj0EUNI0O8IKspmSWWSik3nTZ2FExonSRdF0c8l CHjg== X-Forwarded-Encrypted: i=1; AJvYcCXeTM+xK33Ro6+0qsO1t58Azjek3rsYP6zx4BjIl9fpexLcg8QSYY/SC3EGRKa3sYGQ08LGVpYlK/Y63JY=@vger.kernel.org X-Gm-Message-State: AOJu0YyeDwF85ddJAIz0/6cQkIAlEBs2Ur8c4wQvYKRCMESw9R50pj6B 6pU5KefoXBwA7tvxhomynStT6ohrFU0Gi6j+VwlcNVmD5IIH96M45B1k07gI+y/vs6qnSJVY+dP fnKkvsClaWhiT7JDhfsgLLwFHUhsFKODai8whrVK/ijO9dAQwceXMcbT7Gv6TExqnc8Q= X-Gm-Gg: AZuq6aLhXLRxvUxVzoMkKyOPxKWcWg2pL2kGqfHA1Fg/+/J4nC4UL/J/AuTmEPODMlz Kl6USBhXysSTQb+ot139fWKnlThvlzfCUfQwb5QnBtpZN7G7rb9iTM8cmyEk/J7kPVRW1Xcsd4S hcnfg3kzV/pS+V0auO0fG1HKnYD6JeDI+sRlvWR6ZCY0Q/CVkfFp+jZqC91mlvd5NLh1WG5TBL2 KFjPVxJPfQKydzgIaeYuz//ldkb+dzRT+zdS9pUVtHz6SPV6/bkjSwu4o30Ri4EHG02HTMUMc9W AogVRDLO+LV6XCjSPEX69vApsEx2rMYX+5O1hs//9Yzv1C9Ifp0DcEMcAV87VAFwAvSi1JJxL5Z v7Ehqkv2fBqhmVpSSLFh2tOMCarxeBwif+mBrwdiqujwZaqY= X-Received: by 2002:a17:903:244a:b0:295:c2e7:7199 with SMTP id d9443c01a7336-2a9516fb30bmr25300745ad.29.1770384216757; Fri, 06 Feb 2026 05:23:36 -0800 (PST) X-Received: by 2002:a17:903:244a:b0:295:c2e7:7199 with SMTP id d9443c01a7336-2a9516fb30bmr25300415ad.29.1770384216215; Fri, 06 Feb 2026 05:23:36 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a9521f3b6asm24313205ad.77.2026.02.06.05.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:23:35 -0800 (PST) Date: Fri, 6 Feb 2026 18:53:28 +0530 From: Abhinaba Rakshit To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <20260128-enable-ufs-ice-clock-scaling-v4-2-260141e8fce6@oss.qualcomm.com> <20260128-daft-seriema-of-promotion-c50eb5@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDA5NSBTYWx0ZWRfXxE4CnRpn8MlM cG3vhy1GrWI2wyzpK7W9K2aYkUdenR+6n15UTd/SuAFwcPtEy7tFgeHL5kkfSjLLzSmcfyrofHc 4PXcP8WqQeXcMrbkmB8CcumN5eddQDgpnJAgYAeUxHOpxIeRfSqiwFBD5BoOp1rMUFgGJEauk+B uE6a7eY5KGG234Maye3z0xGtOCE+P8V4LwYJ9J8KzyHm8GaTUxzOoIDmUb68jmarZaKmb4daKGs kYlONKR4DVrxXu8WSduUQJK8yCz0Gr0wQK6q5fELL14RkBqOqwOeB8dRrf1VH6KALlHJmkNRXo+ 7wjIf9iBKMQFYb+44jbG2bH+F1ZRoPqmPjY8ioqJ1f4uYfQy58Y4ChZldvAoOpud9qQv6GidXML oInPkbSQCM4ptJaSi083/coKM7OwMlVwYdeGL2XS7gt+A7OghgnUi4XKE4s7+AI98eOum5nLr0V M14KAqQYrISrpOD2W2Q== X-Proofpoint-GUID: d-r_9L8ZGLoBoTz98xyrExyTkUPbC4ml X-Authority-Analysis: v=2.4 cv=e4kLiKp/ c=1 sm=1 tr=0 ts=6985eb59 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=utnUQDMwVCZhAfiAu78A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: d-r_9L8ZGLoBoTz98xyrExyTkUPbC4ml X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_04,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060095 On Thu, Feb 05, 2026 at 12:26:25PM +0100, Krzysztof Kozlowski wrote: > On 02/02/2026 07:32, Abhinaba Rakshit wrote: > > On Wed, Jan 28, 2026 at 12:04:26PM +0100, Krzysztof Kozlowski wrote: > >> On Wed, Jan 28, 2026 at 02:16:41PM +0530, Abhinaba Rakshit wrote: > >>> struct qcom_ice *engine; > >>> + struct dev_pm_opp *opp; > >>> + int err; > >>> + unsigned long rate; > >>> > >>> if (!qcom_scm_is_available()) > >>> return ERR_PTR(-EPROBE_DEFER); > >>> @@ -584,6 +651,46 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > >>> if (IS_ERR(engine->core_clk)) > >>> return ERR_CAST(engine->core_clk); > >>> > >>> + /* Register the OPP table only when ICE is described as a standalone > >> > >> This is not netdev... > > > > Okay, if I understand it correct, its not conventional to use of_device_is_compatible > > outside netdev subsystem. Will update as mentioned below. > > No, please read entire coding style, although the comment was about > comment style. Sure, will ensure to use the correct comment styles. Abhinaba Rakshit