From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACD003783CF for ; Fri, 6 Feb 2026 13:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385116; cv=none; b=Dpl5ZCHyc44d0j7QMkHKIDWpzIp1r1jNJYTHp4fBEVTxuUYNq134bb2oKen3SlzVIET7vJLKxzRzmVgGVbkO+FvoBPgiyiJztByhsjSBWY9VEWOt7Ck3eBYCjM3Alajvy/bZA5yHmo6sl9DWF1RMqvZeAi5eV7vi6c/wVyT/kng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385116; c=relaxed/simple; bh=CsRZyI/0CJXBnCrb8NeeHp8Pz5Znjh8bovcxhtKVDLc=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=RRFbo6STEycdHDoeUSe1ei2jmG+k5fXimdwsT2BMbQAG4gn80+wxiJceyt4NeRfKqX0oGJzCyIHSVRmcUwwB2vhcXw6Y5GlzDZZvOn36qDpnWLYoQTB2+3RypEmrJzXl7h5M7w7wMSnOhJrt9yiM+fKUe1+fCfF32m3EPKFLHSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xf9/ywN4; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xf9/ywN4" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so7827705e9.3 for ; Fri, 06 Feb 2026 05:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385114; x=1770989914; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jGaf7RjpOPMSJQSv1pfAOB/0Xi5hMSSLw6Z4u1Ofeis=; b=Xf9/ywN4JZwLuP3yClISFRfliTv77pLrEeraD7uYfNeyVQwo7cdqc2fa5R8aBeX0+m kmv8wuuJm7yU0qSrJ0Oh8XfUijuoxT8jrctzuVn41pFajuT/P0XCxenxYDIqsQFEgODd kPjNhh9iSA3AWdZG9Muz35kD31ls08Nn3FMhSc0LR8kC3/i8tBEhG4YHgPs0Q5Hfkqgn 816nlVHgr1tYw0EjZvcTWBAxUyF+JsCRcyrn0mMiK51gTC6oBivYk9/4t4mG5BZcE0yv DfOmLk3kL0KgSTXW6cgXOMnyLNklG8ArKdySRqmsl/o0JlVuIVspVouGXfAZaYiCgdh/ wIKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385114; x=1770989914; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jGaf7RjpOPMSJQSv1pfAOB/0Xi5hMSSLw6Z4u1Ofeis=; b=Ubu0Lxfo0HEvjQmYIi5BqbXY6rnPP2rJV1jtdxRZcE14Ky5//lIqpPTY4Hb2nkVY/a YEP116UTzHTstUqI/ohZrZgAfwDBYRVaEz1y7qU3hf0JxVlzMQeoys0NRSOM/FB7Cxmu UlLc/xu4AUYbL3vksV8pM3p+PyDm4xpOTnWBSsZJTizeAnShdoTThABV4F79Kh7lsL43 pcD7awh4RvUvpO8yU+bnqGWvZtVEFiQzr+6UpUkltW9PXitpRlkIaBKyk4s/ba6GBIWB jZOcbWe1wXhd6DL3LyX1LbOMEEdFBQjklSDbQ0miVSfmdPXxl2cjDfzXTXniJsmR/wLn Jo3g== X-Forwarded-Encrypted: i=1; AJvYcCVcFhRY3xR08qAXAg61RTu797MURK0qC8uukdC0nGhNM93Qyae5GHaCW+e3YfYev8fv9dglwW1mSCn1s0A=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Z+oQyY8NkIh3zpqnYtD6dazSnsOs17Z7J7oaAf/+Kzoi026r sJB6zl9Wqjew7g7dmloWsXpxSpEuhnPmjrHpi8G9zK4x7krYyebR0PBFwEWCq3yuX2Q= X-Gm-Gg: AZuq6aJq4Gib8tjhnoyDRJU2SVQqzymz0HWdNy1opI+IpEQlhklIEwxyHzhvQcb4+1g cNJp/yL85xiww1E9gHCrMwN1XsRKRLSac4Dgfciejw7tLlJrBQLIgaUphMROcEBr3eCUh9PoAk1 DUEJKRqrPphG6HTcyJFN7PrAawR7LjgRhSmxCuGKhb6PrRFIoqbqf4LGSTnnrt0Q3XpzDJXG4R4 uKUGTKZqezrbZT95ABx/FSHpfWj84YFgb8qYWh+QneOZiglgRmNE3NEVOrtqXQe1SM55E+uDGH/ ieyQZi6ZWNuOWRvTY0qyNFW4nHYdBeWrSTSemszc1B0BuaXeAFQOTE5irDyjThL0e6CYcVyV8Go 5wLERpUA0I6L2yi4Vg60MzcvDZwtKPGFOF9ZGFQUXeenQvc0a/uw52d7XwtbS6eJayE2fYzSs8G coWKfhATDR4Gcl2Wkj X-Received: by 2002:a05:600c:8b88:b0:47e:e20e:bbb0 with SMTP id 5b1f17b1804b1-483201d9fa8mr40917305e9.6.1770385113871; Fri, 06 Feb 2026 05:38:33 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d2bab2sm231973995e9.3.2026.02.06.05.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:38:33 -0800 (PST) Date: Fri, 6 Feb 2026 16:38:30 +0300 From: Dan Carpenter To: Stephan Gerhold Cc: Johannes Berg , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel Subject: [bug report] net: wwan: Add Qualcomm BAM-DMUX WWAN network driver Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Stephan Gerhold, Commit 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver") from Nov 27, 2021 (linux-next), leads to the following Smatch static checker warning: drivers/net/wwan/qcom_bam_dmux.c:505 bam_dmux_cmd_data() error: buffer overflow 'dmux->netdevs' 8 <= 255 user_rl='0-255' uncapped drivers/net/wwan/qcom_bam_dmux.c 500 static void bam_dmux_cmd_data(struct bam_dmux_skb_dma *skb_dma) 501 { 502 struct bam_dmux *dmux = skb_dma->dmux; 503 struct sk_buff *skb = skb_dma->skb; 504 struct bam_dmux_hdr *hdr = (struct bam_dmux_hdr *)skb->data; --> 505 struct net_device *netdev = dmux->netdevs[hdr->ch]; ^^^^^^^ Smatch thinks skb->data is untrusted. This is the rx path. 506 507 if (!netdev || !netif_running(netdev)) { 508 dev_warn(dmux->dev, "Data for inactive channel %u\n", hdr->ch); 509 return; 510 } 511 regards, dan carpenter