From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B845F1F9ECB for ; Fri, 6 Feb 2026 13:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385125; cv=none; b=kYBst6DP+NPi5bNDBactGwy2kv0F7s/qt9s2Vhrx71bD8MqwC9cfdzsYpecnDLjRxce6CB3iw1FQ22swNVzNa2l3MJtqRkJsAaaMcc/vVzK8YVdXlTOPFGr1XZ5iTFnxnbSTeKb0OGqCeHkYnxZoMBJRRgJG6vKHaGVoAB1YR24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385125; c=relaxed/simple; bh=KU1YABdNd+/uaBrnrntgbyAveorJ8ZAcuiJrd0CgtMU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=U6YpdyfYAS8tXQAQ9cFIhInxAlqBsk5iIOWYDu+aPeDI49Wqghrn9tkoWz7eumSHV5p31H+jDmiXw7qnxwhaLIxlmZukrtq/yeg5xa2N5eYWG6kBPHweacofRedq8QfzmpErnn9vP/sNVfuGKRIQVjcSybq9gk8C+JM3anW4Omg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UAkvqopt; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UAkvqopt" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-481188b7760so15726005e9.0 for ; Fri, 06 Feb 2026 05:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385123; x=1770989923; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gMr4rK4OUpc4zqGvHkqL1hsf5l7NXMQg7IzIbQkdIAI=; b=UAkvqoptGfF3llI4djKgptcnU/sEUuKzeHy1/Dba4yxwGvc3gP1bsa9oQ2b314XZdv w4q53J2e+ROhWifNw0rVTOOXVU6EHB+iO915nnaumI4pJVXxTHr6j9yw/bCEicvdJIxZ ROHaZECyK04pf5oW0PfidKecRlIqGf4dVIbA0JpxO0wPtp2awSi25BnjlxRtCodRsKMs LMX5fozFJcpPtIkKbrO6hNamyhmmcyJURXAumJ3IEnrZMCCDJJtCr0YQ6QOWnHBE0M0G HP/AjPuhTGKA6l6NpjXhDQym5CDkB3xGzM323xq7tEgDwb5RSQXwXg4KLSeZGeL7WGF9 rqUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385123; x=1770989923; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gMr4rK4OUpc4zqGvHkqL1hsf5l7NXMQg7IzIbQkdIAI=; b=NIVtkc5HZUXf1b5G906N5MV6S79UQY6dYK1mLU1WyBPdgavw49HL8hIYG4bOphoq12 2ALLqDC045HhZzKFTd/n7tc85yFM1eUNlShVksFjcufx1HUk3oEwluNMqBJl5NGSZHQm Fnyb+SgomlUDtNWVWNJo3C4i1PvINtpw8GXgBnWfobf3QVS8FGj7ZkHysM5RZNd0BtpW wVkhUApw8XbWmoDwUb4JEXtsi8axeevlO/Ujj1EjyUk+NxHZ2Yf1eRct5Wj8/PNcdwR4 78KD6GHHblFmOlO91+U+cOcGhlvfhTTARyQDX/y8XQ4k65alfXEe0SyKymSX75a/KrjQ JWDQ== X-Forwarded-Encrypted: i=1; AJvYcCUYvgRH99nnaOeUfhbTMy1YXpUC3JJ4cOmw71beYDMsnO18FVjNqz3/6pYWjOyS+D6yIxwOZ0fygCriGXE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxfp1mKET391/kx2fr6CA7jxgQESX6rroJWT/yq/2fl0OiXCPwV xHvsPw40z8eu7+8iw2dZbUIsjuKfLGDS9e+zAFW5Ic/VvUPUKqOLI+u2t9ViVk4DF/xIpRNKGKv 7DGzR X-Gm-Gg: AZuq6aKq/63aG/G4QEuyg9zETPrcMOM9T98rs2CIF5UpHKpF57uk2z1wJEKh4YhawDe B9a8bQkvUba7xl7wA2V9DO/T5Shv+6GtPnCimQm4ll6fXfgeAbWDiw5xSbroVZvYmWwdbWrfr9v oehutLUf/03RIWI7Rbtq5aokSR7VYqIwUxPZVphXLm+PdH2DszFm9SNHivircYcWnwn6m75mTci jKA8Sr/OCVoRwU78vR/r50kIpCTVmuFBhS1Kpw240+iQuKK4CT9RRweqCl4Qv3ZdLipvRrs8AkI cIuqADQccSkl/PhZgpeIWdghix3lHiAnVrNCr7z8vuvh6uTvuASDjtsw11q+7OJ+/S6+ALA53R0 IER/jQh2zXdRO6PywmBbL75GTU9+hmXwrLNLcN15MDbdDCGHGZEkNmSy69rKMob+gUFRJoBDzMP lfIrxQdZNSSjDwL5VE X-Received: by 2002:a05:600c:19d1:b0:477:9a28:b09a with SMTP id 5b1f17b1804b1-483208b9470mr34995085e9.0.1770385122950; Fri, 06 Feb 2026 05:38:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48323c12d74sm28249815e9.2.2026.02.06.05.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:38:42 -0800 (PST) Date: Fri, 6 Feb 2026 16:38:39 +0300 From: Dan Carpenter To: Suravee Suthikulpanit Cc: iommu@lists.linux.dev, linux-kernel Subject: [bug report] iommu/amd: Introduce gDomID-to-hDomID Mapping and handle parent domain invalidation Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Suravee Suthikulpanit, Commit 757d2b1fdf5b ("iommu/amd: Introduce gDomID-to-hDomID Mapping and handle parent domain invalidation") from Jan 15, 2026 (linux-next), leads to the following Smatch static checker warning: drivers/iommu/amd/nested.c:161 amd_iommu_alloc_domain_nested() warn: 'gdom_info->hdom_id' unsigned <= 0 drivers/iommu/amd/nested.c 148 /* Check if gDomID exist */ 149 if (refcount_inc_not_zero(&gdom_info->users)) { 150 ndom->gdom_info = gdom_info; 151 xa_unlock(&aviommu->gdomid_array); 152 153 pr_debug("%s: Found gdom_id=%#x, hdom_id=%#x\n", 154 __func__, ndom->gdom_id, gdom_info->hdom_id); 155 156 return &ndom->domain; 157 } 158 159 /* The gDomID does not exist. We allocate new hdom_id */ 160 gdom_info->hdom_id = amd_iommu_pdom_id_alloc(); --> 161 if (gdom_info->hdom_id <= 0) { gdom_info->hdom_id is unsigned. amd_iommu_pdom_id_alloc() can't return zero. It either returns negatives or 1-65535. 162 __xa_cmpxchg(&aviommu->gdomid_array, 163 ndom->gdom_id, gdom_info, NULL, GFP_ATOMIC); 164 xa_unlock(&aviommu->gdomid_array); 165 ret = -ENOSPC; 166 goto out_err_gdom_info; 167 } 168 169 ndom->gdom_info = gdom_info; regards, dan carpenter