From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30D11F9ECB for ; Fri, 6 Feb 2026 13:38:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385132; cv=none; b=ZW2MOrgSkPNbsMTBRUg3jdsA74Scze4hvE0WnJQHf+VZHkJxXL+OF9HjOn+ZZhzI65l0Wi8vRV5FcGGvaUhP7v2rpD430RIFi5vq6WOrabeGLNWX5wRiCs7Q7kre2L/fc+xZZstbKMnFR5EiThynq7LNkrGQkGbSDIE/PQPL3dE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385132; c=relaxed/simple; bh=IsztOKIQYgWnzUGwEnUhUyz6ocpTfAuVVmr78xr43pQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=HCL7ufCJMb9QxMjkPGqMdKTWJcAfTlczuAY6vq62jd1GAz3fNJGaXp864kKi9/QqcdzLG3b1qmT5qlP9zDNU8QhOBY2SdDMqqydvJ9hg61vd3G6eSHH7wVkSebEvWvWoR6S/5J2KcZMBtTG5d64mAhpvldufOaEqaM1rq1Bek0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zxcvpIz/; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zxcvpIz/" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4806dffc64cso18656995e9.1 for ; Fri, 06 Feb 2026 05:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385130; x=1770989930; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dGXuZ2bOJzj6fDAM/WtbEOtc9kf3G9+rpIVm4yXWvd4=; b=zxcvpIz/YLgy8X4nLNNu8pRbsOLjciWI5tDdrybip7Tdx/w5R97YKuFHaT/I/XmhKY g2vhd4yMv+Kr1ZziXLHSR2mWYo77SCmy9f3HTBEi4lPdW3hEL3T3nz4tC1iULySaM9Uw MNu+sy++m3UMlKNnuvKQBJ5TbJmaBQBbUyxouE2nHkLrxY4hXvJLy/Np+5ijZ4jDZeOn eD7n1KOr7xZmnUZsieG3BFKX9WETcOysUDsZzNEpbzoj7lbgAam0bw4N0kArwITD4gl8 1w2j4qnKwogpVobQ3eMDN4CimlCLhMwfqEstV+9dm0mFl2Mp3UO44/GHJX2FH2r+myhX FFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385130; x=1770989930; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dGXuZ2bOJzj6fDAM/WtbEOtc9kf3G9+rpIVm4yXWvd4=; b=j8SW7TUaHuaUp7fAKErEkenoBZg9GUQ6A5k1z3HwewS1pnMv7pcCwIYXL2ym1f22Hi 8iDwXNpOaI20td+lwcW/xJ4uIeUewDj960DdwesLCuBvKhmGJN4Dyk7Z1iwr1/bs4A7r /L6VIBvOSOMtk77u9Ryd3WRdtqAQWo4u7eAhTJsrki6ar2fquaSnS+npl+pSEbovISYp eZ+fn2HL4IacNBLb58VJBQ/oq5w4bNnLEK1ABrMmgFmdAPGmWsRZkggpaqFmM5A/WRtU LHnLc5dRNFwc0pLmitGZO2DqGi+oPs6xBiHAmEwvRJXjU16+E7CKpA72sZZ18lEwFOCg g9Mg== X-Forwarded-Encrypted: i=1; AJvYcCV3kqLiCx0SxKvDC1GPRTvScaoptBcNmml+KwsbE3Xmq5LLDdwgXdy5Bdp4kEGIqhWDQspcrKbsh6O6+zM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5VfMt+ZMj4U7aP9I1iEziHfMMu8RdxiNK2gVTHF27pC7f8hsS zC92i/H8WWwOwbqT7o5BhvjopywMJdg+NhpzdrMB4lCdbJs2UMs2wPsq6l4xiRQXYg0= X-Gm-Gg: AZuq6aIUOyE+1wGl8ErJNhpqoxOAJIYn/gryZ5a0pllOndKyx4OSmzHgq94Pe5JeAIb l3u4tj0Nmm0oKH94HS+LvpxHRmIl8BjtnSZZb0VI4JEg9YwN2U5vvC2LDpW6g5lZjyvRX+oiB/A zrEbGIhkOYyLVv7M3ib8W1cLEzKQ0dHSfwKtSOXjGD0lTkyZw9HnVg6IljEYf0JHt4dHJdAWWlK W5TEYnXnG+K+XBeeLLgOfktKaPu5rm/fidjx5D4N5k6TSpwjuL8r3Mp3TWkLJ2fB5yxMl2WZoxU 1j8AEP97Fw20nCk7RoNn8UT9e5CMr5aazRbqYCtF3DPiUJcWzUsnZlTLK1AngLWwy1aUXx7rYeI UAj5hQkcJ3c/OoLUY5HxaVOaIdAOcpGEMS4bnWnFBBUSFXI6jZe6wGQ18zDcT9SeDwGMU/fTfy6 HE5mODxsSka58+fSvm X-Received: by 2002:a05:600c:548e:b0:480:1e40:3d2 with SMTP id 5b1f17b1804b1-48320983bf7mr29532005e9.29.1770385129893; Fri, 06 Feb 2026 05:38:49 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4362972fb16sm6077760f8f.25.2026.02.06.05.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:38:49 -0800 (PST) Date: Fri, 6 Feb 2026 16:38:46 +0300 From: Dan Carpenter To: Jonathan Kim Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "SHANMUGAM, SRINIVASAN" , linux-kernel Subject: [bug report] drm/amdkfd: add debug set and clear address watch points operation Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Jonathan Kim, Commit e0f85f4690d0 ("drm/amdkfd: add debug set and clear address watch points operation") from May 6, 2022 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_debug.c:448 kfd_dbg_trap_clear_dev_address_watch() error: buffer overflow 'pdd->watch_points' 4 <= u32max user_rl='0-3,2147483648-u32max' uncapped drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_debug.c 433 int kfd_dbg_trap_clear_dev_address_watch(struct kfd_process_device *pdd, 434 uint32_t watch_id) 435 { 436 int r; 437 438 if (!kfd_dbg_owns_dev_watch_id(pdd, watch_id)) kfd_dbg_owns_dev_watch_id() doesn't check for negative values so if watch_id is larger than INT_MAX it leads to a buffer overflow. (Negative shifts are undefined). 439 return -EINVAL; 440 441 if (!pdd->dev->kfd->shared_resources.enable_mes) { 442 r = debug_lock_and_unmap(pdd->dev->dqm); 443 if (r) 444 return r; 445 } 446 447 amdgpu_gfx_off_ctrl(pdd->dev->adev, false); --> 448 pdd->watch_points[watch_id] = pdd->dev->kfd2kgd->clear_address_watch( 449 pdd->dev->adev, 450 watch_id); 451 amdgpu_gfx_off_ctrl(pdd->dev->adev, true); 452 453 if (!pdd->dev->kfd->shared_resources.enable_mes) 454 r = debug_map_and_unlock(pdd->dev->dqm); 455 else 456 r = kfd_dbg_set_mes_debug_mode(pdd, true); 457 458 kfd_dbg_clear_dev_watch_id(pdd, watch_id); 459 460 return r; 461 } regards, dan carpenter