From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 510DA3DA7FC for ; Fri, 6 Feb 2026 13:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385157; cv=none; b=fPTYFwrO+HB0Ga+d6VzgAZ+X9YBPP6Mi6vs4j+fzTMVe7mtR6wglkW2bTcv8DvDcWmS9jW3gENACeu+/Vu5+CeCj1dknRchRgZbLoR9MseEQqUvb/b4n9IOTP2CaX38kvasyn+ipYJ2ETrLuF6VU8Ysd7F9/risiOoKx+bwL22Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385157; c=relaxed/simple; bh=YQ0XkX+7IHhyPfDazRs/Y+8VRB6879z4/kNcHXjWDc0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=WP1DTyYigqK9BmVGL6Q5iqsujhKTNsKk1ee13UMegRuNeLbKLoRh2rLY3J8vO7ADjwiA6T7sXd3q1EEqW8xVSYbTXlJeHHInCH6HU/AcY/Ps9TCakiISLKDMQBQN9MS6pOou1ihAXeMIImJEYB19qALj/ZQ2HJQxcQ0BAGKqrdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yB0O91Jg; arc=none smtp.client-ip=209.85.221.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yB0O91Jg" Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-4362c63531bso462055f8f.0 for ; Fri, 06 Feb 2026 05:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385156; x=1770989956; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xktNeFfMDcufE5X/S0bJkx8CgzqCPcdz5dELVBNTvag=; b=yB0O91JgHaUw3Zy1J1hrVVLtsDUXgm4sbr8F58yDtXjW/nawLfMy3OskiE22oGNknv CKSNtoUJ1R/dLVfHsKsyLH0fRokVEfU96Huh5Xs9T/Naa+GT2Fi+DocMKu+dD+DKY8vv AAzFtIHP7d8VY1yDUYkGxGaxt8b0CLvZvTNAEP5NraWq9tq/sOkARxKEQn6031i0jNoT AQA4bD+TYB3+z3lafrcSKArQEkdsQlGamyEPyM3Sio9ChcC9lP3czBjIBqaEJgMCjpGp JfBeiVVhuu056UqM+TqduBedMlAaXF9qZiTvjN9Vtf0pjVpPTQuEQvIIAioy56Au9GyU nniw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385156; x=1770989956; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xktNeFfMDcufE5X/S0bJkx8CgzqCPcdz5dELVBNTvag=; b=ts1S4DIvnoR3eb63PT5AeNFARr2oh52Ti/hRgQyaiy0bDdmaaeSIXLMu0pRr1Ct6mB Ym2lgjYZ5G6KTXO37kRjukmCyzm3fnfhxf4ZHlxiHV1ZWMuSvUDVdE/iPHmo0M7soDq+ T8IS5IxkZ4p/0ln704kxLHHV2s5V8uWZst51vPjtFOfSChT//sYGlbcln3WASnX7lxYV aTNYrG59ymTONICZSx2IDYttCDS4suElpjWUR0qIAwsBvb9DOpL79X9GjJqRuKCAIsgs 4TR0JVbqQUiSQ9jEX0GP0AQrd2P3nAhvMW+LTJscMeMRfL3Pzhl5or8IlX+PwStS9KOn Pbag== X-Forwarded-Encrypted: i=1; AJvYcCXyU39NfV0rbGgmLqAZyIA/+wp0Ka7GrM8nVSHtz19HlFRPqcQ0PIePUTXjYzesewWTtI/yaVcMKH16NjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwDrhOBqY2YQc2d5wlPW4C/HER6gVOKfYOoLO1TEMjdYDa+HMJ6 b+eXf+3Zdoz1HC+sXjMhP5EBiPseGy2HPx6Yw/3MzzF0aYS654F+ADdaq2fM3hW9Ul0= X-Gm-Gg: AZuq6aJbHuySpWD0v/hJ41EefAShLkiVkDobKxnDuImji2BuQxo1Jldlx/yHiSNkM8l 0aL7W9ftruAAfgZNT5RrO9eIiUiV6AWpuceYSyyk5/L9lwN2TESbt5YpVAB5FfduKXUS85NNdzN f1wlYUSmnS7GjxQJZI877VZMoSTJYvyY2Em7XaFTGBWoVKhyBCEsdb4CIhVn8fJc5Nmjf3kGDuy B+9OCNiR6JID0IQjvh62+jF9hZRnXHdElI+odj2rFGaod0xwuwN8qt7o0yKYf4TjGY4xgOpayT2 pkzvQ7kmA83he88+LE8vUceBVs4HGfMgLKhjFrS2NUybl42x52jRW5/1wvAygSh35qsZisZlMiN kQnRja1jSR+1hhvDtSeT3bP6j4I5k//c3qRpG822EyGDkONeYFrVP2dnsztZEA1g6A2JvcoIGBe BrCUxGuNVr+/cgbHUo X-Received: by 2002:a05:6000:2012:b0:430:fb6d:1442 with SMTP id ffacd0b85a97d-43629386018mr4933601f8f.62.1770385155422; Fri, 06 Feb 2026 05:39:15 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd3b8sm5888949f8f.11.2026.02.06.05.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:39:15 -0800 (PST) Date: Fri, 6 Feb 2026 16:39:12 +0300 From: Dan Carpenter To: Grygorii Strashko Cc: netdev@vger.kernel.org, linux-kernel Subject: [bug report] net: ethernet: ti: am65-cpsw: enable bc/mc storm prevention support Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Grygorii Strashko, Commit 5ec836be11b3 ("net: ethernet: ti: am65-cpsw: enable bc/mc storm prevention support") from Apr 12, 2022 (linux-next), leads to the following Smatch static checker warning: drivers/net/ethernet/ti/am65-cpsw-qos.c:1126 am65_cpsw_qos_configure_clsflower() warn: iterator 'i' not incremented drivers/net/ethernet/ti/am65-cpsw-qos.c 1118 static int am65_cpsw_qos_configure_clsflower(struct am65_cpsw_port *port, 1119 struct flow_cls_offload *cls) 1120 { 1121 struct flow_rule *rule = flow_cls_offload_flow_rule(cls); 1122 struct netlink_ext_ack *extack = cls->common.extack; 1123 const struct flow_action_entry *act; 1124 int i, ret; 1125 --> 1126 flow_action_for_each(i, act, &rule->action) { This loop only iterates one time. Is that intentional? We could use "act = flow_action_first_entry_geti(&rule->action);" if we just want the first entry. 1127 switch (act->id) { 1128 case FLOW_ACTION_POLICE: 1129 ret = am65_cpsw_qos_clsflower_policer_validate(&rule->action, act, extack); 1130 if (ret) 1131 return ret; 1132 1133 return am65_cpsw_qos_clsflower_add_policer(port, extack, cls, 1134 act->police.rate_pkt_ps); 1135 default: 1136 NL_SET_ERR_MSG_MOD(extack, 1137 "Action not supported"); 1138 return -EOPNOTSUPP; 1139 } 1140 } 1141 return -EOPNOTSUPP; 1142 } regards, dan carpenter