From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE073D7D77 for ; Fri, 6 Feb 2026 13:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385162; cv=none; b=M8/oPLYjfAX2fY7otkV3w4H9NjcAw4OxsHpWo9soO7Y+8d0Zes/x/wVIOZxuL9C8IR8qZQrZSQ6RGxk6R2QqhrMi3/v0M76OhqcHtu8sfh/gUv+r+iY4aZ+X2AYKC9S9lhfBKumBrKkdcqYZ02kKNy+5egXsdcUlDZYtp+OunuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385162; c=relaxed/simple; bh=0Qw6hB+Nw2XGW1mInvxA4FANXWw4l14cjCxZ4XJhV14=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=EZQSswc9QQ72om7zs0T8NzgP4TuONfVpKWlxSaSHXeONlMlLIjBiRZ5VCAKj6VH28kmkgKQUuF02ZHW+kYc/kgu8ZgmVCBYYPutJ1qJ5df+RREEtRmk8Psy5+6wizaqol/VGkWPsDYRI7DI4o6PRrcU/pKmGYOdD4Yw861SETG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oTIOfwJT; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oTIOfwJT" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so32224725e9.0 for ; Fri, 06 Feb 2026 05:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385160; x=1770989960; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pkmg6MECDuPF+xcEwX762rYgEkjZEg/GKrH4QFrx1WE=; b=oTIOfwJT8MKS6nWzQAlVvh0VEvgRxl4lVwVVgVPlG67hVvU+cyEvcW1TCnS0O/lGk2 Q2lTq0RchRcDNjJi3J4y47AGfKxYU2xebPea2UoBhCy9WECc0R4m0We2d+H9XzD357M0 78N6wgEnPq8sPGGD2LM4Bh5BEoWDXy3gGFbXbkwQ3GdNua/T/HYQdfioLhpA9hjHQ9tz 3S2OFzDyIo2SEj4AX+mE8/HOpj+0mQ/R2xDdl2WEQhOR5hVdX9Lvl81tx7VfOfWUcxfC px2ilBG3QA9U4o3folBwL4OUseh/H+KP2mDcpfJVzBD3AeYwt0nAz6u5y67djWoXFqAJ Fxgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385160; x=1770989960; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pkmg6MECDuPF+xcEwX762rYgEkjZEg/GKrH4QFrx1WE=; b=KK3s9RUKLHXMHCpP7LZp7vKpf1M3tJsvSBKknH3Jw5j2zdYIJkcVC3Yafcnsd23hpU KyR23o39FDF62cJ8LfcZbSQu3CNYlZeKFq2DedlI/bNSQaLPkY0o9sMkRArRsHhEE+TR ti6h+1PCRlwpxHqtOob+/VZSepMBl6NOs7+qD4+hzcEyZCNq2RgDPb6jKguRYOzyplcN D4eSo2NNuoo0iGbOzuIlUpkVpKQZTDTYCpoE9XgPA5wLKs59NhEFDQOgNRSudAlSgSwX acd7FPciSvyhTfEpmKyeKB4kuco10FWkTUMOcuNIwuIYvnNZ7OPeMitlVBWK7yk1YJyA ceHw== X-Forwarded-Encrypted: i=1; AJvYcCWOVAWdjpdcPEFxRUvdHToWm3JuZg0s5FhujiDjWxvbJUJhVQsxzKA+VFnDykxkF8GO+zJZB9qKowRHgSk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywntd6ybQFzbf/hd+roHqVH570QRWoj7WjFcOBJ68yCwi5O287W tYIxnS268XxhNcPo0XNYpbvb3fW9Rj/C6WbmYBVr8aaEG3C/oNJseYKbblo0/ZbG+Pw= X-Gm-Gg: AZuq6aJlLnG22N+qqhGm6UqvFMzwtHe5GtBA9jO6bJsL2G/XAtilBI0flHEol7cnz4T GhFhKJzwkadInAFAIYHbikXKbjdtGwEHOnp1U7NtXJwfLN1J1xb122FLkLSBMhKjVqXoWpZxi2a ibSRStEFlS/0ED416+1Y4yfeY887FCN2kBz7VzmJwHQ/4SxTgD9SbKbPuPsx9iqPkSVJVYKEWpm k/9PqSuayjAAtFzLRLy5s5zgouE6oAkdC9EWacg/R8X9EZxag8TKs6GOYEKTLmUJ+Gn2CHBEu0V +cdhKjCaR0ICx9pJpc0kYftNgo8rfESCKYvDkDKK55dcs3eUTeasObWQqeYnpd3MbKwAGOPBS7q gy1yBX1WLRiFPW4o17UF1vi+yBC4kr2tM9RtbomDDo8IubPlrgGq+xjqGJV+6fq7LGyi+JN8s82 OiCHPACwYcjdXuvEg1 X-Received: by 2002:a05:600c:64c6:b0:477:a36f:1a57 with SMTP id 5b1f17b1804b1-483201fffeamr38774665e9.3.1770385159943; Fri, 06 Feb 2026 05:39:19 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d2ba61sm196904435e9.1.2026.02.06.05.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:39:19 -0800 (PST) Date: Fri, 6 Feb 2026 16:39:16 +0300 From: Dan Carpenter To: Xiangxu Yin Cc: Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel Subject: [bug report] phy: qcom: qmp-usbc: Add QCS615 USB/DP PHY config and DP mode support Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Xiangxu Yin, Commit 81791c45c8e0 ("phy: qcom: qmp-usbc: Add QCS615 USB/DP PHY config and DP mode support") from Dec 15, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/phy/qualcomm/phy-qcom-qmp-usbc.c:803 qmp_v2_configure_dp_swing() index hardmax out of bounds '(*cfg->swing_tbl)[v_level]' size=4 max='4' rl='0-4' drivers/phy/qualcomm/phy-qcom-qmp-usbc.c 777 static int qmp_v2_configure_dp_swing(struct qmp_usbc *qmp) 778 { 779 const struct qmp_phy_cfg *cfg = qmp->cfg; 780 const struct phy_configure_opts_dp *dp_opts = &qmp->dp_opts; 781 void __iomem *tx = qmp->dp_tx; 782 void __iomem *tx2 = qmp->dp_tx2; 783 unsigned int v_level = 0, p_level = 0; 784 u8 voltage_swing_cfg, pre_emphasis_cfg; 785 int i; 786 787 if (dp_opts->lanes > 4) { 788 dev_err(qmp->dev, "Invalid lane_num(%d)\n", dp_opts->lanes); 789 return -EINVAL; 790 } 791 792 for (i = 0; i < dp_opts->lanes; i++) { 793 v_level = max(v_level, dp_opts->voltage[i]); 794 p_level = max(p_level, dp_opts->pre[i]); 795 } 796 797 if (v_level > 4 || p_level > 4) { These should be >= 4 instead of >. 798 dev_err(qmp->dev, "Invalid v(%d) | p(%d) level)\n", 799 v_level, p_level); 800 return -EINVAL; 801 } 802 --> 803 voltage_swing_cfg = (*cfg->swing_tbl)[v_level][p_level]; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This is a 4x4 array. 804 pre_emphasis_cfg = (*cfg->pre_emphasis_tbl)[v_level][p_level]; 805 806 voltage_swing_cfg |= DP_PHY_TXn_TX_DRV_LVL_MUX_EN; 807 pre_emphasis_cfg |= DP_PHY_TXn_TX_EMP_POST1_LVL_MUX_EN; 808 809 if (voltage_swing_cfg == 0xff && pre_emphasis_cfg == 0xff) 810 return -EINVAL; 811 812 writel(voltage_swing_cfg, tx + QSERDES_V2_TX_TX_DRV_LVL); 813 writel(pre_emphasis_cfg, tx + QSERDES_V2_TX_TX_EMP_POST1_LVL); 814 writel(voltage_swing_cfg, tx2 + QSERDES_V2_TX_TX_DRV_LVL); 815 writel(pre_emphasis_cfg, tx2 + QSERDES_V2_TX_TX_EMP_POST1_LVL); 816 817 return 0; 818 } regards, dan carpenter