From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CCB73D7D9E for ; Fri, 6 Feb 2026 13:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385166; cv=none; b=jay6XCFu4HFO+Fgqobp5vm9XMiqQqz+cnebuQyy/FXfqFReLrDAFYs6Rmg4Qqj97XkK7klKCWtvZO6qJUJxBTrlki4NRRCb5od0hQ/zsbK27xaNMxZcEFEQb0Z8ubqMmiSUh9/BtiHndbxbhCTXBf0mfp2SyFHZK2eKxxkJjkBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385166; c=relaxed/simple; bh=7MaTyxAxVRk//661c54XCKAAgzUqLidR/EIZhkDR28o=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=grBW8uXHJx/6C4T4qtgt1orVkaxGRG5Bn/uenxmX72p6WD7PJcQlUQ9MPUrlfkMrXRF7qC86mIKCVKuHsi4NVj9bTPNnKaBv1a4dMkq38TJn2S2BGhUl5Jea4T0AS+LaquGvd2aaJgYqNaqLnLEc9UXU754zbWQgVSDsWhIpIDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UaJtAEoB; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UaJtAEoB" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so21627025e9.1 for ; Fri, 06 Feb 2026 05:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385164; x=1770989964; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BuQje3pA3puYqE5cqm2DgR3QniDFMdzkaAWaIa9THpo=; b=UaJtAEoB7ZeBSe2jjkBuN1ktOrhVBtU3jbGde0CP5tIN3WU7jPZ4wEMSK0UUnTp5eB IEiFgbIp7U/GlDufMcdFIoGujIJvoi7BoCPWTIIDWs6pwgAR3UM3revfmpO60Tx460Fb XWYQXcidNqb3XErP4L205V9W+O0oe+LOy25rFrGsQVSxMU7SStcGMNiPxRN8lHJBpR4u cUMRdqonzZi1NvPc2SDifztHjiYDNDynkxMLfCfTOqbRRf1Bnb6MWJ87BKwWJuM1FnrK yYwXhiuUz/SMxHk8Pq9j8MxGI5pHvOhNO4uPZE8dnQwO+ozfpyHM2fR5+1HDWYKjpnNG lHQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385164; x=1770989964; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BuQje3pA3puYqE5cqm2DgR3QniDFMdzkaAWaIa9THpo=; b=KcyJeB8JpbKiDJ64jzG8aHozC8ake5sbws+x+RqFOsV9cVo9RxRWJdOx4AyXzl1CNo iqkZMaQmfwoGZEe+m71p55Dpcj3/pLjh5PwF1zZ6UxO8dw2QggO4cSZ2c+uw9POkmWaF V8BR2NGdU/m0Jq5aX1gVE0O4P7kPJb+OoPnQdrt+8gsXSSlcgLLlUFgXMdJnPXMevU1O Bars70YcR2XM04aTdCsPDvaoHCHL2EemYKLyGBLtYy52R68QewXlElr2CuCVJeCXX6NZ WD+4c0OKce6xMqZWfLxwwlAtXv6UaMNiHzWXIWZM8llO1YwVJEJ7HAwwwG0ffEMA5jUV EJRA== X-Forwarded-Encrypted: i=1; AJvYcCXWOhq/vjwneCdCfc6wtYJ4UB3x8S496DUWd2glisQgqCt3/M7cvFxy2Ghxx/qFnpAy+ulA1t0NanNfxSk=@vger.kernel.org X-Gm-Message-State: AOJu0YxfQzgbosKDtCCka1b2quCrA5c6pLlRgedT7B7IVUCFT1Y5eyLK P29MRj+YAmmzwXyg/c4oinGKzdykRWERRLPjj/c4BO7+GXugm0YpYywOpSI3hQY1G/OVy8xUNWT 7Im// X-Gm-Gg: AZuq6aKXTVRCMHCEDXtC2RcBd/7H7udrha6ex0whJ722+/7J202ZWZ4ww6IuGKO962W IMnWNEsXgEchDAi2CEbLgVz0QguOf00/a4pkuPbGaoKIj8qZE9UioH8Dl3J4bWxD6Lw7BNmLKqu O88M5EJIdjhG08lc8TO3kkdqTtjowizJDOm5aUre/5H4O9a7o9s+9CamTfCc9bVB7PEMOYiP2Yo FO3QXybxoWSDAIUqtzrdudIccBMNl5oX4xJAtdVZFuhpmkYFCcL0Xbz7idiwX5tjfhA8zSsgGVA BsHDhxZ4zTcgspQbIQIWlhu+OCt3J1a7dyJttKSwEOP/St2dsC7h+ZG+0BShyuWVlcwbclqygep VFb3JQFJeut1Gfznom9LVBjea4ed+rCQ6z5EYYwqTfiKxb7xDDePiSN/mLX79PuqOq0qMBHOxNZ fE/Ggols0opaIUBbF8 X-Received: by 2002:a05:600c:8719:b0:482:eec4:76d with SMTP id 5b1f17b1804b1-4832021b461mr45585285e9.17.1770385163857; Fri, 06 Feb 2026 05:39:23 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483206b8bbbsm81414275e9.3.2026.02.06.05.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:39:23 -0800 (PST) Date: Fri, 6 Feb 2026 16:39:20 +0300 From: Dan Carpenter To: Hamza Mahfooz Cc: amd-gfx@lists.freedesktop.org, "SHANMUGAM, SRINIVASAN" , linux-kernel Subject: [bug report] drm/amd/display: add DC changes for DCN351 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Hamza Mahfooz, Commit 2728e9c7c842 ("drm/amd/display: add DC changes for DCN351") from Feb 23, 2024 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn351/dcn351_resource.c:1284 dcn35_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn36/dcn36_resource.c:1285 dcn35_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn321/dcn321_resource.c:1222 dcn321_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn315/dcn315_resource.c:1252 dcn315_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn35/dcn35_resource.c:1304 dcn35_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn32/dcn32_resource.c:1241 dcn32_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn316/dcn316_resource.c:1245 dcn316_stream_encoder_create() index hardmax out of bounds 'stream_enc_regs[eng_id]' size=5 max='5' rl='s32min-5' drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn351/dcn351_resource.c 1246 static struct stream_encoder *dcn35_stream_encoder_create( 1247 enum engine_id eng_id, 1248 struct dc_context *ctx) 1249 { 1250 struct dcn10_stream_encoder *enc1; 1251 struct vpg *vpg; 1252 struct afmt *afmt; 1253 int vpg_inst; 1254 int afmt_inst; 1255 1256 /* Mapping of VPG, AFMT, DME register blocks to DIO block instance */ 1257 if (eng_id <= ENGINE_ID_DIGF) { ENGINE_ID_DIGF is 5. should <= be dc_bios, 1283 eng_id, vpg, afmt, --> 1284 &stream_enc_regs[eng_id], ^^^^^^^^^^^^^^^^^^^^^^^ This stream_enc_regs[] array has 5 elements so we are one element beyond the end of the array. 1285 &se_shift, &se_mask); 1286 1287 return &enc1->base; 1288 } regards, dan carpenter