From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B8C367F56 for ; Fri, 6 Feb 2026 13:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385220; cv=none; b=MjWBWf2N9q3M1r6GzhDXTYtIU1bfSX9v6X3WomT1Te66wZ0Xj0dKvBpuZSVaiS7jbXAOQpk/C2Y+Xf/Kb9pUC2IhFi0fmTRaLx68sJQi8aTzp/OAH7yONgClcQdqtn8iQyJfIKuBkPQ1DBf40ZmGz06m30bSDafDkWNKUQer5Z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385220; c=relaxed/simple; bh=ATlhFGS0epSOhWwfAmwesm2WZpZ/6TNmM7ADuJJY0qg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=pMeuDRlKayojS9m44tERpO9jvy1S+Saa5aBVge6ieH1B6z28+48olfOwZ4G5VMHyhbi0oxgg0Wjt954bwYdBNAm5nfnkdw2iIDT9m+hFlSb4PofWw6fcRuv0XMq+bTOZ/2yvo8v+wCTNWtYB7B/nAMR2FrOTp5oKOV7krHAXqww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xXYnThNv; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xXYnThNv" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43591b55727so632145f8f.3 for ; Fri, 06 Feb 2026 05:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385219; x=1770990019; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qZEaDFtgFd37DlJ4dWpEVneMMIpWVukSb9jk36O2nM4=; b=xXYnThNvDNlyJjQjAH3smf0o6mRv+HAM7DeNZtlMBNhHnSgZmMyv6+qxp0SIQrMowJ 6jy1kkW2g+bnbape2o9jpz9C+Ki700SSs+4D0Uw8wIeuqHIBJtJWH1C8lpv98JH0oJfi +F9cN5tx7jQek/szBwzQ8Y/fXKmSm0zlkYWnZmjlel+S8F1aLzM4/l6xC3IwfCTMyBfs je8haMIiWxKxJJ5VOar9lVWO252IRb0721ZyLqDLY61W9px/QQUyffixS/cUzfuUdXjT I6MsbKnBGoorC6R91Yf4eVjt84OTBoPmPAw7QQZsLkwugmSU15ESr5uB6nk0cFLSujub H7Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385219; x=1770990019; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qZEaDFtgFd37DlJ4dWpEVneMMIpWVukSb9jk36O2nM4=; b=hJ0If3PuO8KGxLvRLESF1DwBfJvLExJZHdfp7N252XIXmTEDtu0+vP3Lg4s/MgIVTj eLq9jSK7W4LhTG74tck3gHQDA0vukdnnGAqW9sxEPE2HAp21uK9hqIFBD9IYi2rdfnV2 JdfLAwfr/YNIQLOCEwc7fMt32IqgxkJjk8ah/DQ/PKbln3f73xqK4648jfJ5H4cldViL yByFlXgfISlcM+PWos1mVOkfC8Kxse751gl9hwGCnI0oeGWk32xAjnvj4saYXREObXTy nGSb+BV+PkdVXOfFMBRrhRUpGHBu5HFNc94KSBxTD3LxqP5na3HkoSnAuvH3IuEvtv5O k6KA== X-Forwarded-Encrypted: i=1; AJvYcCVANrgbmBRym05Rflmn0UeJLY2tTBy/N4ahv+HJm/f/bX0sZfGCBOf1ybcbvcIqMpBOgIyZgz558tChyc8=@vger.kernel.org X-Gm-Message-State: AOJu0YyoeFJ4Z/ESiY+ma3fxN1tWbmTUr1genpq5l//NCpswgw3ikRcL UZ4k0AZVP0r4Op7Jlh39pJZ4IQapE3Z3LOYJRq+z/7fLCSMQaPUyf9ginFmuBvPjSVw= X-Gm-Gg: AZuq6aLgJW+CXIS7PtlrjuMZdWf01AGlKSfT6bHk8f4YwIHWJUjXMdYIJSCA9QtHTsU LOZ+aT+hnlvE0V7H4k2OEctAFLdDIUXUwpXvdaL1FYKmnh59ubeceK3YZnnx4cWZpf/qVIVrzMw znOxE57kgG/H0DI7zpSzchkNoWfhRFyzajj8zEBJDMjAtcxG0nP4tZJpG1hhkBo+VG1jj07+3DG HcBj6tS1KMModtPT7epMPJauVXYcxpq37Ptp6OOhRVe02EPVGLNCdhVMORn/5Tdef2sXSqSOwyW gcvMyWHuqRd/fTchsQ/z9FmW1qaf9BpBjMp8NQLzSBW7GlDUk5+X6CjlvTEsWv3c62SbrGKnA4J ETJoRwZLsa4ph2MeXi3TYP2TuPsb6THmEP1mahXwGxaCeyjzjByNw9uPwi9os5BYRCO/U+ULTO3 gfZTLojDFsj1PBNTGJ X-Received: by 2002:a05:6000:1a87:b0:436:233c:c7c0 with SMTP id ffacd0b85a97d-43629342249mr4824596f8f.26.1770385218723; Fri, 06 Feb 2026 05:40:18 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd3b8sm5896607f8f.11.2026.02.06.05.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:40:18 -0800 (PST) Date: Fri, 6 Feb 2026 16:40:15 +0300 From: Dan Carpenter To: Ariana Lazar Cc: David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel Subject: [bug report] iio: dac: adding support for Microchip MCP47FEB02 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Ariana Lazar, Commit bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02") from Dec 16, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/iio/dac/mcp47feb02.c:732 mcp47feb02_init_scales_avail() warn: passing zero to 'dev_err_probe' drivers/iio/dac/mcp47feb02.c 712 static int mcp47feb02_init_scales_avail(struct mcp47feb02_data *data, int vdd_mV, 713 int vref_mV, int vref1_mV) 714 { 715 struct device *dev = regmap_get_device(data->regmap); 716 int tmp_vref; 717 718 mcp47feb02_init_scale(data, MCP47FEB02_SCALE_VDD, vdd_mV, data->scale); 719 720 if (data->use_vref) 721 tmp_vref = vref_mV; 722 else 723 tmp_vref = MCP47FEB02_INTERNAL_BAND_GAP_mV; 724 725 mcp47feb02_init_scale(data, MCP47FEB02_SCALE_GAIN_X1, tmp_vref, data->scale); 726 mcp47feb02_init_scale(data, MCP47FEB02_SCALE_GAIN_X2, tmp_vref * 2, data->scale); 727 728 if (data->phys_channels >= 4) { 729 mcp47feb02_init_scale(data, MCP47FEB02_SCALE_VDD, vdd_mV, data->scale_1); 730 731 if (data->use_vref1 && vref1_mV <= 0) --> 732 return dev_err_probe(dev, vref1_mV, "Invalid voltage for Vref1\n"); ^^^^^^^^ vref1_mV is not a valid error code. Return -EINVAL. 733 734 if (data->use_vref1) 735 tmp_vref = vref1_mV; 736 else 737 tmp_vref = MCP47FEB02_INTERNAL_BAND_GAP_mV; 738 739 mcp47feb02_init_scale(data, MCP47FEB02_SCALE_GAIN_X1, 740 tmp_vref, data->scale_1); 741 mcp47feb02_init_scale(data, MCP47FEB02_SCALE_GAIN_X2, 742 tmp_vref * 2, data->scale_1); 743 } 744 745 return 0; 746 } regards, dan carpenter