From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E094C3D667F for ; Fri, 6 Feb 2026 13:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385244; cv=none; b=iX9Bfobzt4WeVtw0gs/MHoz7DzzxiNfZqIimkY7rUM7JZf1a328vWZ4QR6a8qQ1X8AfM5C+DwH0sotZG/kVYisSYB3SN7nmLQLOy3lrQ/LWFH/jT7J0wrUJ4koBihABX8FIxG+UC/sG72A+Lk6dx5B/tbIokMDDkZQRZsjU9PpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385244; c=relaxed/simple; bh=apxHwkZcP2HO2OZanljlp1u2QbHEfBt14zrOagr9PhQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=jvjFaqSDgGLwpRg4QaKs9navQq4eXMseSJ9+FVVcJoEkP80G86TvLVnAX1LI93N1Fkb/fc4QBiLvWfqfMjxNWtuMTJNU/GXN7kWIZR2FAmJ6tNniYE/Badkhumw56JcawgdRxBXd53n2gHvx0JDRfAuzzlbFJSVputzG/vzJ890= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QNQdFPLZ; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QNQdFPLZ" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4806e0f6b69so16513915e9.3 for ; Fri, 06 Feb 2026 05:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385242; x=1770990042; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o/0TLoJXsgtAsaIN9YWRMXXg5Y9BBytnoGjFk4CYjlk=; b=QNQdFPLZIIu0S2tGyN8BN3D1PBny7bJtsLW94+LWr/zoynmJ9bfietkEvFdp0mr8ft fN6QB+rC1j5RNqw4sM+3DQbQMWXxxRAJ+xdik+usPFw3LDR82gDJXAihipo3GYvIB4p7 8TS42A3/5bSP5F6/+yVCumNUVQKguc7Y/SL+m9VWTovBreN00NPdjYKWdPCEyGG1kUQH Po3Mj7p9V5XhSaCxa+GHabOj9SDcyRL1d1fQm9OMEPccEndWe/huCX6ILsk6PX1a4Wu4 bdMtUbHSahs2TNXOc1Rh0YvlS1IST12WWgQOTA6qTW56fUezGCYaquNY8Buxop/7oJse vNcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385242; x=1770990042; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o/0TLoJXsgtAsaIN9YWRMXXg5Y9BBytnoGjFk4CYjlk=; b=RQ4L3R1bEGC7NlUWQkCjj0qmbn70VgCAKFsXA9fPvas6pRlNttJtqpaES1guh/ktJj Z9j+yOy8nBuElDKh1l6EUZAuzLd6cKZ/ihDGqM8O9+XsYWb7c+oOPecmBFE2wmJinfKj C1JB8tfFwvsOYZ+mTmBBOH4cgYwT+VPy4tp6UlfEFft0yTKnEDJoR8EMngnBQlbCDmZ8 TTI0OWp7hJUch9ONMb4OH7A+rbsu/1VsyHN5tWRg+thq/KYb9+6av7wrpm/97BI+Vs1v 5NwNYeKPLZxG7ZFQI2HSQd98IAoS1/OzKe8DhoQByygs2JFr1A3M6NCDrDJbaaRGHJJc PPIw== X-Forwarded-Encrypted: i=1; AJvYcCWGHVLdkvCYyhsyPA/ZT/1OjN4+AgckOcWHGyDzp+1ucueAI0YCvj+zonTv9V0eKIYUjuRq503h0VL97WU=@vger.kernel.org X-Gm-Message-State: AOJu0YzJGB1x4mBUwDVMBSoSNIe02cUPyrO0HtIPx2/bdWNKsHKkHvuN 9kFCTqcMWwJFT6BPqEOA9BbHuJWzoDKUncfy7ZH748GxjVNDY9Ek0NVvKEZjhd6tfhA= X-Gm-Gg: AZuq6aJYGQUZRqFNnjvoRbnln3g22eDK/RM7u43DHgaipl7rQIf7Bd3iKXuJzk5tOYN CDxSogYgEMSqHQTsqSTxgkuEFB7Gc/yQ6B4mDNMT1O/sRCZ9bW1D3sBOS2XxatKO7dywKqKPQeS JxiXoK5I6D1IIChc9SA5YfEDXmoSFpRlmXOzpds/CVYrHBjRTZgYRrLEbfC3eBY5ONBR29AlQh4 r+quzQD0IXzIn05jBSjAhLyN5Ql64baGTSq71PoZv8R+GYPLr+UFXfKMZzlU+AhcafkhSuAneL5 cGeRcaDN7iqnLawgO3n57SwZl/7KMsnTsNnOR978LfVTd8z2FzkWfMJubO1kxwJYiC6IdaeboTW 1nV8dsO5ADJ1oCa7S+tXSwV1rcQ+6hfjKb9Y+Jry9DAw6ZOtRTkTvbIH/z9TeQgPpg8l3NbZuRr tQ1Fz/MSUFnfM/930R X-Received: by 2002:a05:600c:4fc1:b0:483:ea6:8767 with SMTP id 5b1f17b1804b1-48320228160mr44676465e9.36.1770385242074; Fri, 06 Feb 2026 05:40:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296b2110sm5812451f8f.3.2026.02.06.05.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:40:41 -0800 (PST) Date: Fri, 6 Feb 2026 16:40:38 +0300 From: Dan Carpenter To: Ojaswin Mujoo Cc: linux-ext4@vger.kernel.org, linux-kernel Subject: [bug report] ext4: refactor zeroout path and handle all cases Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Ojaswin Mujoo, Commit a985e07c2645 ("ext4: refactor zeroout path and handle all cases") from Jan 23, 2026 (linux-next), leads to the following Smatch static checker warning: fs/ext4/extents.c:3369 ext4_split_extent_zeroout() warn: duplicate zero check 'err' (previous on line 3363) fs/ext4/extents.c 3361 3362 err = ext4_ext_get_access(handle, inode, path + depth); 3363 if (err) 3364 return err; 3365 3366 ext4_ext_mark_initialized(ex); 3367 3368 ext4_ext_dirty(handle, inode, path + depth); Presumably "err = ext4_ext_dirty()". --> 3369 if (err) 3370 return err; 3371 3372 return 0; 3373 } regards, dan carpenter