From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 199563ECBE3 for ; Fri, 6 Feb 2026 13:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385252; cv=none; b=AwO1NHCnFh4C/1Rz3DMm7XB8YC0Z1U+g/86Id92K2KOqpUiMDZU9vWAx+c0rIH4qvE5CPq/yfngYu1fDVNEcPaEvtQldu2TTC3xF2vJxv7ajxgyrQctEVysDjje1H8VdzUBSitVCp05odkxtcGHeuRXZfCkE3hPY7OkSSvm/IYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385252; c=relaxed/simple; bh=P44VP+76f3XIOiXxwtqpbZTku04FznTwYaI2CBS8RA0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=iuxMw9x9/AeM1xUCdNw2p77l1C6Wo175yj33KlQckrLt70EaBZGm4+uCXfFbg8bOBlBrWEWAOhlRfKi+5eIZA3b0ksgv31fB+5EUoUwB5PX3JZIapP8mg4PMQ4b6KJA/yFpd+2VC22KZmYLJLHDMA0mWmG7QDwbDQFe/+9Skqvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yoIjJkaZ; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yoIjJkaZ" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-481188b7760so15745965e9.0 for ; Fri, 06 Feb 2026 05:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385251; x=1770990051; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LkO0ZDFXsTERryZDi+Xw4hkZo9DKWHuedNYRkbdXlU0=; b=yoIjJkaZBt04Uf3EUuS5R2oIrZhttXvYmOz6fMsf9EghSnrv9FQ+ucHdsktRGhH1Jp t9UXy7Er3dlS40lmhGE+19RTgS5szlDtpApRnFQ9RGasAtbNijafBDMldhX+sJsNiQL9 mkv7q+0CagHibe9CZu9SGdZvACRcUD7MVkdFNeTGZZVMAOOqeNgCoWP/DQ18fT+djFkr aM5dOPTHcROXww+NyP/PQLcMnf1jThFVqPgY6B1pwFy2TT1+739GybnhIfwzJx/e/jAV tbYgSoKd+b02VXp6Ko3xe7dE+U2gZJqzispPnWrRwGJjJDhf9UtWY3FlwyYi/TzD1FFs pKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385251; x=1770990051; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LkO0ZDFXsTERryZDi+Xw4hkZo9DKWHuedNYRkbdXlU0=; b=FyyS+8kGUXYqx1G8K74zD/i/h3+1VrnCuagZnLB+x3skpv1gM6UWQSGWOrx9cyYcgW Vq2PxMLxiVbKaeQ6ENPVvzR4Ej6u3nU9xccK65EAnuU4CkA8tz1jnN5HUlVtPfqmNUl7 h9qoAqqDVE7UhQQ5Egip/Nv+9FHkcm3ode+sO+NYozmcfFsRa2+5nCOtMRYBQf0Vxzus 6EhvMNu7FYLr8G3eSkqjYG3tiB7+2rxy8m0NXkHD0DH1AsYiUPLlVFvCA4v103Gxxpwh 9r9sG8nw3Jz5kcMHnEA+u7Sh5RtR28lkH9umIf4lImdB9GJZQlZMoeRa5usqFeWoTgn5 fmYQ== X-Forwarded-Encrypted: i=1; AJvYcCVz0ezXUS4rrQMA0d38K8ckGmq/BqEf56L8Qx82Ne+jtcoplPgdghbBAUj/RXPXwY/rQcr5KUxiDpW/9hc=@vger.kernel.org X-Gm-Message-State: AOJu0YzNPqPxsSWQeg0uKLtexfS6rS9k4otyQ9jFzPT05LE3oR9eQ51P tadRDOI6VhhNa/PJDAf0/0eQ+tje1ljycNaGlLqwilSkNAbCZEVtW919tmHLJOQXdsA= X-Gm-Gg: AZuq6aKlk4L0M6tBF3ckJIufHG9FM5BQctmF8Pu2nxARSoPuKowtpiLv1TWeR6uVY/R Wh/XV7cO3us6TrzmdeiuHIc30/Icc203mMyRmeM6olbZSSm9z5qTcVErbKwpMmQRrfX41egsrSH iMq7P3QyGwmm5/CfgpspbwKvjI3Yr3UahL6heJX8k8Pn+MSAl1Pt3k+N9gOTUO062etP5uH+Zv5 Rmzw54NCVxGivefSE2vA042QcJ5Kz5RPatk8M6kFR1bxyTS0i+KBd/9IDYkqRIEKOtPaPUTnrEF wpIUf2+qnZuGj9vEdCEg1eOiAlPgCc9ijwm73PG3LGFL3vdFMFZAmkSkKAi7CIr+O1nOCLI6nVa LQT/5myUKnRXk6i5YXkiy+x/+Fw36QcrlkpvV2xGlpriBJgS8fGf49+JqYgaL52WIAeZrOg3ydA yViZetkX7R+2hQeDWm X-Received: by 2002:a05:600c:8b61:b0:47d:3ffb:16c9 with SMTP id 5b1f17b1804b1-48320966711mr32154065e9.23.1770385250573; Fri, 06 Feb 2026 05:40:50 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483206b8bbbsm81547395e9.3.2026.02.06.05.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:40:50 -0800 (PST) Date: Fri, 6 Feb 2026 16:40:47 +0300 From: Dan Carpenter To: Sven Peter Cc: Neal Gompa , Neil Armstrong , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel Subject: [bug report] phy: apple: Add Apple Type-C PHY Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Sven Peter, Commit 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY") from Dec 14, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/phy/apple/atc.c:2209 atcphy_map_resources() warn: 'resources[i]->addr' isn't an ERR_PTR drivers/phy/apple/atc.c 2191 static int atcphy_map_resources(struct platform_device *pdev, struct apple_atcphy *atcphy) 2192 { 2193 struct { 2194 const char *name; 2195 void __iomem **addr; 2196 struct resource **res; 2197 } resources[] = { 2198 { "core", &atcphy->regs.core, &atcphy->res.core }, 2199 { "lpdptx", &atcphy->regs.lpdptx, NULL }, 2200 { "axi2af", &atcphy->regs.axi2af, &atcphy->res.axi2af }, 2201 { "usb2phy", &atcphy->regs.usb2phy, NULL }, 2202 { "pipehandler", &atcphy->regs.pipehandler, NULL }, 2203 }; 2204 struct resource *res; 2205 2206 for (int i = 0; i < ARRAY_SIZE(resources); i++) { 2207 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, resources[i].name); 2208 *resources[i].addr = devm_ioremap_resource(&pdev->dev, res); --> 2209 if (IS_ERR(resources[i].addr)) This is checking the wrong variable. The * is missing. if (IS_ERR(*resources[i].addr)) { 2210 return dev_err_probe(atcphy->dev, PTR_ERR(resources[i].addr), 2211 "Unable to map %s regs", resources[i].name); 2212 2213 if (resources[i].res) 2214 *resources[i].res = res; 2215 } 2216 2217 return 0; 2218 } regards, dan carpenter