From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4DEA3ED131 for ; Fri, 6 Feb 2026 13:41:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385308; cv=none; b=CWe8fQSf/sF/h4RfIw37m7q4JkJ81iwB1IAmH4t9vBORwdMvCA7x4hfD71iKX+9docUS1V1QhF8GlOxNEKu1Nmzg1VFinUu+fyOybjL4Q7p6PNnbzpwoomtarz9wtLzGGESRLPv7bn8LtOdZ0vptY2YTlQ+TetqiTZIV6Hoo/oQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385308; c=relaxed/simple; bh=0YjDWpFNWweUVWQPi8JoGRXhWWSpLt7OB1/7pQuiWWs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=Ik7YyGFbAXz7YS1yUzWOqH5scT6ayJDxbkKblz0QucSHuKFyTRUZm/VVxls9dgHEbPoQ33ZI4s63E1vRPiPSJna4CfQyIaxfUmJbongoQZ9gLpj+W+a6xBZupIosnC9g/Qa3K5ATt/iWZ7umS07w/MrT+Yo4vA5NMYdVTFm6wF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WlEvOg6L; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WlEvOg6L" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so22617365e9.2 for ; Fri, 06 Feb 2026 05:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385306; x=1770990106; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZtFvs/ZVLVRiCDqzy0YAzdGpW+q73bZZVs4CLpediDU=; b=WlEvOg6LReBT7J4FAFT+Ahy9unADlfKH+Ss4irshCq6vM86iQVhFcR5cdw9oWl1RfE 43w38W8PDTd8XWq3dx0afs6XuX9Am46ozjQFLH9chEIPhuuSEFea9M697SE1eSNkI9GP QjlFuQxyElK1wB4L2CkeU2F4Mcnj7dgf3kD7PCNo+qa962p48aGmphxTE4XQ6YWaacKK sfD9TMsdKi15fA8YSJIvnfv9SikWXXmT///24fCQkqxOad5wZySgRPql6m5RXwsGQWQ7 ezXmzszdB4f/xxYqsUCC0bOhXh9ZIGpJY91kOi7LpUx3Uvc4q/LGWVpW/+cNLh3RLk2e tJqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385306; x=1770990106; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZtFvs/ZVLVRiCDqzy0YAzdGpW+q73bZZVs4CLpediDU=; b=O7tL8iLltbVfBDtkGnWMyRGAtm8on/SBZhRWEgGHYA4jN5nnPxcB0z5V6eIWMMYtO+ bilPT3Ryg3j6mj9/Wk/IyDcwYA4ojgcFaWB6Qhc2rMMoLCX6aT7+c1YsqbgDUZOWVvNT vGx1OsyUlasBAX3exX/d7r/ntthc7gu1BcZ8pxNipZzAvctf93+z7hjpHydXA3nLfnQp vjW6CTp4x4qjmGVu9OXN5dBpyLaxzRLuoNQybcys1sQqp+Cw04FxV30jZx/fip4A2wrd Tefy0oDPdOqd4HOdRA0dj4ookZrOPaR6w//NYj98EVWUiRwgoG6Hgr2fyMYag3F4W9Mk fq3A== X-Forwarded-Encrypted: i=1; AJvYcCWjQBOorVaCjmJglJauBCPmFjcnOmSKC9eI4MMvURKGkdHFPyytz0TbvSkRagzUe4FTjh5FKACio21ip8E=@vger.kernel.org X-Gm-Message-State: AOJu0YwD3Cz2jFx5H59pV0SEqJwwO1SjStjytoQgm8+ucF+7Tkein/B+ vv+fd/6DtIrrvNjW3hktmtlk9zgJWpVhyP9zEfgxWEyOh2S4EIkQPDg+kbnEryhrBZM= X-Gm-Gg: AZuq6aKbgPY57hBzo8gToNUrGLB0Q5V91kY7GYishncIjoXsqsYB04aZLUQtYh8No5K gjCjmRjNqmprESABZDE8x9zK+8mh4HJRxaw35wMiKe47rrx1atIuLyh3BJEPecJMX0m9crn11/O G7b7lNaCqpHLt1ol1461KzSslyWFF1tgsHdMxUdQeB3XPdsyECXujOvWmi3081snQGVsz8w5vFM Q7Il6+fTaRpdEm6i0Wyq7BIEKbny6WozhNhvFXvy4gvSoJvhyYFYGcW+BOk42FN5mMGEKav9VcW dpey7ASCz30KlQ+L0kfTN3bBoEd1D6+NDogUc+WSk6efMMH8f7AlXVfB/5teWZHgpKmRAzSbyV+ /RCs2HL5S0/CarzIUguZAlxpgNFK9d+/PzKWYl5HJqvW3zPvAGFRRmiElt7LZF4WFi1qvk1LhbY v8jdVCRFBQgDo02j81bCvWKzChHbk= X-Received: by 2002:a05:600c:6285:b0:47e:e87b:af8 with SMTP id 5b1f17b1804b1-48320231170mr42647485e9.21.1770385305926; Fri, 06 Feb 2026 05:41:45 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4832097d9a5sm22088785e9.11.2026.02.06.05.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:41:45 -0800 (PST) Date: Fri, 6 Feb 2026 16:41:42 +0300 From: Dan Carpenter To: Tetsuo Handa Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel Subject: [bug report] xfrm: always fail xfrm_dev_{state,policy}_flush_secctx_check() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: [ Smatch checking is paused while we raise funding. #SadFace https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] Hello Tetsuo Handa, Commit 638361ad7ab2 ("xfrm: always fail xfrm_dev_{state,policy}_flush_secctx_check()") from Feb 2, 2026 (linux-next), leads to the following Smatch static checker warning: net/xfrm/xfrm_state.c:898 xfrm_dev_state_flush_secctx_check() warn: was '== (-1)' instead of '=' net/xfrm/xfrm_state.c 888 int i, err = 0; 889 890 for (i = 0; i <= net->xfrm.state_hmask; i++) { 891 struct xfrm_state *x; 892 struct xfrm_dev_offload *xso; 893 894 hlist_for_each_entry(x, net->xfrm.state_bydst+i, bydst) { 895 xso = &x->xso; 896 897 if (xso->dev == dev && --> 898 (err = -EPERM) != 0) { ^ = vs == bug. 899 pr_info("%s: LSM policy is rejecting this operation.\n", __func__); 900 dump_stack(); 901 xfrm_audit_state_delete(x, 0, task_valid); 902 return err; 903 } 904 } 905 } 906 907 return err; 908 } regards, dan carpenter