From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A9E36C5AA for ; Fri, 6 Feb 2026 13:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385685; cv=none; b=dyJzpCQgI3gHSPQMM8/wmuyaJ8rLv9ZqlTzAiUgx0NdIHheVb26O2clUw0gE4V6HxKnfndVdlWkPBlZ6D7uq5Q2rhcCxSn7TZZy4bkrK0DRRzUA7vICfu+uENbdU3U3Ompj2HFxCkxhN1hZsu72rdLdFBgY9/IvBT6Lwt6ZPs2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770385685; c=relaxed/simple; bh=7yY/8jnS0hsT8F+rqJ3RTB/ADe9ZLxkoVIu/vTfrouI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q/ZUzlcG4/KT9iOJfzwHOjP70ZQKsMOqnHcTXZLdGUGs6ZE8R51pFq21S+Ibbq8j4I9aBVQ9PVhebQFnY8GfLj2Mb+FVs4oG3PzqB1qp2M6prZsuyhklpS6k9fOmqnGbjCgFfhRb1WHmOo6SaSQ9aB+ewhoqrVhtPMV6CCH24CU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xXzUNoxg; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xXzUNoxg" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so32402525e9.0 for ; Fri, 06 Feb 2026 05:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770385684; x=1770990484; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cSbD0Nw8/bt38xPR3nRGhyQFOgHwlTx7dTgkCl+akPc=; b=xXzUNoxgEqjdsUJ0Lko2i5peYCg1Megt0di8ynh2pIzJszb+tR1RG/8ASTNUxAgPj5 9xYH2YOr6yYGLzdzPYju/ET5oNsMHHhHNZI49qfJch5IZ8CstRPZEBqksmDbaMXeLfXv Au05P/nZPTwKtCwRqROpx1DtNLis8+1BfDipdmP6eKcMYl+pAEh9hV8EMHY0jV9ahNOT ANQMgV6dbWZU6Wsxxl2V0q5KhDMVUmxHo238LP9kRdjgasStzGLcWgj01nkLCcbZ4hMo zYZvFWuHAf538Iap9P3glVuPcKFN/LDmlF5bhSHMoXR/59XWGw4g1MZGq7nGPj88Hv5a hzeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770385684; x=1770990484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cSbD0Nw8/bt38xPR3nRGhyQFOgHwlTx7dTgkCl+akPc=; b=KNgSmmIxCRZ9a2fPbdVsfvTIfw6SsQ7nOAakQpv/PdCMcHZjgvuFC8DM4y8d6kCqy8 F9GI2lZ2aJd/f1cayaY5rNmvUYZ5d5JR+h9m8jljk77bHP4o9yynWWQZfH1unpf4gyqk KL/ZK4sOmoys0VW4SHw9LnGc3T3EXMPjRPd30fiEbdmC15JNaJTQKVvOxoTgcmeeyDJ9 /+3QFF8Gq3NXehQxkWguLjHFPjI5TqwCXYAW/47QGiFtFnw9AhqIChxRBYem3YdLQZ6C rGeHzQ1xb+i0OMP7WLRVBT3wq6aUgL4dujDMuDy2e2vzttrllpaH7ADC0cAje3ku5el+ /46w== X-Forwarded-Encrypted: i=1; AJvYcCXlSwV8VMgVuHMuAOhMLz6wStuBEr0Ln3MwshAAPJmSahEU99BB9PXbJ4Y+7RAtuJMHkr7sjBB41QVg4W8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/wO+G774cTWs4YBmbZI+JikpeCwIHe9UaepUp1DsWKmtaCQoA OjSUrdmgttOf/AJ+OfCelhNA5Waxjef4hWcKcgyVOPySCD5XsSxTdGtOfV9/hF9+BQg= X-Gm-Gg: AZuq6aLSmNpmjO2Mtk2doWxuHvIFsu8fkuALAijY/g/32e1At6Io0aRrImkSaZ6ldsO 9TL19Ji2+qqEde7uf/vVbwsMcMdiG59yEGuGoEvtMYdNeTDTJ6FZG2GcjStHBfWNnrsJrzRE+8Y p2hQtdmS0IAZ7FLxEPrO/TG/KtXCbdq3Nxi6y27JtwIG3/eJivKs51XilnKDKcsAxTzjPQwa1hl T0sQE9T/csVBTHUioo7ntTez1UeVDDgjjTGm8COgD8JIJcWqYFJol0DSPzvLAtL/H3oSNsu1eSI 2EQwfB/55A203IwHHDuArKkF6gSYb5YJC7z+HwF2QU87PXzWD/v1b6lCZhjY2P3elsPE982c6of H5V2viAVBm09vWmzuTRKWgDD0xWCkqjRUmEfwGHZQXCnkw8FcdJJ7b+5V1/HrlrUszhw/GIQAVH p167roKE6DOasUGsl6 X-Received: by 2002:a05:600c:5253:b0:482:f564:d60f with SMTP id 5b1f17b1804b1-4832020e2b2mr37986635e9.15.1770385683622; Fri, 06 Feb 2026 05:48:03 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483209d0007sm18673515e9.15.2026.02.06.05.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 05:48:03 -0800 (PST) Date: Fri, 6 Feb 2026 16:48:00 +0300 From: Dan Carpenter To: Gustavo Piaz da Silva Cc: gregkh@linuxfoundation.org, ovidiu.panait.oss@gmail.com, gshahrouzi@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/2] staging: axis-fifo: refactor device tree parsing Message-ID: References: <20260206131148.13643-1-gustavopiazdasilva2102@gmail.com> <20260206131148.13643-3-gustavopiazdasilva2102@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260206131148.13643-3-gustavopiazdasilva2102@gmail.com> On Fri, Feb 06, 2026 at 10:11:48AM -0300, Gustavo Piaz da Silva wrote: > - ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", > - &value); > + ret = of_property_read_u32(node, "xlnx,axi-str-rxd-tdata-width", &value); You moved &value to the previous line which is the right thing. But, please, don't make these unrelated white space changes in the same patch. You can do it in a separate patch but they make the diff harder to review. regards, dan carpenter