From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46773146A66 for ; Fri, 6 Feb 2026 16:01:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770393684; cv=none; b=Gy7VZZUglsi1BtRsb/iQ2KW+CVI4KjYaS/gfFLOnWvhex6DKCkpux6V1RY7y3Xuned5sqsts4gLJyMpWvYFE45TZ8dpyOAnSaDubhMtZ7TmAESI2LRV+VDjTxkS9oibt9Rgo4J6tvy+N6u5+i0dedAd/ylwo0KmaiV2URc1j5aU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770393684; c=relaxed/simple; bh=IV7QAjuyUw85XIDcqG151gFu0X7JrvrKBJ7KMcj6Wyc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E76ahfMJMRAQeP+iIusmugaX6BgnjaitjqoG46/jli1lH572q7b/aWshlSVaw2LuCeU9IyKFj/N5V7vMSI/adnR14QzInbDahzfTDfU4GbGjHj4jt/ODoKPOK4iAGZ1dkRWxvRUG8JJXaWJXfJ1p6foMcOiTVAzEFGM065SwIcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sEvYpIjU; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sEvYpIjU" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a07f8dd9cdso16340035ad.1 for ; Fri, 06 Feb 2026 08:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770393684; x=1770998484; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XMf0JguzxHjMSjmKuASfsYMf0I7uSocPhP7aGXcZdPo=; b=sEvYpIjUTPZRhj5Hd+4D5pZFVYY70SIUf9QNSq571FxPhA6BWrGAm4SGMnCym2+AEL R0sa2B+9jvWG2P4YJOUQJJbM9dOXAKQcJyS7oL2RLp2w7BYB5RpXMnTfX+Jg0nB4oXtA SD584KYtfmpJiDYm2BO5GsDbJ9O6edHU7GAfK1wrFPteGfoUlkeli6yfwqleGNYj7Lld 9eB+HsV2PTlSX3qk3uE+oO74pXsAbxo5s/McmbA1CtLxASUCJ8bcad/+LIpI9KqxUOHw 0meRw0YUiIiu1g/uDTeBcIZ2GsOHJh/bRLztUpvsbezzp3jOuxDzAxNC4DbY6Y1idwDv FZWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770393684; x=1770998484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMf0JguzxHjMSjmKuASfsYMf0I7uSocPhP7aGXcZdPo=; b=pIiMNlPq+W/emTeQ/XsHl326NFlfmUvpvN1JzWl8izlHgjG2WBIjlhpe4lxYaJnIlc ZlIitKLVPnana7SMz5rtwkpmovW/5zlibXxxHYO0CfjrLJBHN3JADAwofKflgut1iedr 9Guh04TR6RDHibO9+1Ftv6xYorZ5AhStyOOJGPRfzqp4REqJ/NmzWsZUSD+xhukOAJtZ CZ3hwLFPlFr38nP7KQ6VTMTZSerjaLbDxMgrhupiJONS7Wo6rFsWqbpsDpe7XDf156Vw ZrQ+lCkK2dLyHrpqNbvAkIKrwcmxKyIsGz5EwqJP7enxNLhPYfJJpa79MW8zKVMCsNcY DOIw== X-Forwarded-Encrypted: i=1; AJvYcCXPNTMfJzykNx6hy05o8zsuXxEvuzhQ6Uj8LSTmwKx16OdfaPT9fY48S8XN+YZHpZ9vRcVL3Vo8G/CGuAY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3xSZnj0iy74M7l+7wD2tnrz0t0Qk/En0f2FYkQ+/oPC/T4PUT 8qC8ruVFmG1v3hGnApfzL1LXv6nUXTmJVClHv+nHPSDetv2WvoOqnBy5Q7GlbNj4a4Y= X-Gm-Gg: AZuq6aLQjpZff64dvEdHv9Xg0WHv4pMB/iit23tVWHAqo0ldS9cA6oIt+yaSGwA2Hlk lZzr1ZQite65f1QbW++N0fvOGGqZ286nIaHGfTdImWpo+VkrafhURoej0RgSI/woqCZnC89u+Ji cVtkbTFIzIZXjDT9dwZY+t4G36h8Ai9sgaNH9JCl9vjr3TS0JB0OL7hjKubZOur9Cpsd+Qbb63E x3/F9Xm8XkfPJVfU0jzVRxvq2lJLxKt/FWPyNYuIGVIC+HTrQA05BRhtXZHFmB1mUxcwF5disct OVY9KO2yKa4UDu70++X7d+d6fs8Z9umj/PQtaK4Jz6nGzmVFtZblBKRNTQw0S5/CLfwtlUsUutR p8lNq4927tK2+GrXsX4kVZyt3t7AN4OYqNpeUGuIiwhhVjvhRYBjAfwkFd4E0RvpyCjEBPWn/yc iywnzIj8DQnAu9 X-Received: by 2002:a17:903:19c8:b0:2a0:f47c:cfc with SMTP id d9443c01a7336-2a9516d530fmr30153565ad.34.1770393682517; Fri, 06 Feb 2026 08:01:22 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:fa3:e3b4:3597:587a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a951a638b5sm36621555ad.11.2026.02.06.08.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 08:01:22 -0800 (PST) Date: Fri, 6 Feb 2026 09:01:19 -0700 From: Mathieu Poirier To: Tanmay Shah Cc: andersson@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Tim Michals Subject: Re: [PATCH] remoteproc: xlnx: fix sram property parsing Message-ID: References: <20260204202730.3729984-1-tanmay.shah@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260204202730.3729984-1-tanmay.shah@amd.com> On Wed, Feb 04, 2026 at 12:27:30PM -0800, Tanmay Shah wrote: > From: Tim Michals > > As per sram bindings, "sram" property can be list of phandles. > When more than one sram phandles are listed, driver can't parse second > phandle's address correctly. Because, phandle index is passed to the API > instead of offset of address from reg property which is always 0 as per > sram.yaml bindings. Fix it by passing 0 to the API instead of sram > phandle index. > > Fixes: 77fcdf51b8ca ("remoteproc: xlnx: Add sram support") > > Signed-off-by: Tim Michals > Signed-off-by: Tanmay Shah > --- > drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c > index bd619a6c42aa..970a9ef97945 100644 > --- a/drivers/remoteproc/xlnx_r5_remoteproc.c > +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > @@ -1005,7 +1005,7 @@ static int zynqmp_r5_get_sram_banks(struct zynqmp_r5_core *r5_core) > } > > /* Get SRAM device address */ > - ret = of_property_read_reg(sram_np, i, &abs_addr, &size); > + ret = of_property_read_reg(sram_np, 0, &abs_addr, &size); I'll pick this up in two weeks when 6.20-rc1 comes out. On a separate note, it would help if an example that includes an "sram" was part of the xlnx_r5 bindings. Thanks, Mathieu > if (ret) { > dev_err(dev, "failed to get reg property\n"); > goto fail_sram_get; > > base-commit: 85ab651885e1b542ee0bb9ec4642ef0b11716997 > -- > 2.34.1 > >