From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BEFF2FB997 for ; Fri, 6 Feb 2026 22:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770416833; cv=none; b=da/56AYfqXUMUYIVYK+Vi9SpWqrU3dx88xOjaypy+dTOQwNjzn7sxKxtNZO7ebhTY0ma1Uv1kSGLUIDfwvW/casQ+6hFpuBIVYajuX84HNyhFaWZIKJav9ajKpYJOSAD0LfI0tm4sfhtx6P5ALGc21r7J4+yTDfLOb029VLIvSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770416833; c=relaxed/simple; bh=E+R9VnH/5nYvRH0t2JT7uiax3xd2qSeKJYS9J3oV0PI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dlfc/LQZhiCuCdtVpxe5ohYZHszAbc3qlqlCnxqCyaJR1P5De8UcY3YcCp2X/d8TEisehZq1pRSIBM6l7wEpU8uTYHDFwLoEzKXtRPTFkQJ93CWor6fgcLGGd/0Q+EZudMB4CmYiAg8cfL9r3YW+gxLZGvWWV3rjdqT0PezXeE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=2mkDFL/d; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="2mkDFL/d" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8230f8f27cfso1193850b3a.0 for ; Fri, 06 Feb 2026 14:27:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1770416833; x=1771021633; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ePyEeKrzpfMJEGi5Q/BT3mifKnjoB4/x3Gb6lbNEHiM=; b=2mkDFL/d3s4wSvpZ3ElbsW6bBKS1xbrFmS8Nr5uxPZAsJkYdbRoN5Vzo7VT+aD5YgV rPcVWdHG9sMBgx1eEsBi4mpHG6pd3vgYWMQ+ifQj8dymEY9KEAaT4kDGZpqZJRbxoeLD sOR+POfQJghGHC3ewpFKuIw9nI89ahMwMR0nw1TSB067tzUIEaSYMwPO3A9QmpndKWB8 VoR/dHVE1x6suSWVC2Ie+pRPyQzmLN0vzzVo7li/1JVMQATpF7YYYeX++wVkqe5go9z2 aXOt/aDGE2lgYYwaAsA0mxb+CYKSD2DaWU+ITX71HMbCPjs6SYrYvdm/MS70IFxph8Al zOgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770416833; x=1771021633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ePyEeKrzpfMJEGi5Q/BT3mifKnjoB4/x3Gb6lbNEHiM=; b=cmSrCyb6arrnhxoxi+1+nCgVNXOBaxq9LrvHqWxg5pzx2EtUEplQlRsUk9S+O/+ssH +ua2030gaxcn6HUEj4SbCEZhktwvjZBZvK57YUjQt7LrfQv4fTgcK3huqP0RZyVM7V2B qLeJuPVc/RqdewvcSMjnyd1x87BJmxw0TIwTCS55wpw6JFRurLc/LRdoxq5QxW81TFOy IHke/7NUPJbBXXcPq06324wDMZHYodD7y12hH/6kfjvuwDuzKZ9FOgL7NoHmWLkNbUyj wBSq2xn8amsdeQT582xJxqIOfiExncVnfWxDRJRfmXJMNM+UvCmgym2bzXRygb3akfY9 bOtA== X-Forwarded-Encrypted: i=1; AJvYcCUXYNLEEl01CjwnZk0uPCtNTJc0IAPtjXhtwoGk8KSieX3Vqfl5kxtQ+3xbfo+D0L7j5dqPCF30U5TwmJg=@vger.kernel.org X-Gm-Message-State: AOJu0YxkgtLXJ7MsVEveGMPkr7ld4P+75jb7bHRJwA8tRxGLWSYyRDwD rDR6BltjReeMKHYHw4ijLDwhntK8nsSJqs6f67pbz9xkplmM77CIiUpkf5g8HNb2X9w= X-Gm-Gg: AZuq6aKiKwjaoheaqKsc/lqjm/2+NTrFPhO0dNojbEy4gC/A0c5ZEDSrxWKJ96ss/Qx GUzjIbYif/xJt2kAzIos3eV/4Q0oVNZBVcK7yvqel9LrQlvM88K9GxirW2l2JhUSOmHdRC2z2NZ teddx0KH83X0mJHMq2QJidmNPt0mU3OZ1+EyGlhgIpjgaW5Nck/ngc/EVRgsXP3uNKVNQat1xEh 0wd9xVnQgSZGJB9iEK1CQFyFWMzTevb9Oy3HWBGcTLnywZ/lo81fnjkoruAregnybI3/qMdoWiW QE4Z8Xqf2AsKX2xVIGf8TDQGJMt5YQ7EOXW4oqP3GhNKbZmJZwvjcMNl4qKyBZYEKTnWD2RhRut 2cEvEpj0Qsn4COFYoDHmJY+5EsErK8axN9T+qLFRcTc4WAtX8NiIK8zsZ3c9Sshwjd85JPypCvW CXQIXbdH/pn5iW8BmH0zGjmWprpVlIiYgKtAsHRbFqxHXos+2XnRNKUsM3JEbcKyz4BS6GQsSnR w== X-Received: by 2002:a05:6a00:1790:b0:81f:49cc:ea11 with SMTP id d2e1a72fcca58-824417b8d66mr3640903b3a.65.1770416832498; Fri, 06 Feb 2026 14:27:12 -0800 (PST) Received: from dread.disaster.area (pa49-180-164-75.pa.nsw.optusnet.com.au. [49.180.164.75]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418de80dsm2939362b3a.62.2026.02.06.14.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 14:27:12 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.99.1) (envelope-from ) id 1voUI7-0000000Dt3m-3vc1; Sat, 07 Feb 2026 09:27:07 +1100 Date: Sat, 7 Feb 2026 09:27:07 +1100 From: Dave Chinner To: Wilfred Mallawa Cc: Carlos Maiolino , "Darrick J . Wong" , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Wilfred Mallawa Subject: Re: [PATCH] xfs: add static size checks for structures in xfs_fs.h Message-ID: References: <20260206030557.1201204-2-wilfred.opensource@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260206030557.1201204-2-wilfred.opensource@gmail.com> On Fri, Feb 06, 2026 at 01:05:58PM +1000, Wilfred Mallawa wrote: > From: Wilfred Mallawa > > This patch adds static size checks for the structures in > libxfs/xfs_fs.h. The structures with architecture dependent size for > fields are ommited from this patch (such as xfs_bstat which depends on > __kernel_long_t). There's more than that. Different architectures will have different padding, alignment and holes for the same structure (e.g. 32 bit vs 64 bit) resulting in different sizes for the same structure across different platforms. This is not actually a bug in the UAPI - as long as the architecture's userspace and the kernel are using the same structure layout, variations in structure size and layout between architectures don't matter. IOWs, if these structures checks are sized to pass on x86_64, I'd expect this change to result in build failures on various 32 bit platforms.... -Dave. -- Dave Chinner david@fromorbit.com