From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD12C22A7E4 for ; Sat, 7 Feb 2026 18:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770490263; cv=none; b=YF0MR20+BnCPAtswgQtp0JhX3OLeQHu1Hbdj54voRKr573f7fYGaXbBco+RarFDhpreqCo18yAwO4bImQhcg82OuSpNrSkNAScuMKm6bTYAoWZ2evUi//tyKZtRfy3yqU4VhGRWHQwuvc6GOoMPSWINXQVK0MwYD8Hg8isy+0Cw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770490263; c=relaxed/simple; bh=5J7FTRGXMyQ2sPrzDXh8i83Dp04hEePamOtzTgL75Jc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MCDJXTTG0R0DiTwsl3S/GEdeqlkBj86kxYBWp1HO0NM8kggLIAZzgx4Le7eYZIU/rnuC+ouxerozl1Be9xL8rbgimw/PFrj0YCf7U5RFe9T5gCjUxLXLF0lc4jnPgBo3At1AyOLxC+XyAjBf24sBtl7GviilE9aTOoDYatACsJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=a2hNNJQ0; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="a2hNNJQ0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1770490260; bh=IF1fswD43aokSMMO1w2eWaGjVWT/Rz98ncR2qyE3rg8=; h=From:Message-ID:From; b=a2hNNJQ0+KB+TQaj5pvT4D+oKKBwtB3BxHlBMb1HTiMGN374tt974LSst5Mz7/mYb CU7CI/VW8+abSVOy9ADJ1onl3jTYfuY/jnRbZgXoI/ekJqVeehhDp6GztASEOS6K1A OEYgThrJJ+uNaAYurNsjhxoPdl1Uo/2pIgFj3XA4= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id E56DBC09DA; Sat, 07 Feb 2026 19:51:00 +0100 (CET) Date: Sat, 7 Feb 2026 19:51:00 +0100 From: Willy Tarreau To: david.laight.linux@gmail.com Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v2 next 01/11] tools/nolibc/printf: Change variable used for format chars from 'c' to 'ch' Message-ID: References: <20260206191121.3602-1-david.laight.linux@gmail.com> <20260206191121.3602-2-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260206191121.3602-2-david.laight.linux@gmail.com> Hi David, On Fri, Feb 06, 2026 at 07:11:11PM +0000, david.laight.linux@gmail.com wrote: > From: David Laight > > This makes the code slightly easier to read because the variable > stands out from the single character literals (especially 'c'). While I thought it was purely cosmetic and useless, I have to admit that it eases reading of certain large "if" conditions. > The following patches pretty much rewrite the function so the > churn is limited. > > Signed-off-by: David Laight Acked-by: Willy Tarreau Willy