Re: [PATCH] tof: Add VL53L4CX TOF drivers

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Sat, Feb 07, 2026 at 01:49:50PM +0000, Jonathan Cameron wrote:
> On Sat,  7 Feb 2026 17:42:35 +0800
> 434779359@qq.com wrote:

> > This patch adds support for the vl53l4cx tof ic
> > ICs used in Qualcomm reference designs
> > 
> > Signed-off-by: liufulin <frank.liu@faiot.com>
> Hi Frank and welcome to IIO.
> 
> This is a massive commit.  Normally roughly speaking each commit should
> be an absolute maximum of 500-1000 lines of code because this what
> people can realistically review in one go.
> 
> I'll take a superficial look at what you have here but to make any
> progress towards upstream it will need stripping back to a much more
> minimalist base.  From that we we can then look at adding more features
> in future patch sets.
> 
> Note the largest drivers for what I'd expect to be a lot more complex
> than a time of flight sensor are not as large as this in terms of
> lines of code.

Yeah, this is even barely satisfies requirement to put into staging/iio.
It has so-o-o many style issues and other small things (I just pressed PgDn
several times within 5 seconds). You need to take your time and invest into:
- creating an upstream plan (roadmap)
- as Jonathan said, start with a minimalistic setup (not more than a couple of
  thousands of LoCs
- be sure the style follows the Coding Style and IIO subsystem specifics
- be sure the code uses modern APIs from kernel and not some outdated stuff

...

> For the full series, stay under 2000 lines or in practice it won't get
> reviewed.

Fun fact, I answered above without looking at the rest of the message.


-- 
With Best Regards,
Andy Shevchenko