From: "Bera Yüzlü" <b9788213@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] staging: rtl8723bs: refactor halbtc8723b1ant_CoexTableWithType() to remove duplication
Date: Sun, 8 Feb 2026 16:15:55 +0300 [thread overview]
Message-ID: <aYiMi-X5r4aUEC32@BERA.localdomain> (raw)
Replace the verbose switch-case block with a constant 2D array lookup.
This makes the function much more concise and easier to read without
changing the underlying behavior.
Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
---
.../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 55 +++++--------------
1 file changed, 13 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
index b3d7f50fac4c..d3c7a4b32ff5 100644
--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
@@ -684,52 +684,23 @@ static void halbtc8723b1ant_CoexTableWithType(
struct btc_coexist *pBtCoexist, bool bForceExec, u8 type
)
{
+ static const u32 table[8][2] = {
+ {0x55555555, 0x55555555},
+ {0x55555555, 0x5a5a5a5a},
+ {0x5a5a5a5a, 0x5a5a5a5a},
+ {0xaaaa5555, 0xaaaa5a5a},
+ {0x55555555, 0xaaaa5a5a},
+ {0x5a5a5a5a, 0xaaaa5a5a},
+ {0x55555555, 0xaaaaaaaa},
+ {0xaaaaaaaa, 0xaaaaaaaa}
+ };
+
pCoexSta->nCoexTableType = type;
- switch (type) {
- case 0:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0x55555555, 0x55555555, 0xffffff, 0x3
- );
- break;
- case 1:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0x55555555, 0x5a5a5a5a, 0xffffff, 0x3
- );
- break;
- case 2:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0x5a5a5a5a, 0x5a5a5a5a, 0xffffff, 0x3
- );
- break;
- case 3:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0xaaaa5555, 0xaaaa5a5a, 0xffffff, 0x3
- );
- break;
- case 4:
+ if (-1 < type && type < 8)
halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0x55555555, 0xaaaa5a5a, 0xffffff, 0x3
+ pBtCoexist, bForceExec, table[type][0], table[type][1], 0xffffff, 0x3
);
- break;
- case 5:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0x5a5a5a5a, 0xaaaa5a5a, 0xffffff, 0x3
- );
- break;
- case 6:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0x55555555, 0xaaaaaaaa, 0xffffff, 0x3
- );
- break;
- case 7:
- halbtc8723b1ant_CoexTable(
- pBtCoexist, bForceExec, 0xaaaaaaaa, 0xaaaaaaaa, 0xffffff, 0x3
- );
- break;
- default:
- break;
- }
}
static void halbtc8723b1ant_SetFwIgnoreWlanAct(
--
2.43.0
next reply other threads:[~2026-02-08 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 13:15 Bera Yüzlü [this message]
2026-02-08 18:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYiMi-X5r4aUEC32@BERA.localdomain \
--to=b9788213@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®