From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomas Melin <tomas.melin@vaisala.com>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Nuno Sa <nuno.sa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/5] iio: adc: ad9467: check for backend capabilities
Date: Mon, 9 Feb 2026 12:35:12 +0200 [thread overview]
Message-ID: <aYm4YLcKzDnGGS9V@smile.fi.intel.com> (raw)
In-Reply-To: <c3f7ce0e-4661-4542-9ea0-168d28a483c8@vaisala.com>
On Mon, Feb 09, 2026 at 12:01:07PM +0200, Tomas Melin wrote:
> On 09/02/2026 10:41, Andy Shevchenko wrote:
> > On Mon, Feb 09, 2026 at 09:24:09AM +0200, Tomas Melin wrote:
> >> On 05/02/2026 18:34, Andy Shevchenko wrote:
> >>> On Thu, Feb 05, 2026 at 12:24:11PM +0000, Tomas Melin wrote:
...
> >>>> + ret = devm_iio_backend_request_buffer(&spi->dev, st->back,
> >>>> + indio_dev);
> >>>
> >>> With
> >>>
> >>> struct device *dev = &spi->dev;
> >>>
> >>> at the top, this one becomes exactly a 80 character line.
> >>> And in general it will help cleaning up the rest afterwards.
> >>
> >> Given it seems it would still be 81 characters long I would like to
> >> leave this change as it also creates a bit of noise.
> >
> > ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);
> >
> > We have different arithmetics for sure, I have it 80.
>
> Indeed this seems to be the case, different editors count this
> differently :D
It depends if your cursor is under the last character or after, and depending
on the meaning of the value: position of the cursor versus the line length
it may be off-by-one.
In VIM in the default mode it shows the position under the cursor and with
starting column number equal to 1 the line length is calculated as
position of the cursor - 1 + 1
I believe I have in the bar the length of the line in bytes and columns
(these numbers are different due to tabs versus spaces)
> > "There are *two* problems in programming: naming, cache invalidation,
> > and off-by-one error."
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-09 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 12:24 [PATCH v6 0/5] iio: adc: ad9467: Support alternative backends Tomas Melin
2026-02-05 12:24 ` [PATCH v6 1/5] iio: industrialio-backend: support backend capabilities Tomas Melin
2026-02-05 12:24 ` [PATCH v6 2/5] iio: adc: adi-axi-adc: define supported iio-backend capabilities Tomas Melin
2026-02-05 12:24 ` [PATCH v6 3/5] iio: dac: adi-axi-dac: " Tomas Melin
2026-02-05 12:24 ` [PATCH v6 4/5] iio: adc: sd_adc_modulator: " Tomas Melin
2026-02-05 12:24 ` [PATCH v6 5/5] iio: adc: ad9467: check for backend capabilities Tomas Melin
2026-02-05 16:34 ` Andy Shevchenko
2026-02-09 7:24 ` Tomas Melin
2026-02-09 8:41 ` Andy Shevchenko
2026-02-09 10:01 ` Tomas Melin
2026-02-09 10:35 ` Andy Shevchenko [this message]
2026-02-07 18:43 ` David Lechner
2026-02-08 19:30 ` Jonathan Cameron
2026-02-09 7:17 ` Tomas Melin
2026-02-09 14:19 ` Nuno Sá
2026-02-09 14:37 ` Chris Mason
2026-02-07 18:43 ` [PATCH v6 0/5] iio: adc: ad9467: Support alternative backends David Lechner
2026-02-08 9:05 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYm4YLcKzDnGGS9V@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome