From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
jic23@kernel.org, michael.hennerich@analog.com,
nuno.sa@analog.com, eblanc@baylibre.com, dlechner@baylibre.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, corbet@lwn.net
Subject: Re: [PATCH v8 7/8] iio: adc: ad4030: Add support for ADAQ4216 and ADAQ4224
Date: Mon, 9 Feb 2026 11:47:19 -0300 [thread overview]
Message-ID: <aYnzd55yYK5xRSpr@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <aYiXKq5SJ3wNl8DA@smile.fi.intel.com>
On 02/08, Andy Shevchenko wrote:
> On Fri, Feb 06, 2026 at 04:02:19PM -0300, Marcelo Schmitt wrote:
> > ADAQ4216 and ADAQ4224 are similar to AD4030, but feature a PGA circuitry
> > that scales the analog input signal prior to it reaching the ADC. The PGA
> > is controlled through a pair of pins (A0 and A1) whose state define the
> > gain that is applied to the input signal.
> >
> > Add support for ADAQ4216 and ADAQ4224. Provide a list of PGA options
> > through the IIO device channel scale available interface and enable control
> > of the PGA through the channel scale interface.
>
> ...
>
> > +/*
> > + * Gains computed as fractions of 1000 so they can be expressed by integers.
> > + */
> > +static const int adaq4216_hw_gains_vpv[] = {
> > + 1 * MILLI / 3, /* 333 */
> > + 5 * MILLI / 9, /* 555 */
> > + 20 * MILLI / 9, /* 2222 */
> > + 20 * MILLI / 3, /* 6666 */
>
> In case you would need a new version, or Jonathan is okay to tweak, I think
> it's better to use float in the comments. The above comment explains the
> MILL multiplier for the values.
>
> 1 * MILLI / 3, /* 0.333 */
> 5 * MILLI / 9, /* 0.555 */
> 20 * MILLI / 9, /* 0.2222 */
> 20 * MILLI / 3, /* 0.6666 */
>
> > +};
>
> Btw, if this true (if I am not mistaken in the gain values), the question is
> why 0.2222 is much higher than 0.555.
I guess it has to do with how the PGA is set up, but I don't really know.
Those fractions are specified in the data sheet [1] and test results have shown
those are correct. I can't explain why we have those specific gain values, though.
[1]: https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4216.pdf#unique_2_Connect_42_T1
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2026-02-09 14:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 18:59 [PATCH v8 0/8] Add SPI offload support to AD4030 Marcelo Schmitt
2026-02-06 19:00 ` [PATCH v8 1/8] dt-bindings: iio: adc: adi,ad4030: Reference spi-peripheral-props Marcelo Schmitt
2026-02-06 19:00 ` [PATCH v8 2/8] Docs: iio: ad4030: Add double PWM SPI offload doc Marcelo Schmitt
2026-02-06 19:00 ` [PATCH v8 3/8] dt-bindings: iio: adc: adi,ad4030: Add PWM Marcelo Schmitt
2026-02-06 19:01 ` [PATCH v8 4/8] iio: adc: ad4030: Use BIT macro to improve code readability Marcelo Schmitt
2026-02-06 19:01 ` [PATCH v8 5/8] iio: adc: ad4030: Add SPI offload support Marcelo Schmitt
2026-02-08 13:56 ` Andy Shevchenko
2026-02-09 14:36 ` Marcelo Schmitt
2026-02-06 19:01 ` [PATCH v8 6/8] dt-bindings: iio: adc: adi,ad4030: Add ADAQ4216 and ADAQ4224 Marcelo Schmitt
2026-02-06 19:02 ` [PATCH v8 7/8] iio: adc: ad4030: Add support for " Marcelo Schmitt
2026-02-08 14:01 ` Andy Shevchenko
2026-02-09 14:47 ` Marcelo Schmitt [this message]
2026-02-06 19:02 ` [PATCH v8 8/8] iio: adc: ad4030: Support common-mode channels with SPI offloading Marcelo Schmitt
2026-02-07 18:35 ` David Lechner
2026-02-08 14:02 ` Andy Shevchenko
2026-02-09 15:08 ` Marcelo Schmitt
2026-02-14 16:21 ` [PATCH v8 0/8] Add SPI offload support to AD4030 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYnzd55yYK5xRSpr@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eblanc@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®