From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22E3B2DEA6B for ; Mon, 9 Feb 2026 18:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770661257; cv=none; b=ENagE0O2tQsNbuyDZjl/P1udO2m7siw6yRRmYJJBevLdalOtmSLlHmTm9XBzXBqHUEXoHC00a5MS1YlSOLIDbp1Ne4Uevp673aX8Eq7qhaS0KDbvRmcJxMl7awWSDAiGqlBanA+FL4ddIJYzDipFIJx+Yr5qZdplz/jb4f3wegw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770661257; c=relaxed/simple; bh=7dN/acDxRQuhaH/mCUZ0BOpdERh0fJXK8ZDUnBKwDD8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cyi+6XigYCQrpenkuvm8W6ktU2dk528lqh8X9A6A98mCt6PlYH9AYXJiuoU/wZ2877P+VuGCp11rs5N7lBRTlpJLKneTQnj0Vh6JjCzB0XIrmMtPc9ufr1vdsMIbhqRFwiTeBGvEuetc9uVYWefbozWgP3b07Y/b8OoqZI7GsZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=igYgjF/V; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="igYgjF/V" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2b81ebac5d6so2475eec.1 for ; Mon, 09 Feb 2026 10:20:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770661256; x=1771266056; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zSV3vsUg8E13DVBRTy1EKOAg5TL6exZt8xqnFEN40xk=; b=igYgjF/VgJy9yAqsvDSX5ywe6w2XT2oJ9hrZMGhkkfDa6FnqXlQoIkX8uDqgv7k8Xj O147tEC4utu6eHENKXDi8jYI//EINQ+13iA9vUPXZ28ZgUX3Tf/BEaVE0VsZ15aXwL5/ yfnOAtc7jUVp6gxqRRjfsQFfMXB4o5tYE340Zl9XUKrJk4O0qvSK98bwCrEqqt4QkSkr Jo2cVHygQEsdy37CK6j50A6i5FJ4yABmQ1Q7+sRFrUWbo/JKOxNZqOcJLPBCaqD1n1wF Yrf5C55tJS6PyHPypA/8lySBNS2xbvGDWimqZ6HI7TfkOLhGkEhdc9FTnqTsIFYYd5az mKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770661256; x=1771266056; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSV3vsUg8E13DVBRTy1EKOAg5TL6exZt8xqnFEN40xk=; b=Cj1Qvu4Jjht6m+rh+0T4FjdDj+5mmf1Xu6IhFyyv2aBpp2HNWASgOxMk4ii8vWkSSA BXTZRG70r7ou3c0Rj/KFYdjZzT4RsAIdReHj8EFgr7SVvmP8tl7BmkrL7apiIrV1Q3NU 6B0UuHlbpaHK4yedRoT56DIVFAKrcfUD7GRs9yzi3Ru9QCtp+tCecKQKGwOkRE+3qEm0 qb6Cx9Zxc761wiT9cqPGz3ysbzsrvt6bYb1evsdtTmilYf3j/lW48a/p4edRQjOGgTlT 1f0p3gJ07Eb427P4ysaGJ+64WF2sNrcdLpD/7QApw3Z4RKRRZQ8qzGt6roXN7UYX4uPV IMPQ== X-Forwarded-Encrypted: i=1; AJvYcCWnWdkpMjrznpr+jDAT4YB1AQjGGSE+5EuiBN3yWBqBYdPwUkfzhs30ZUj8dBxDNGi4LJ5TUEKkWN8sSeE=@vger.kernel.org X-Gm-Message-State: AOJu0YwBbNZAjcDcl/Ugta1b8jBwB/Ba7xwru/ySp+0hDYMrtQcwpl42 Fqdxf+vI/wPbPbnLa36S2WnuQfOWdw5Q1pBan1aiuGouPpjbn2OuuIHf X-Gm-Gg: AZuq6aLgMGfjPnlTX60/WJPOjpfxxg08+KzC9hZ7QURDd4dKYj9RwdupWH/zA7Y351f aatm8VuJvwAK0O330wrMy+d1AtMqwjWL5q4PIUcP8BJULpzLfpRv8hkxTMVn9hJOcSAeye3yevX 4D/YzMhpIbaYffxFnEZvLEv+lj6I0e8yNtScYtZPDTl2Xatq5u+SGW84wGIkgK34OAD4ogRprRB r+fq9qQhsXcCNUmc7Ua1ahBg+CuywUxIfEWvH9mfg5XXX13HMXdkCS6uJ8QMcDR0RDo+prPtRuh vCWLaKqXWThByGbfC34xSfH9PJloZETSYit0tJI3BO3R/D+Iaka3McKCAKURrgkZ3u0o9OF6FX4 OtZZb+FGQGv5e5iU8taOOEBcYiym4gX15DbLkvhaUC1JnWi7l9iu62NvBYKCHseFrx+xqnKz6gS oArL6dFZDeBrHr2Ciss1SV2XV2rhec0qI2QXSoIsy0pqFEHQjSDBKh X-Received: by 2002:a05:7300:e207:b0:2ba:7ed9:1566 with SMTP id 5a478bee46e88-2ba7ed91857mr794184eec.25.1770661256115; Mon, 09 Feb 2026 10:20:56 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:616e:78a2:cc03:4be3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b95505b8d2sm4714919eec.6.2026.02.09.10.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 10:20:55 -0800 (PST) Date: Mon, 9 Feb 2026 10:20:52 -0800 From: Dmitry Torokhov To: Fabio Baltieri Cc: Benson Leung , Guenter Roeck , Tzung-Bi Shih , Simon Glass , linux-input@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/1] Input: cros_ec_keyb - add function key support Message-ID: References: <20260112093309.240905-1-fabiobaltieri@chromium.org> <20260112093309.240905-2-fabiobaltieri@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 09, 2026 at 03:46:20PM +0000, Fabio Baltieri wrote: > On Fri, Feb 06, 2026 at 08:25:14AM -0800, Dmitry Torokhov wrote: > > > > I do not believe this flag is needed. Always do FN processing. If there > > is no FN in the keymap it should work just fine. > > The problem is that if there is an Fn key and a keymap, hence we process > the Fn keys in the kernel, then we don't send the Fn events, but we > currently have devices deployed with an Fn key where the key is handled > by the userspace and they expect KEY_FN events to be emitted, so if I > let the "fn keymap" logic kick in it unconditionally it would cause a > regression for existing devices. Hmm, I see. Then I think we really need to have it as a device property, because keymap can be manipulated at runtime, so depending on it to switch processing seems weird. It is like autorepeat, either device configuration asks for it, or it does not... Thanks. -- Dmitry