From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ethan Lam <ethanlxkernel@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
hverkuil@kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: media: atomisp: fix block comment style
Date: Tue, 10 Feb 2026 11:43:24 +0200 [thread overview]
Message-ID: <aYr9vMzvyBn83A0U@smile.fi.intel.com> (raw)
In-Reply-To: <20260210092312.29322-1-ethanlxkernel@gmail.com>
On Tue, Feb 10, 2026 at 05:23:11PM +0800, Ethan Lam wrote:
> Fixed all block comment style warnings by checkpatch.pl.
...
> /*
> * DFS progress is shown as follows:
> * 1. Target frequency is calculated according to FPS/Resolution/ISP running
> - * mode.
> + * mode.
> * 2. Ratio is calculated using formula: 2 * HPLL / target frequency - 1
> - * with proper rounding.
> + * with proper rounding.
> * 3. Set ratio to ISPFREQ40, 1 to FREQVALID and ISPFREQGUAR40
> - * to 200MHz in ISPSSPM1.
> + * to 200MHz in ISPSSPM1.
> * 4. Wait for FREQVALID to be cleared by P-Unit.
> * 5. Wait for field ISPFREQSTAT40 in ISPSSPM1 turn to ratio set in 3.
> */
Please, use your common sense. The above is false-positive.
...
> * The standard CSS2.0 API tells the following calling sequence of
> * dequeue ready buffers:
> * while (ia_css_dequeue_psys_event(...)) {
> - * switch (event.type) {
> - * ...
> - * ia_css_pipe_dequeue_buffer()
> - * }
> + * switch (event.type) {
> + * ...
> + * ia_css_pipe_dequeue_buffer()
> + * }
> * }
No way, really.
...
You need to read the code and change wisely. NAK for this version.
(I'm even not going to read the rest.)
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-10 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 9:23 Ethan Lam
2026-02-10 9:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYr9vMzvyBn83A0U@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=ethanlxkernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®