From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E80DB32ED34 for ; Tue, 10 Feb 2026 21:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770758528; cv=none; b=uXW93IJREQ70+7SzC7U4iz0oZKNPiFdXoGc5jG3JDEXjBUJvPbcuUrOJBENSMLMZC0v955G22+1xekm6wSrTOpDdSQtaZnzNUjcrcz6/JcOFGAXF2r+2wwPp1zV1kMm0rKpDK64H6Cd/eu5FIHY2L7EEHdyEc/zUt8uXT1grXME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770758528; c=relaxed/simple; bh=SZZyyFOo4ipSn+s/JnxYiRFx8kVcIC+Dy+zK3yvV4XA=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tihgfnySoJpy15Hxd7yD5BlzJxGEjnBf03g1c7YN4a7HRIkGT+Y7MEgY1QAa8bdXM9eCkgZSgRea8VIBxqJHOb8foJM9chvagmgwnWYzAuGddkAx9n5iohCDq/lrzCx1/4haKuckoygVAQw8jj3RFQA4Rm9lqOofSsPMRqN3Opc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i1FIdCLa; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i1FIdCLa" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so14492895e9.2 for ; Tue, 10 Feb 2026 13:22:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770758524; x=1771363324; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=aFMnbyIMFWqCOPwVX2vRxrTvT44BLLb27MqwwaXgklk=; b=i1FIdCLaiJqbKgdp8C+FaDV65JhfcwzKbWEJiI0YwBHsKNSjo7D1mI2lpxHXPWU9cN U9sKlBxfy8+pcv+WoxhVER8JwCoTe21lxgliNESDPf4TrJPN+TJgJxOcUkqpQznopRsk rDVkzq+Jyb+zSuFswWvZgpdB/vpVyp/WYWQ3SkC6vel5hvkzjs3rpvN6mq7jvn6z87zz HGPwQQGDkDDpPmXP2/307rUqofgYmpctKXWEPPyyoHJH3M+/cRYQ5+Nt27ExkliVX7Bg 4TMrdkibi4dJONnlHq+t26TKwe0Uim0kfbcq4igvXjSaU/95meIe55Pq/1gRegl3pPQF TQgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770758524; x=1771363324; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aFMnbyIMFWqCOPwVX2vRxrTvT44BLLb27MqwwaXgklk=; b=EovC8WhxGG0tHOZWd8ZSoiAZ8p5YqcszfCnlxaaCUHK+kVPI0gR3v9ouJRdsbpN6yE /DyxLaRH6g2pQ8pcqnD8C6kvI1JSQO8XuHNAKUJAsRRi1xdyD0mCGbsk1Vdm0oWKuT64 MobFayQ0ufchNLjUquNKNfysa4+nYFPHA4cntz9AdctygG/P/LPeAzv9zyVtq324VrIE eyVgRIpGt9kiCuUi9ELJ/hwtxC+bK5rKXTlJ5U7tnwDRpogBbrrf/Va0IbPLEtvXUDV8 SklU25GZNKUwCkJqcW2qfl8ZG0NvYc+LGqP78VY2eQgBESIPUfm3WKVKC/hBlQd6nxsM 9c1A== X-Forwarded-Encrypted: i=1; AJvYcCXNIwhX8J1SPbGVYeTp1HuWPuK8C53y3TfcIWBp8kDsxC2sP51hVUQGjAoi2nCsC2pkrG3h7rNCJBS4GVw=@vger.kernel.org X-Gm-Message-State: AOJu0YxINE9Ll/WdhHAawH3cr2kEg2Nya0q8H/5oN6+zmWsdWvJRqdyu lD4jC8bJOM1sQjWL/gWTmEUdr6mwdj25XqmCxsk3B2Y0mIexqoFQiYI8SB7Ytu4R X-Gm-Gg: AZuq6aKqQHAjmO69QxgjjafE4MvThfA5MvS2gmeowFTbRs9V0yBgi/5iSY8zpK5dIky D6rHSyOOl3EVjWTEnlcnNEqjEIm2V5iZOuKdhV21YgtjQ69HjKBLO5ftAPJ5U1BqMptihr9Ap1q X8f8fsIwWSJMDNdghaf2a+ZWR85Gs7K8RAC5YcSvm8RMvQkHk0h5xD4wjxwz4MDEPtFK1h4h3Vd xafH/Clnhnv+RmF5q5qjsxq/ifbUFPiX9n3yj8+FTNQlFgxriC55pOJhwNfazX3oUlj8J1HtUjq 3p8suLdxzqbeRyapfsk2XVJicgVuGE1rwPF3qjG+PqdbOpDdT+SaLVzBc6xHSeq4d8GJJpVdcFT DbwxIzA7g7t/EcukLDuCUjToYNQFigxAs811tqCGPiROW0pU/Vi6tcHonTRqN1ItCpFD8p5OXr4 bEr5Va3c3fvJ8= X-Received: by 2002:a05:600c:3b23:b0:45d:d8d6:7fcc with SMTP id 5b1f17b1804b1-48320225ef9mr241947475e9.27.1770758524058; Tue, 10 Feb 2026 13:22:04 -0800 (PST) Received: from krava ([176.74.159.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d7d53c3sm91014225e9.7.2026.02.10.13.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 13:22:03 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 10 Feb 2026 22:22:01 +0100 To: bot+bpf-ci@kernel.org Cc: andrii@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev Subject: Re: [PATCHv2 bpf-next 4/5] selftests/bpf: Add test for checking correct nop of optimized usdt Message-ID: References: <20260210133649.524292-5-jolsa@kernel.org> <189eab8445c1c9fa3b7e4c6dde23b4a30dc7f63ed2d3df62a1f8c889280f5927@mail.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <189eab8445c1c9fa3b7e4c6dde23b4a30dc7f63ed2d3df62a1f8c889280f5927@mail.kernel.org> On Tue, Feb 10, 2026 at 02:12:09PM +0000, bot+bpf-ci@kernel.org wrote: > > diff --git a/tools/testing/selftests/bpf/prog_tests/usdt.c b/tools/testing/selftests/bpf/prog_tests/usdt.c > > --- a/tools/testing/selftests/bpf/prog_tests/usdt.c > > +++ b/tools/testing/selftests/bpf/prog_tests/usdt.c > > [ ... ] > > > +#ifdef __x86_64 > ^^^^^^^^ > Should this be __x86_64__ (with trailing underscores) to match the standard > GCC predefined macro? The call site in test_usdt() uses __x86_64__: > > > @@ -516,6 +599,8 @@ void test_usdt(void) > > #ifdef __x86_64__ > > if (test__start_subtest("basic_optimized")) > > subtest_basic_usdt(true); > > + if (test__start_subtest("optimized_attach")) > > + subtest_optimized_attach(); > > #endif > > Without the trailing underscores, the function definition will not be > compiled on x86_64 while the call will be, leading to a linker error. it actually compiles, interestingly enough __x86_64 is allowed as well, but it's a typo.. will fix, thnx jirka > > > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21867569087 > > AI-authorship-score: low > AI-authorship-explanation: The commit follows standard kernel selftest patterns with a natural coding style and contains a typo characteristic of human error rather than AI generation. > issues-found: 1 > issue-severity-score: medium > issue-severity-explanation: The mismatched preprocessor macro will cause a linker error on x86_64 builds, preventing the test from compiling.