From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD82D277C88 for ; Tue, 10 Feb 2026 21:42:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770759725; cv=none; b=gsLRkHlbQ4Gjh7H3f7Y3Gwol2KQIIq2bXa7cwA3HpM6EUsSsY4NqjBikbNF5vFcYixMU2rdgwy5zK6oUlRxdaI57o2qB7cF/w0GuW9Qgz9sfk0Y78Vvd9L+63+oEOIIJ6X+A4zfUlZW+MSylzB7QPJceAIwFRti4DWjKg0XnhlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770759725; c=relaxed/simple; bh=++5C+WbJLxmGHUXQuuM+mG2vQ+nrCXeiqTx33Y5OROY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KVNuaJdnDyVRELq/782aa5p3AwCK3ypjUFRNXwe/DZx76wVq6iwooVGRXhKZFqrBhJFjOyladvnSB0KALGlUYZ6/FVnypRSngfoHL63R/vgt6MAhX6brsqCMurKP3kms2ehVPR+piYT/YP4DXyFg/0Ou72cGguTIvf8fp5sWBoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XqYHlD/S; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XqYHlD/S" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48069a48629so55829765e9.0 for ; Tue, 10 Feb 2026 13:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770759722; x=1771364522; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mznFkkE5Sy4uQAB5r8Z5+NdhEJ0VFdYRjnQi6n0QRfQ=; b=XqYHlD/SbcXTX75V8u9cUJsa3migCchkW6JZqeV5mqDSj8i4zGv6cfd+OthhL57ASD 1cfSYb/PI2M5GY/zEfRAjBmmHZVDohP/VoeNJBRfZf9G2yzh1c7VKNc4Qz6FEIEqyYHd Te2Iz4nnqAPB3JMZXJjbPegLDbJyvMBeuEPqc8LY96ObGmp5gEo/mWO57zlMuiJkYm3W sqSinqhvkZBc15JavW/qOcP2UAojyLyZ7fUwXI8OTpTcFT+meh3lGcifts+eCrRZiQOe Vhrl2KmWQ12WzBMTdJfyuegqcuUjy/Dc/4+fusl/Wb0JUOeSyj15Ytd9EN/v8cCQ/LaT uRiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770759722; x=1771364522; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mznFkkE5Sy4uQAB5r8Z5+NdhEJ0VFdYRjnQi6n0QRfQ=; b=DRCggbZ+kKSukcyUuwlvCkvrsI13RRERCLSiOGTPLYEZHvniHcPLDHz0oTCFe38zwN Fu9A+4eDxLBgLehH/esgxqmY6LIXSrS2FRtZCIzn+UzhL++uFFqidaWu3XGvr3CDD361 zXBpJl1hmkw7jEc7lWEWpvD/KFZHStOshSyNlaxPpbyjy4kQM4Y39kWWAaOjWHaFNFD1 5PwlwC8JML2/XtE/RqUOW4CR1EnEldxRTDqb9UKGikHcLrkUCsPVToVoiNJUAOaVVcgi TTklEYwQL4SDLqxwzzcnUweqflD/hac7RXsHAkgzG3fp+cVnAPLuxlhFsaCOl92adWSE /hMA== X-Forwarded-Encrypted: i=1; AJvYcCXHNuTeuTAnDI8q2Vq+miDufO+P+fbhQYhvNnqDbYrxg3qWbQ2XxNj0rvsDYYKs2d/ka98DQo0UroIvbJY=@vger.kernel.org X-Gm-Message-State: AOJu0YxrEN2+/Bc0wy078y3YQ2YFVAPwEk8Y2vD/fCxDylPnjOfVhFsv EdNxN4/4AGdvhBSNFRvWIukDD2eC1g7hBS2wKBL8dEl7Rr11X8F+ETmN X-Gm-Gg: AZuq6aJ32nRYDkHdRfTBrkq2Gnia/7FfdkD+bcVts96c5talIlSApt1cy3sRk4j/TpV khFel/EbZA8dU0x9TgJZc7vqCRiqu3r5rVcoJRJpe7eAvgMIlS2vf06FmEyY5x6OJMqUmuwxv4Y TMM+GI4IyksQUo4snr6Xpw0ZCqJ/DbDx3lL7agkKtv6oTNwkRcfrHDJ/+2ykms8W/UKJUTFA8jl oJL3wL77XtsSRRz4B6cQpPnNlW7kmsqQqlP/vNXJdHVe5HHvMwg6EHTlS7vikOjmbIN+cnoiCWe ZbWlXVVvS5e4YkCsVYDVviK412Wvyz1/bVGiIb5jBOBWaGGGt9rEWYMjXrmVDN8BbdeBailchQ6 MlbXr4+2v6GPdLULhBde670xUBoKBDpJWk7dWm/7cloiGik9bYThufWBkmf9lzwR9s3PGxJkJqZ 8K9bIt2hJnneM= X-Received: by 2002:a05:600c:8587:b0:480:6941:d38c with SMTP id 5b1f17b1804b1-4835082d177mr52982815e9.29.1770759722099; Tue, 10 Feb 2026 13:42:02 -0800 (PST) Received: from krava ([176.74.159.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835a5bf1efsm9740635e9.0.2026.02.10.13.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 13:42:01 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 10 Feb 2026 22:41:59 +0100 To: bot+bpf-ci@kernel.org Cc: andrii@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev Subject: Re: [PATCHv2 bpf-next 5/5] selftests/bpf: Add usdt trigger bench Message-ID: References: <20260210133649.524292-6-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 10, 2026 at 02:12:11PM +0000, bot+bpf-ci@kernel.org wrote: > > diff --git a/tools/testing/selftests/bpf/progs/trigger_bench.c b/tools/testing/selftests/bpf/progs/trigger_bench.c > > index 4ea0422d1042..f631706bbdc9 100644 > > [ ... ] > > > @@ -180,3 +181,10 @@ int bench_trigger_rawtp(void *ctx) > > handle(ctx); > > return 0; > > } > > + > > +SEC("usdt") > > +int bench_trigger_usdt(void *ctx) > > Should this use SEC("?usdt") instead of SEC("usdt")? ah yes it should, will fix, thanks jirka > > All other programs in this file use the '?' prefix to disable autoload by > default: > > SEC("?uprobe") > SEC("?uprobe.multi") > SEC("?raw_tp") > SEC("?kprobe/bpf_get_numa_node_id") > ... > > Without the '?' prefix, bench_trigger_usdt will be auto-loaded whenever the > trigger_bench skeleton is loaded by any benchmark using setup_ctx()/load_ctx(), > adding unnecessary overhead to unrelated benchmarks. > > > +{ > > + inc_counter(); > > + return 0; > > +} > > > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21867569087 > > AI-authorship-score: low > AI-authorship-explanation: The commit exhibits natural kernel developer style with real benchmark data, informal comments, and follows existing codebase patterns with minor inconsistencies typical of human development. > issues-found: 1 > issue-severity-score: low > issue-severity-explanation: Minor pattern inconsistency in test code where SEC("usdt") should use SEC("?usdt") to match the established convention for disabling autoload by default.