From: Jeff Chen <jeff.chen_1@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
briannorris@chromium.org, johannes@sipsolutions.net,
francesco@dolcini.it, s.hauer@pengutronix.de
Subject: Re: [PATCH v9 18/21] wifi: nxpwifi: add core driver implementation
Date: Wed, 11 Feb 2026 21:18:01 +0800 [thread overview]
Message-ID: <aYyBiYr6Zkv+Fzyi@nxpwireless-Inspiron-14-Plus-7440> (raw)
In-Reply-To: <57439b2a-f606-4ee5-9287-72c40bd726e8@kernel.org>
On Wed, Feb 11, 2026 at 10:36:22 AM +0100, Krzysztof Kozlowski wrote:
Hi Krzysztof,
Thanks for the review.
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
>
I will update the commit message to use imperative mood as recommended in
the documentation.
> > +
> > + /* Notify PM core we are wakeup source */
> > + pm_wakeup_event(adapter->dev, 0);
> > + pm_system_wakeup();
> > +
> > + return IRQ_HANDLED;
> > +}
> > +
> > +static void nxpwifi_probe_of(struct nxpwifi_adapter *adapter)
>
> NAK, you removed DT support thus cannot keep undocumented ABI.
Understood, and thanks for pointing this out.
>
>
> > +{
> > + int ret;
> > + struct device *dev = adapter->dev;
> > +
> > + if (!dev->of_node)
> > + goto err_exit;
> > +
> > + adapter->dt_node = dev->of_node;
>
> NAK
>
regards,
jeff
next prev parent reply other threads:[~2026-02-11 13:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 18:03 [PATCH v9 00/21] wifi: nxpwifi: create nxpwifi to support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 01/21] wifi: nxpwifi: Add 802.11n support for client and AP modes Jeff Chen
2026-02-04 18:03 ` [PATCH v9 02/21] wifi: nxpwifi: add initial support for 802.11ac Jeff Chen
2026-02-04 18:03 ` [PATCH v9 03/21] wifi: nxpwifi: add initial support for 802.11ax Jeff Chen
2026-02-04 18:03 ` [PATCH v9 04/21] wifi: nxpwifi: add support for 802.11h (DFS and TPC) Jeff Chen
2026-02-04 18:03 ` [PATCH v9 05/21] wifi: nxpwifi: add support for WMM Jeff Chen
2026-02-04 18:03 ` [PATCH v9 06/21] wifi: nxpwifi: add scan support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 07/21] wifi: nxpwifi: add join and association support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 08/21] wifi: nxpwifi: add channel/frequency/power (cfp) support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 09/21] wifi: nxpwifi: add configuration support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 10/21] wifi: nxpwifi: implement cfg80211 ops for STA and AP modes Jeff Chen
2026-02-04 18:03 ` [PATCH v9 11/21] wifi: nxpwifi: add firmware command and TLV definitions Jeff Chen
2026-02-04 18:03 ` [PATCH v9 12/21] wifi: nxpwifi: introduce command and event handling infrastructure Jeff Chen
2026-02-11 9:39 ` Krzysztof Kozlowski
2026-02-11 13:26 ` Jeff Chen
2026-02-04 18:03 ` [PATCH v9 13/21] wifi: nxpwifi: add data path support for STA and AP modes Jeff Chen
2026-02-04 18:03 ` [PATCH v9 14/21] wifi: nxpwifi: add debugfs support for diagnostics and testing Jeff Chen
2026-02-04 18:03 ` [PATCH v9 15/21] wifi: nxpwifi: add ethtool support for Wake-on-LAN Jeff Chen
2026-02-04 18:03 ` [PATCH v9 16/21] wifi: nxpwifi: add utility and IE handling support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 17/21] wifi: nxpwifi: add driver initialization and shutdown support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 18/21] wifi: nxpwifi: add core driver implementation Jeff Chen
2026-02-11 9:36 ` Krzysztof Kozlowski
2026-02-11 13:18 ` Jeff Chen [this message]
2026-02-04 18:03 ` [PATCH v9 19/21] wifi: nxpwifi: add initial SDIO bus driver support Jeff Chen
2026-02-04 18:03 ` [PATCH v9 20/21] wifi: nxpwifi: add Kconfig and Makefile for kernel integration Jeff Chen
2026-02-04 18:03 ` [PATCH v9 21/21] wifi: nxpwifi: add MAINTAINERS entry for nxpwifi driver Jeff Chen
2026-02-04 20:09 ` [PATCH v9 00/21] wifi: nxpwifi: create nxpwifi to support Johannes Berg
2026-02-05 6:48 ` Jeff Chen
2026-02-05 6:51 ` Johannes Berg
2026-02-11 9:42 ` Krzysztof Kozlowski
2026-02-11 13:37 ` jeff.chen_1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYyBiYr6Zkv+Fzyi@nxpwireless-Inspiron-14-Plus-7440 \
--to=jeff.chen_1@nxp.com \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=johannes@sipsolutions.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®