From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F893274669 for ; Wed, 11 Feb 2026 21:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770847163; cv=none; b=FJlss2rmboY+Z7q9tR54RZOnPRhSQmcw/1jRFN1AJB0RFihqK9JkNSvqCIJC5XUyP9HBDzHoaiGX21d3q+nVc1MrQsQtS36wwE86HaxVzap9LfNTeLRtIGpzmWXQHchzz7m4GgkwPA0EC1nUbMT9qzK86OI4UsmSvBYAaASxOj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770847163; c=relaxed/simple; bh=s9U6kjYfcdNgbL5cGo69XZee74QW3keLG0gNuQ4YCtM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ID9uL/bBYWAFIfY0Of0S68VUjtWXL2GYaFECJR7EEV8lgXT1P0b1kdNZikcFm9w4gqizaO+Zh559+uuw6vh7gQ/vkXAyahgxQm/ZQ5t6wxpSN94515Q4dtHGZdqGWdGYTdbBcj0yptIEMox/dKqV/GY17Iw+FN0CqALL5BB3EpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=hOneO5Cg; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hOneO5Cg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AojB6NpczDdBWw2M9YMCKzlkDQzN1cz5fhoVcgmRVBw=; b=hOneO5CgSAB+iYuHLNcUFBM+56 0XSkW/HJXC9QQ4LHCud43RZ8Qoyfrd/pfKLBvxOa3bv8Sq+4fJwQtJfthP3pQF4WhdrXSJXhm2X6G RmVxlvuMggL1TW2SgchHqqh7cG/doykpZyqFEaqFwTtikdVv/ST4e4O2oRCHBkG9O8X8M6hIRETo0 RcZP5xVmDFsaGHI22zs4juls23fntMtRXbWDR8xhlR3RzN29JL8lYjuWRwByJK+PwbDVEKpb+qPiF eg+hddPmGULyvWvvMgqBYoeY/4LFsjKMCz/sANGfYTzhoeXcxcCW8cLqN8x1/hRANlWjs8Gc2TR5d 6la2ocbg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqIEx-0000000DFOW-1Wjj; Wed, 11 Feb 2026 21:59:19 +0000 Date: Wed, 11 Feb 2026 21:59:19 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, "Mike Rapoport (Microsoft)" , akpm@linux-foundation.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v5 4/4] x86/mm/pat: Convert split_large_page() to use ptdescs Message-ID: References: <20260211195233.368497-1-vishal.moola@gmail.com> <20260211195233.368497-5-vishal.moola@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211195233.368497-5-vishal.moola@gmail.com> On Wed, Feb 11, 2026 at 11:52:33AM -0800, Vishal Moola (Oracle) wrote: > static int > __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, > - struct page *base) > + struct ptdesc *ptdesc) > { > unsigned long lpaddr, lpinc, ref_pfn, pfn, pfninc = 1; > + struct page *base = ptdesc_page(ptdesc); > pte_t *pbase = (pte_t *)page_address(base); We have ptdesc_address() already. Can we avoid the other uses of 'base' in this function?