mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Peter Yin <peteryin.openbmc@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Jorge Marques <jorge.marques@analog.com>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i3c: master: dw-i3c: Fix missing of_node for virtual I2C adapter
Date: Wed, 25 Feb 2026 18:05:01 -0500	[thread overview]
Message-ID: <aZ-AHSkUKIBtb7ZZ@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260225093755.3696236-1-peteryin.openbmc@gmail.com>

On Wed, Feb 25, 2026 at 05:37:52PM +0800, Peter Yin wrote:
> The DesignWare I3C master driver creates a virtual I2C adapter to
> provide backward compatibility with I2C devices. However, the current
> implementation does not associate this virtual adapter with any
> Device Tree node.
>
> Propagate the of_node from the I3C master platform device to the
> virtual I2C adapter's device structure. This ensures that standard
> I2C aliases are correctly resolved and bus numbering remains consistent.
>
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> ---
>
> Changes in v2:
> - Move the fix from the ast2600-specific driver to the dw-i3c common
>
>  drivers/i3c/master/dw-i3c-master.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index d87bde3f7700..adf618d131dc 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1659,6 +1659,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
>  		pm_runtime_get_noresume(&pdev->dev);
>
>  	INIT_WORK(&master->hj_work, dw_i3c_hj_work);
> +
> +	master->base.i2c.dev.of_node = pdev->dev.of_node;

It should use device_set_of_node_from_dev();

Frank
>  	ret = i3c_master_register(&master->base, &pdev->dev,
>  				  &dw_mipi_i3c_ops, false);
>  	if (ret)
> --
> 2.43.0
>

      reply	other threads:[~2026-02-25 23:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  9:37 Peter Yin
2026-02-25 23:05 ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ-AHSkUKIBtb7ZZ@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=adrianhoyin.ng@altera.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=jorge.marques@analog.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manikanta.guntupalli@amd.com \
    --cc=peteryin.openbmc@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®