From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80F9D187346 for ; Tue, 24 Feb 2026 06:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771915316; cv=none; b=uKBHv3hUJE+/6BBAiXFrFjH2hyAuKxrn9xtJo3Gnc97xSo0HJv8qMVfSzGA0NSOVNZs6xYtcKGpv7aOVizMLX+yXhKjrfEM6eA/6p6/yVubaW/0/k+e5JjjQ93tljBnDHcxAD1ER3OrPhrgnHgzK1UnHq957ajWbSEdG9NueZnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771915316; c=relaxed/simple; bh=tODBFoOzQoK1KUOioaeK1k4O5kVSmJM4fCLAR3eZxnU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WquS5ZqVtCLM6qxY0kFtluXU/GJvbJy+9bf6XTBhd+YGSjEmu3ryXxNlw6CW89kVq6u0zw9SvnKYzDCB0/f7Eosx7ZCXTsGzH/SJ8w5wYhhiPHEWmyEY7E5Jau3G2nmJ0MfisFxmCak925idkxDf/utpLQFx5C0HjsICzZl60eA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LxXtQ0rR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F9arnuAZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LxXtQ0rR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F9arnuAZ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61O4LlX21754448 for ; Tue, 24 Feb 2026 06:41:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=lG/xeXk2I/MOcbaT0nf4rKBx XhOqmOGfGClBVPWMObA=; b=LxXtQ0rRpY2L2rxvR5nZeQmXd4kcCzKXgsZfTStB EFWeY7EGARo3NtmSwZRxHG3PRjcSSjrzc12yD9JCbGAmd3yHNHdMJD2k951++t9E la5+Mcsy71DWaCJj7VbjhYc3TjRjKRjLATk6a61i8z2+mzntnMwro2AjKthTE/kS K/s/gh4oO7oL3hVzdb4EnJ4zNVOmmEKUaW2q3D0C3Ewo07MJBVQjSGBjQ2cCgmcs +I0KJAJvWwdP+L5yxmEe92xbQyO4hUG5Cu//twy3LvH8Mcia+fuqoEBgxEaVNMNG yNxhIdleJY273zKHbaUbtqZVgFI08vqDtTBSMlpFpi7gWQ== Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn81b7mp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 06:41:54 +0000 (GMT) Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-679c51b2d6cso34411149eaf.2 for ; Mon, 23 Feb 2026 22:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771915313; x=1772520113; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lG/xeXk2I/MOcbaT0nf4rKBxXhOqmOGfGClBVPWMObA=; b=F9arnuAZUkl9yRdSiHgUvOdq7t/n3wOWRTwefmJ+oGITIj01CrHd1uz811p/OfMK3Y 29dUkT/ucJVBNBk4lzKaJww1G9GcE2GXWlEauH7eFWHJYDuIHBQBg19kGggqhF9uX+Z3 6K7K+HDZ4yA3oILJ780pTCgbCmykOmonrAZ5Guq93rD7okLvag5lknxPokcfRQarjeiI xR/MMX3nrCW3WDJQ+P+Nt9NzAczka57zwFyHNiFejzJ8C7UWxZYbgpj3uvBGGSSJMOJz LGmtc72OrD/sezQntwE5SOtihlhdDg3qHLK0n7eUl4TR3ay+kt8WD5IdrwQmjHKHdlt1 iUlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771915313; x=1772520113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lG/xeXk2I/MOcbaT0nf4rKBxXhOqmOGfGClBVPWMObA=; b=QSXQ3C6CqRnTWs5sa7pTF01O0wBNV7/loy6m24p+3poCWuS18pdYJ9jNK351aa4vM3 KCMvBXia2Tb6hG1jhnLL2MtKde2Z1ivkV2gfu1MqRS8lG3eLoULjV9zfv9JqiL339gqP eVggzxQ9wDNd1HCB3FPn/4UF94m/YBb85OASDtaPZFP5BFJEMuWBZjfcxHHA9bul3ejO UEKTYeHOWcT9F0zrtqB7WLD2fgPNjUfMY2PGexZQYBUZ6uw4mvcJv/3+UbKYImP4kCnX DbrHlbGkehBveGO1ookBdd/UAoKFQ5myJadWyrQbpgFnVUB+SF+svyw6rzjJ9BOnk8Yv sB/g== X-Forwarded-Encrypted: i=1; AJvYcCUxI3ujEtnm2YTW8L0ydoJDp0ye96UQwoX3klhVN013o7Nar3+v0n1pWz1mZUhIgCjpUF4fIZTkvpl+fwo=@vger.kernel.org X-Gm-Message-State: AOJu0YxXP+nUEn5iqUjhiDZjIW5kcn6JbZHwj3l8sC6p7DkMCtKJk+4w 4WXA+zpNmvGCg+6U+Q1ofj19Tdb1Ll+TGEjfh3XLvJNlFQgCBM3dx8LniEU9Ok3uJ5NqGT/lxjD q3kxDoC7aV7T83vtoXNwIhqPlDElNwLDMK3fvwaCchycjJYZB06eqG7tsELdq3ISPK2I= X-Gm-Gg: AZuq6aIc+Dv2AiEooDeGeCwJrfPqOxnVuHP6lDQcPl9A67OOMqOnHD02CcOzkcJOV10 D+ilNEfZrHKetCzjTNd7IlakSmKgKU733RtSVJiYR54+DmPqptB5r34BeRVUj/wzm8nW3OQevFk mOo/efvOJWL+7/MZYnXLlnjA8uwD2oBC4iPIx9hkUpdDsx1drwLJh6VPyvJeCHyG/bDnL79h9AZ AHdx/T049ZqoWxJnLikJRBmH2YpbqG9O5wvTurq8FE0MBapTnXNFmU8Mk4fAx5uZIONWwmuCMW/ xzvJ+1qku5xp6bdVWg82kPXR+r6o8jzrmo7I7j5YjYlraRxpOR9DrhR5vkCtnSELTxCFmDUe99R aqFMHHHwjSK19LrbCdw9e/Iwa4q+ieL95V9+SUPOzbGND304YuDLZ+mbk945+iPMs6eeV X-Received: by 2002:a05:6820:160a:b0:662:b70c:a414 with SMTP id 006d021491bc7-679c425bc9dmr6064081eaf.14.1771915313571; Mon, 23 Feb 2026 22:41:53 -0800 (PST) X-Received: by 2002:a05:6820:160a:b0:662:b70c:a414 with SMTP id 006d021491bc7-679c425bc9dmr6064067eaf.14.1771915313161; Mon, 23 Feb 2026 22:41:53 -0800 (PST) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-679c5630827sm7711238eaf.3.2026.02.23.22.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 22:41:52 -0800 (PST) Date: Mon, 23 Feb 2026 22:41:50 -0800 From: Qiang Yu To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add vdda-refgen supply for Glymur Message-ID: References: <20260208-refgen-v1-0-87ca84fd78b3@oss.qualcomm.com> <20260208-refgen-v1-1-87ca84fd78b3@oss.qualcomm.com> <20260209-magic-conscious-seahorse-b81c8b@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: 5epOb3N5xbobsWKqvkr3uVvJnZV4B5Id X-Proofpoint-ORIG-GUID: 5epOb3N5xbobsWKqvkr3uVvJnZV4B5Id X-Authority-Analysis: v=2.4 cv=CbsFJbrl c=1 sm=1 tr=0 ts=699d4832 cx=c_pps a=wURt19dY5n+H4uQbQt9s7g==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Mqtz4aph0Rek3LVAYukA:9 a=CjuIK1q_8ugA:10 a=-UhsvdU3ccFDOXFxFb4l:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA1NiBTYWx0ZWRfX1vjYMhu6Wlq8 4KKsyKIa2gnyLthaGyKXqZElMOb30xlT26Thdwytzn5Kmxe8oalqoEcSYkiOUuvr4ezpmf3e1CM Dv5Y7VYkSwLhvUpOXvo+j8g4u+WIRis5eSeooxiq8Lr9/N/rQhHCdW3MRsAOJqtTd7EESoTbDu7 PsMOr5NlK3qvk63JRtFVN4zDD6z+W7RUQWYkSP+Q7FUdGeSN9TBeCdQSJLemNkB41DU2RBB0WOz 0VBoePullUUwrMQO5MiMp8gYaER+EqQRQcr2+LSPnc2D35vpDQZmG3frpnjgSYcBp7+bDVAkn2n naHUyqsGHm1ek+E5+j3S5jXMHKzGsg2WtEiROqAGSbfJVFEv+FFmRsK3Xar34rRdrdJMvtDz6Be Ks3zHU9uVQPCWR0vK8eOA4asAFlwW3gX6cOiv+z4GkBC9HXCvpGchr/4noROBqI32c3aGy22BK0 do6kycxLF8FuLFWxgYA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_06,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240056 On Fri, Feb 13, 2026 at 07:47:36PM +0200, Dmitry Baryshkov wrote: > On Wed, Feb 11, 2026 at 07:32:23PM -0800, Qiang Yu wrote: > > On Mon, Feb 09, 2026 at 09:06:23AM +0100, Krzysztof Kozlowski wrote: > > > On Sun, Feb 08, 2026 at 08:49:39PM -0800, Qiang Yu wrote: > > > > The PCIe QMP PHYs on Glymur require stable reference voltage provided by > > > > refgen. The refgen itself requires two separate power supplies: > > > > vdda-refgen0p9 and vdda-refgen1p2. > > > > > > > > Since there is no dedicated driver for REFGEN, add vdda-refgen0p9-supply > > > > > > How does the driver matter for the bindings? If I add dedicated driver > > > for refgen, then I change the bindings? > > > > Yeah, I know that dt-bindings should describe hardware, not software. But > > what I meant to say is that the refgen is different from qref which is > > controlled via TCSR registers and its LDOs are requested to vote in > > tcsrcc driver. The refgen doesn't required register setting and it doesn't > > have dedicated driver, so we vote its LDOs in phy driver. I will avoid > > this statement in next version. > > I must admit, I could not find references to the refgen in any of Glymur > PCIe-related HPGs. We can find it on ipcatalog. On Glymur, there are 6 refgen instances: u_cm_phy_refgen_0_west supplies to pcie3/4/6. u_cm_phy_refgen_3_east supplies to pcie5. This two refgen also supply to other modules like usb and qref which is required by PCIe phy for stable reference clk. In previous targets, refgen was often ignored because it shares LDOs with phy or qref. We typically only vote for vdda-phy, vdda-pll, and vdda-qref supplies. However, on Glymur, there are more instances and less LDO sharing between phy/qref/refgen. > > > > > > > > > There is qcom,sc8280xp-refgen-regulator so why there cannot be > > > qcom,x1e-refgen-regulator? > > > > I think we can and it seems better because the refgen for pcie phy also > > supplies reference voltage to other modules like usb. But I checked the > > qcom-refgen-regulator.c, it contains some register settings and there is > > no LDOs voting. I'm not sure what does those register do, maybe Konrad > > can provide some backgroud. > > Those regs provide voting for refgen, because on those platforms DSI > block doesn't have a hardware vote for refgen. > Okay, for PCIe PHY, we don't need register settings for refgen. - Qiang Yu > > But on Glymur, we only need to vote LDOs. So > > what if we use a fixed regulator in the device tree to represent refgen? > > We could set refgen0p9 and refgen1p2 as its input supplies, then the PCIe > > PHY would just need one refgen supply reference. > > > > - Qiang Yu > > > > > > > > > > and vdda-refgen1p2-supply properties to the PCIe PHY dt-bindings. Use > > > > conditional schema to restrict these properties to only Glymur PCIe QMP > > > > PHYs. > > > > > > Best regards, > > > Krzysztof > > > > > -- > With best wishes > Dmitry