From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFBB736B07D for ; Tue, 24 Feb 2026 09:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771926915; cv=none; b=ujs+kT1BCkufMi3P0EMlK/lsOfE3h1LTCe1kpD2ASdb9MaSsCfTMZ0WuA9qYqF9SjM5cCSh03Ef7R78S3ZbB/Nzxdg+FhoyUbqF9Kui8BHOS1UlEPQ5UEBXN7vBkuMcKRRaBxoYhU31is5ZUG4yLbzd2Gt/EtlohPz/DJVsBAbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771926915; c=relaxed/simple; bh=ELCHW2MDcGHyAOjCI5TzQdz1gK18QvxlUMKh2Jmx5xU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SzG1fC6brld/XBgRtOfXO+ld73eQW2irrAqXkKpeMtiL9uRLNi5l7F1DPqRwQSnAkMV2RV6Mj9jrHySfbnKkbwDCu8VZalSrJ6X/8iIqvhIPhACKlYAxDEOmEodH9yYJhyPaLeyW535sj00BB85lfxZkhlskpmsnOFMiTJBHWhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AyAkQQOP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iNCN77qA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AyAkQQOP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iNCN77qA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771926912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=drtPn3RRebLcYs+RKWbzRzgsO6cnVFeivrQ9r6WAvBs=; b=AyAkQQOPNyyoiijCIBWIjsOTvrVtWffr/mFXzw+sAvW6dUsab+zS9xLFcaEeoG5QTJhxZ3 kDhB2FfW66oYW1xK4QDHBqaXA6WolO9PWhEmiUl5sBITqafafiinq2qkwd8Cl0qz2TsNKh HCWaQnyVqcoLDKLW3LFjm0xAw7tOyK0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-d2Ge6xBFOlSaHlhzPmmG8g-1; Tue, 24 Feb 2026 04:55:04 -0500 X-MC-Unique: d2Ge6xBFOlSaHlhzPmmG8g-1 X-Mimecast-MFC-AGG-ID: d2Ge6xBFOlSaHlhzPmmG8g_1771926903 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4398ad5d81dso134284f8f.0 for ; Tue, 24 Feb 2026 01:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771926903; x=1772531703; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=drtPn3RRebLcYs+RKWbzRzgsO6cnVFeivrQ9r6WAvBs=; b=iNCN77qAuxKgOl13Y6JbhmY7+rojnTQ7Pl8uN0y90x0GoQRHbeKi4rOnF9oNpMvA6S qi6qO/4cw5/Gkh4CTxGaarb0ObhFnI9Q48GyfsXmOyuR6r4VTQn3CvMa4qcvADBzDz/6 c1FEJnRNfG2zehtrRkY1T/iZ4zwnoPrdXJUQalJfuECTWhmAj7aGqM0odArHIsaLXM+b cYnLkyBPxazyMFVDBAxU0y3Qs9czc1BbcaDv9EiSDI1gitBRbyS7TFe7AFk3oH1eD7F2 hLm3FX+Pu5mp25jTPk2i6L6qIzomvWhZt0+4VqRHawRf9kdfNa08hn1GEZbBVV4nT9E+ oJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771926903; x=1772531703; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=drtPn3RRebLcYs+RKWbzRzgsO6cnVFeivrQ9r6WAvBs=; b=jDw53c13HLkUNl7+QrK/0f5IeApbH0ct4kM4zHd4ruBKGB0EN4cdY+rMUbD5iCOyq2 KneeGp6mHdrAz4UuxNp4J+1HUEurItoTg6bfLNuKDkxgRYGhaFAS4chLIqUtZUIPRrfT kdvOOg92hueNiOfsMJiYHdgS7o8GjW5dumq43/EcqsD9StBhOcJHALP8yZxdHFzibHxQ AqHn9aN9sKY+wtZlmcLj2tTzZZ+HELoE2wBSGQ3tK//lxeGaXOuO+WwmGSd1g6EFINJB F0Zm2Vn5EH5/jkB8xv+kJEaxMj2JqapXGn0RL83ci3TssqvfpSPXZ3QoOA4Ja0qxlbqC DM1Q== X-Forwarded-Encrypted: i=1; AJvYcCVTKHlRxk+/iZsddsK+/pZDb30cLLW/BIh6jVHy6AHwQryO7GqQSOYco8kANf6kqFrakxrRJvQlB2bbuhs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxls9//T3NjJ78WkYHrEWr60h3rXtx2Cj3JnwOaq9nVpef9HTJk bOSXid1nVGOOD6Zr2wS0q/o/IdIR/F98Myc7F/OOEUk0ftjxHL4QY+mYmkPGLNawW8h6mgUUj8G qJrDxTVhm+M1Twtik9cCvVcnvLe+edv04c/0wpjPdM1kZ6liY740yHJSK9DqGK2WrCQ== X-Gm-Gg: ATEYQzyqEJxplWI/NiMkgaASgDch2Y04lULhxZIMQIHi06XGuudHAJNbvuwac07OoCd hIDxLgn83XK5UUDjdB1Hn9rqTAn3dGO2sbzuof52lawyndDboisAr/CFJSJINcDaT95FLTd5nk0 YmrYakuescikRHIb/MmkKXi1sZTXm8LSzz5FWZE1wkmFNA7ZEUjvM6eL5XzNv5L6AhRF6o1AKhr ZUuOXSqehW16yN0JevRR2JRUnzyLq5WZbx55O35hyTy4FKqad/apZ9GKCMVb9w0lhi5E264RV79 ax1KZZtcP3WT3sM7ZujOEdpSsd+RM4w81Y2g4yqtogqWUwNW/ATcKTZr/UPySAiLH9fE5sCFDEn NOMUEIUoSrcLOfpEqRC1CR3UWEsYj7EnmW0Oh270OstymZXkym3C/E10FQNliTrx5A8eFUdo= X-Received: by 2002:a05:6000:2011:b0:437:6dac:458a with SMTP id ffacd0b85a97d-4396f18f82bmr19853119f8f.57.1771926903203; Tue, 24 Feb 2026 01:55:03 -0800 (PST) X-Received: by 2002:a05:6000:2011:b0:437:6dac:458a with SMTP id ffacd0b85a97d-4396f18f82bmr19853090f8f.57.1771926902713; Tue, 24 Feb 2026 01:55:02 -0800 (PST) Received: from sgarzare-redhat (host-82-53-134-58.retail.telecomitalia.it. [82.53.134.58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c09897sm26032093f8f.17.2026.02.24.01.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 01:55:02 -0800 (PST) Date: Tue, 24 Feb 2026 10:54:58 +0100 From: Stefano Garzarella To: Greg Kroah-Hartman Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH net] vsock: Use container_of() to get net namespace in sysctl handlers Message-ID: References: <2026022318-rearview-gallery-ae13@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2026022318-rearview-gallery-ae13@gregkh> On Mon, Feb 23, 2026 at 06:32:18PM +0100, Greg Kroah-Hartman wrote: >current->nsproxy is should not be accessed directly as syzbot has found ^ nit: "is" can be removed >that it could be NULL at times, causing crashes. Fix up the af_vsock >sysctl handlers to use container_of() to deal with the current net >namespace instead of attempting to rely on current. > >This is the same type of change done in commit 7f5611cbc487 ("rds: >sysctl: rds_tcp_{rcv,snd}buf: avoid using current->nsproxy") > >Cc: Stefano Garzarella >Cc: stable I'm not sure this is stable material since these changes landed in the latest merge window (v7.0-rc1), but yeah, you know better than me, so there could be a reason. If needed, maybe we can also add: Fixes: eafb64f40ca4 ("vsock: add netns to vsock core") >Assisted-by: gkh_clanker_2000 >Signed-off-by: Greg Kroah-Hartman >--- > >Note, this is compile-tested only. Some of my scripts found this when >looking for places that are missing fixes that were applied to other >parts of the kernel. I think the af_vsock code uses namespaces, but as >I don't know the network stack at all I figured I would let you all >review it to tell me how wrong I got this change and all is fine with >the original code. Thanks! LGTM and tests are fine! Reviewed-by: Stefano Garzarella > >thanks, > >greg k-h > > net/vmw_vsock/af_vsock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 9880756d9eff..f4062c6a1944 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -2825,7 +2825,7 @@ static int vsock_net_mode_string(const struct ctl_table *table, int write, > if (write) > return -EPERM; > >- net = current->nsproxy->net_ns; >+ net = container_of(table->data, struct net, vsock.mode); > > return __vsock_net_mode_string(table, write, buffer, lenp, ppos, > vsock_net_mode(net), NULL); >@@ -2838,7 +2838,7 @@ static int vsock_net_child_mode_string(const struct ctl_table *table, int write, > struct net *net; > int ret; > >- net = current->nsproxy->net_ns; >+ net = container_of(table->data, struct net, vsock.child_ns_mode); > > ret = __vsock_net_mode_string(table, write, buffer, lenp, ppos, > vsock_net_child_mode(net), &new_mode); >-- >2.53.0 >