From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810CB27E054
	for <linux-kernel@vger.kernel.org>; Tue, 24 Feb 2026 18:51:49 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771959109; cv=none; b=Wf5W0badxB9NHkykOfSM5MN43fIpnaqkykGCRWw3nZYZEP1TinceJW90LNMZbJ/U5dYo/PWezYrsABQhXMYVMcsRvnFVg7VMn0UdcFUEZr46crNrAde8P06VUPe6oYyRnATzvsEDPTQvyn5mM+1qkyzjjLlolU5/4g5O2lf/HCM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771959109; c=relaxed/simple;
	bh=AZGNYVpeU1M4JPLowWiAt2wuOLx9+EsKFXkaDQuytuA=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=cjP/cz/Iz6WKHw6MyTIwyLeOcGAwQx6VEvD37MqnTPocCEp55MlsFmPQAhRn8siFV6yMIVwAMHJH6pt0Yf9r0dSeStrUcq2jj4EWX28kTLI04dAn3bzx58rTmyfvRxhxnkYT/qH18iS3gZauJgeDVhzn8IwzpPpzq2QjatTzYJk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MRSec2uX; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MRSec2uX"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C41F9C116D0;
	Tue, 24 Feb 2026 18:51:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1771959109;
	bh=AZGNYVpeU1M4JPLowWiAt2wuOLx9+EsKFXkaDQuytuA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=MRSec2uXSQPQhrd4l6GAFmBmDMrOVjXj8LleMltp8auJ/N94AsUcagjBsMWkLuS54
	 Ojuvc8bjXMCbtyfl1MWVwBxcGiifsWSJwMEPnpKwNM07NIu4eG3cakNGY2d3ybk2aQ
	 uPj6YZoGIFuVgoC0SnhjJndNLOOAZq2myLPBuie69Kq+o9KPONMxRNWy+k/Ajq3/+/
	 OVJfdggSBrorPTC7rvoqn3APUAgNI9HrM/um7wLN2Vbpz6bk4NSMnTWUzWyJYGQ0Il
	 lGIJPA3p899aGWeTfQ/TvtxEXbVCLgytFlS11tWPWm8ro5Dp9/ZM008XHm/DpuqZNL
	 Mx598MihhQ4CA==
Date: Tue, 24 Feb 2026 11:51:46 -0700
From: Keith Busch <kbusch@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/8] nvme: always issue I/O Command Set specific
 Identify Namespace
Message-ID: <aZ3zQkApqZN3tkf6@kbusch-mbp>
References: <20260224171437.3175993-1-csander@purestorage.com>
 <20260224171437.3175993-5-csander@purestorage.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260224171437.3175993-5-csander@purestorage.com>

On Tue, Feb 24, 2026 at 10:14:33AM -0700, Caleb Sander Mateos wrote:
>  
> -	if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) {
> +	if (ns->ctrl->vs >= NVME_VS(2, 0, 0)) {
>  		ret = nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm);

NVMe allows older spec compliant devices to implement features that came
later, so I think you need to keep the old condition as an option in
case there's a 1.4 controller with extended LBA formats.