From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 140D32BDC0B for ; Wed, 25 Feb 2026 06:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002394; cv=none; b=BrtM6qbAVLQswFDSmGCxtdCIfFt+tT7Nm+U498LTcK9TSJm0aGMr2UqztIQnxkpcQuP96t56nZIcwqhUDcmibYZXmT60XPb5wR290yNT6f4p94GmS2ubXdkjm7i3S1Foy46e4gu5AejW/gIRDOzhPq23VZw7wGisNKoiloiiEFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772002394; c=relaxed/simple; bh=azvkRvoKVIujDs9VYbjx0Lm6jj7ex1Oep2d6TkuiZ/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e9Jp+Tk4S/VQpf/f+jVCS82IY+z0AnaoOHwm5YUqXYBB6xZ2ZpXvvgEaOieJNs0Q7XE4NwxBwc5NkMzAiEJxVaYZ5pHOUz/BCJVYI0S25gp0Jpm/FPEjid+JT+fv/OVW4dL4dLYZxP54kFFnh8GHTYKcNicHSY4BvOyuJLvXqMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CMGbiwbr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CMGbiwbr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4837634de51so28082905e9.1 for ; Tue, 24 Feb 2026 22:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772002391; x=1772607191; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5wc3KJWYApISVQvsGQIs+vU4jAtmVvWzMB+DkB4wxgI=; b=CMGbiwbrl+HK8OdooVhnsMy3kK8z6oLjMjAGCpAKp6vAkuntBtK/g6BJjR4YwB7ReO +r8fahIF50qQP617H32zuSkLjA68y+z5mRxDD0jmtPNeMiy5PzqTXNSbj59wdsAtB59n rPLZBGXPjHEhIEfUaQ+zWmLx/t+KQEism7tnjH9Gv6KNl0iQ29pGvPq0Her/be2brCN/ qb8Pd5+zTAPld9ZLIPAlBOqjzYgV9CHCqGVV0D8W/yLoVoCDncdb0rPrtSj13V9/Pr6s 7Fn8mBdgY6L/xkkHA7XshjOag76p2wGTaKrBrv6wTWdKVQrsjXeDYqHne6vjJ4+CPFbG eo8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772002391; x=1772607191; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5wc3KJWYApISVQvsGQIs+vU4jAtmVvWzMB+DkB4wxgI=; b=o2PBA318jsx/mGeZidtEZ7Mt4VpAUwlv4eJpYnCMCyiRcR24k+DpKA7qWnKK/9w7Uc ogy5dO3qiCsvS2gX2hVfkCuh5N8FEXIpRnjKheEKB+DxxZLvqIzFufZvenrY3t6lxF4d HFW9PojoRty35KSCWYz8/MFWnxBG9v7VG8/7fsw28J+We6ociishq2a3dkRj/cuO3/oY uFwNtcWMO4fEj4nNrt57HzqWvcUrvSgubUjxGY8Ahx+B+uZUn82N/wkWyjMPo1egC1i6 BNeG77DENxVpMlv1+WeHzxFwwzALB1qbs6dqghYt35euH7BR54SLotpRYKPDgy9S793K Xubg== X-Forwarded-Encrypted: i=1; AJvYcCVyOR7xCxihTxpZXweKg/UGnYywCBCdvNpmlLCA+fu1SJ/qTsYkMLlUwIjXB0aAyXsB82r1ISJLpSkIGLk=@vger.kernel.org X-Gm-Message-State: AOJu0YzccCib0Ov9Ty9vT6YsQ8M1Kh5EypFmuL+tWd3FdcpQkW0Znb0M 2DnAVnBzkND4eEnFpPfV4r28yNAph9mPTQt+b/LhTocxrdVe5qYpgig/HWh8I9bJmFw= X-Gm-Gg: ATEYQzzZy8QMOU8K+KyWzyDDXcCXDUbXERKq0VdE8t5jH7g57LAWpqoMwi233eIvcos KzgDjRxudT8xgu+6txeI9BkbNZAgkrEgyHI9Y9kdMUcPf2B/dN6pDpFXfuXS1Yep5u95aMdBYTT 8io+bmakEJGqRXWRmavVD0QEOObi6hbKOd5ilMYhInbO9eNSZaUM11rdMeqFMP0s/g5yyjVuW6B uWrjMD4lD0dKcNDoUDfJDcHuLCsKQGFEMPINzjhg89O+/AawNpz+AiTV6wIHq4auTGIXNtSlrMW cqY77xgtERSa8RyhJxxT6Iy5hTXCLLk+hBG6QnHzLhDzm9EziBEfGUq/8xwY9ti0i1TfpUvOYDv yEmu+E4pIxzj0FUkFB0y/6PhyJDwnXmDD3teoE1kUeQIQyn4eDWBzJmhV7MDg4C73SXp7gDkaUF qYVgX39GGpHA6UQju2knMCjhochHFn X-Received: by 2002:a05:600c:8b88:b0:479:35e7:a0e3 with SMTP id 5b1f17b1804b1-483a963d64bmr217228425e9.30.1772002391289; Tue, 24 Feb 2026 22:53:11 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43986aa2f84sm9319188f8f.7.2026.02.24.22.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:53:10 -0800 (PST) Date: Wed, 25 Feb 2026 09:53:07 +0300 From: Dan Carpenter To: luka.gejak@linux.dev Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/21] staging: rtl8723bs: core: fix line lengths in rtw_wlan_util.c Message-ID: References: <20260224132748.12336-1-luka.gejak@linux.dev> <20260224132748.12336-8-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224132748.12336-8-luka.gejak@linux.dev> On Tue, Feb 24, 2026 at 02:27:34PM +0100, luka.gejak@linux.dev wrote: > @@ -380,10 +383,14 @@ int is_client_associated_to_ap(struct adapter *padapter) > pmlmeext = &padapter->mlmeextpriv; > pmlmeinfo = &(pmlmeext->mlmext_info); > > - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)) > - return true; > - else > - return _FAIL; > + { > + bool assoc_ok = pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS; > + bool is_station = (pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE; > + > + if (assoc_ok && is_station) > + return true; > + } > + return _FAIL; > } Wait, what? Please, don't introduce random new curly brace blocks. This patch does it several times. > @@ -466,7 +477,7 @@ void _write_cam(struct adapter *padapter, u8 entry, u16 ctrl, u8 *mac, u8 *key) > void _clear_cam_entry(struct adapter *padapter, u8 entry) > { > unsigned char null_sta[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; > - unsigned char null_key[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; > + unsigned char null_key[16] = {0}; > Better to do this kind of thing as a separate patch so you can change null_sta as well. Otherwise it looks weird. u8 null_sta[6] = {}; u8 null_key[16] = {}; Except I bet there are defines you could use instead of 6 and 16. regards, dan carpenter