From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E4A72FD673 for ; Wed, 25 Feb 2026 11:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772018292; cv=none; b=UT2VvQHf6EA2CapsSZOYcm0n5LdYFBUvg/8NQUmnKXqBjwxm/0cnUR3+LctyZghkeiUkAKM8xGPcgQMZph5bO+qmQDsQzgcZk2rIr/fhzkW59TijXC6d69OQeTUB7BftsiT7aOT+AlA4AAJ7IXoTTTc+1Vh5jXK1f0lQMUSHLcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772018292; c=relaxed/simple; bh=mCw3graGJESi6OWWsp54IpWjiXBaot/He/w+FaZf6ms=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=psSbnKzXtrrOLJPNW7slV7Yl0R/6wY4b0RGPU5yKQdItlxdgH1kCaMh/EomU/kAygROWFLAurKCABkzW9aqlaVOJuuohJ0GKZnvMA04U78hrOVzOpgKWOoCXhZMYzUAqCOGNDMVDzPjdadyvINoblFFu03aKyjBlXRoxhJDxhV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ouhzLzhT; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ouhzLzhT" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43767807da6so4817591f8f.2 for ; Wed, 25 Feb 2026 03:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772018290; x=1772623090; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CSSpSxGGCKDVKlBKqXysRzcuCfnzWwXAef5nbWIuSUw=; b=ouhzLzhTyU5hCl1LzKzvecQMzMNXqYoY9eD465szXJD1jVHrf+tRj/YFA5gVzJkdFA MDVduLn2Qsv3545ZHJKm0CyFe01/xHinemdUJSWTJNtsNYpGenH/xPUJxJ+Jq77OlPfG 4FxcuofCKkQ5KOS5wCthSgkK8OVgQvLzi35EGZ3vAB9ySkiYBeISlEpfx1CLA8M9Oejg LsZexuph6h2kAJ1Cxhe6oim94gY/tTH0yybafMCfn5Zgm+5cV6H1jFpuOCtvF01gdeIM 7MqdghCkPYsZvVXlYNDmZH/2ZeA/D85Uwb16Vjd5e/LYmjq673yb2escupaHBP/c5KPb cGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772018290; x=1772623090; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CSSpSxGGCKDVKlBKqXysRzcuCfnzWwXAef5nbWIuSUw=; b=a5SvtLtzimBl8XvBw4bQ15Ftc0AzgRS24dUj62ADAKsWu0wCgM9EXxjwmqDJbOrTaH B99SFMkd8/r3IYnmmHy3kLJvKfQaeiNTc3RoWZ0pi+ibPS0/j76JwVe7MaWidGVyWTYP QoA6lAcl5AkRoendmZlfzgNlkFmy22y5iuMdyAJjNSiEJnnnOyIHy5oVYuwQPwVVBC23 0qSQ3KWhpeOWVCk2lch86VoBviiRB9w7KsnqN6jc3sopd3g9S0pDvR394/fH/vaY/6la smTpBVEGrursok0+Wb82E3wypOC387QLF0Kzu+N567Q9pvPgo2nxiIWOqdBWlH+NjTDP Tx9g== X-Forwarded-Encrypted: i=1; AJvYcCV39WyH2pyTfqY1kMq82/Pk4aAO1GMibN+zN4S0kITanwTMKP6UAM+YjF2MhWb3cN6snRDnHMEJdM0my4s=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6hk6tVvg7cjWJxrkL4s7H0+uamB8s/uVvxz1n5IyPhAK+h+jH iLqW+EsHdTRhzTdfZUNcZpLAW1THq5EprxoWUbQWx/K6ErdEMvrr3Jl1+xegxshRQSs= X-Gm-Gg: ATEYQzyAp/4lx1GjlN+8vwOUqfWJeRFxhD22Qzcbjye1ue+DBJ+7hG252dWQMSGgQIl Oxc4m5CptBEAjM03puTK1+RG/gHVIz0Yu+eJ4rl43caGbOGP2DNOLrIBQ5XivAvr+Dk7wp23inN 9JnO2oqcqSASH6dmlMAiKNqaB5EkbmnP/sjzkBQOMxYqcmOwEPDudYF7U+30/0zTVF1TnLiLDrU /rIhvMHIqr6eHwQ9emgDlpIys9v0ScvWNC1gKaeBmwoi44+yy7ephUlllzlr5xQM2PTUTKMe5dR A53N0EbhAvACQiq2tVPz2wwWAyEVthZogthsvJsb7ZvotYXjyvEnkFOKEQjXrSZHt1+7GRoFkAx ubBUXn4jZiTrCxeGqi89oUQVph4BZfupww0aALEQcY4w8jxG3opFGFLrQch7cezCtsPzFLnZxK0 enoXZMWImqaXK0jYiAdMiyPUnV/3I= X-Received: by 2002:a05:6000:1883:b0:430:f463:b6bb with SMTP id ffacd0b85a97d-4396f15ada0mr29637452f8f.16.1772018289877; Wed, 25 Feb 2026 03:18:09 -0800 (PST) Received: from localhost ([41.210.147.106]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d3fc12sm31458496f8f.24.2026.02.25.03.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 03:18:09 -0800 (PST) Date: Wed, 25 Feb 2026 14:18:03 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: camera: add comment for mutex Message-ID: References: <20260225110511.107114-1-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225110511.107114-1-azpijr@gmail.com> On Wed, Feb 25, 2026 at 12:05:06PM +0100, Jose A. Perez de Azpillaga wrote: > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > index 62b55bb28408..a6f3637b8871 100644 > --- a/drivers/staging/greybus/camera.c > +++ b/drivers/staging/greybus/camera.c > @@ -53,7 +53,7 @@ struct gb_camera { > struct gb_connection *data_connection; > u16 data_cport_id; > > - struct mutex mutex; > + struct mutex mutex; /* Protects camera state */ I'm not sure what it means, and looking at how the mutex is used I don't feel it's accurate either. To be honest, I rarely love these lock documentation patches... :/ They're often really vague and sometimes seem like just guessing based on the name. regards, dan carpenter > enum gb_camera_state state; > > struct {