From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE8D3B8BBB for ; Wed, 25 Feb 2026 14:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772028822; cv=none; b=dP+bxBJqxBdVaI9yoa9ymQYQh4l/fpFti+bY3ghkTZ5QtqlUuZCuXO007YN5zsU/YHRu58NuxflC9UfJgjZMACBWDebAwLuEm3ia6p8WY4vSvsSrJIj6O4HAa3L/0WRwsLip7Oq2Qn6fEd+ezNPefe+3zaoZYcUISS2qYJ9Ckmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772028822; c=relaxed/simple; bh=LG18QE/0ffQcKC7vFG9Uv22EsVHPdNeoSes9Kusb8nQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LQAdeiLDJTcb5lYVC0aU6ftalXav5Jdz9OBtEvirVOLSJ0o/30alaVTjkX3Vy0F/Ob01zZrwOpoX4LJJaL8rWYIoz5QPiFUq/NSJ6JOg2foPKlvty6qRaWugwSVVzcfH0i/8SjufFQ1Leuxz70afq4OWSxInNquSkdwt0qwGlJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=R3E1ZrUX; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="R3E1ZrUX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gS6jXWPt4Zdu93IKPbSBVkFYOsRbvWw6AnriGigF+4o=; b=R3E1ZrUXqH0fZ5QB5RGjxTCzZ7 No3sDUAz9zaDUpNb9xDgo/k0oPlxOWkXnZu7bZVTvyMHyxjqDr6Kwfsx2z+8dXfB+ul8tKYz1eANC lDQdQPBBZxOFVWoZGMZOVrNww1zKNGkAlmgVdH6/tHt18fY0hZqvzGmZlVLic5NapYcA2xE0mDeJM 2j3lBpbNd/ZgC+pj3ephDo12EtRiVValqjg+Pd6hPaLdHJdn9FKpXTYOwZaD8kTYa/EvIe8QuegaM lpQzSpetHU4xCQ11XGIIojsJ9F0JeRf/8SyQl/J6U3D8W2Q6/jYcxERZ/RtxvKWdUAxIkBgnCN0i3 tILhXusA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvFdu-000000019ru-2krx; Wed, 25 Feb 2026 14:13:34 +0000 Date: Wed, 25 Feb 2026 14:13:34 +0000 From: Matthew Wilcox To: Jiayuan Chen Cc: linux-mm@kvack.org, Jiayuan Chen , syzbot+006987d1be3586e13555@syzkaller.appspotmail.com, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] radix-tree: fix memory leak of intermediate nodes on insert failure Message-ID: References: <20260225071623.41275-1-jiayuan.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225071623.41275-1-jiayuan.chen@linux.dev> On Wed, Feb 25, 2026 at 03:16:18PM +0800, Jiayuan Chen wrote: > Fix this directly in __radix_tree_create() by tracking the first newly > linked slot. On allocation failure, sever the partial path with > rcu_assign_pointer() and free the orphaned nodes via call_rcu() to > maintain RCU safety for concurrent readers. I'm not interested in fixing this. Migrate qrtr to use XArray.