From: "Michal Suchánek" <msuchanek@suse.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "Josh Poimboeuf" <jpoimboe@kernel.org>,
linux-kbuild@vger.kernel.org, "Nicolas Schier" <nsc@kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Tamir Duberstein" <tamird@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, "Jiri Slaby" <jslaby@suse.cz>
Subject: Re: [PATCH] kbuild: only clean objtool on mrproper
Date: Wed, 25 Feb 2026 21:23:09 +0100 [thread overview]
Message-ID: <aZ9aLWIAzsWfYNyf@kitsune.suse.cz> (raw)
In-Reply-To: <20260225200417.GE2755225@ax162>
On Wed, Feb 25, 2026 at 01:04:17PM -0700, Nathan Chancellor wrote:
> On Wed, Feb 25, 2026 at 12:26:29PM +0100, Michal Suchanek wrote:
> > For packaging purposes I want to be able to grab the tool binaries
> > without the .o files
> >
> > Fixes: 68b4fe32d737 ("kbuild: Add objtool to top-level clean target")
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
>
> Wouldn't resolve_btfids need the same treatment?
No, make clean runs the clean target for resolve_btfids but the tool
remains.
> Why is objtool special here?
That's what I would like to know as well.
> Also, what's the use case? Running 'make clean' then copying what
> is left?
Yes, that's what my build script has been doing for at least a decade,
possibly mutiple decades when it was somebody else's build script.
Thanks
Michal
> Josh, thoughts on this change?
>
> > ---
> > Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index e944c6e71e81..e9b8811a02f5 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1675,7 +1675,7 @@ vmlinuxclean:
> > $(Q)$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean
> > $(Q)$(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) clean)
> >
> > -clean: archclean vmlinuxclean resolve_btfids_clean objtool_clean
> > +clean: archclean vmlinuxclean resolve_btfids_clean
> >
> > # mrproper - Delete all generated files, including .config
> > #
> > @@ -1686,7 +1686,7 @@ PHONY += $(mrproper-dirs) mrproper
> > $(mrproper-dirs):
> > $(Q)$(MAKE) $(clean)=$(patsubst _mrproper_%,%,$@)
> >
> > -mrproper: clean $(mrproper-dirs)
> > +mrproper: clean objtool_clean $(mrproper-dirs)
> > $(call cmd,rmfiles)
> > @find . $(RCS_FIND_IGNORE) \
> > \( -name '*.rmeta' \) \
> > --
> > 2.51.0
> >
next prev parent reply other threads:[~2026-02-25 20:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 11:26 Michal Suchanek
2026-02-25 20:04 ` Nathan Chancellor
2026-02-25 20:23 ` Michal Suchánek [this message]
2026-02-25 20:37 ` Josh Poimboeuf
2026-03-03 16:22 ` Michal Suchánek
2026-02-25 21:21 ` Nathan Chancellor
2026-02-28 5:53 ` Nathan Chancellor
2026-03-03 16:27 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ9aLWIAzsWfYNyf@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=jpoimboe@kernel.org \
--cc=jslaby@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tamird@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®