From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0746D21770A for ; Wed, 25 Feb 2026 20:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772052486; cv=none; b=DhthriJDTe5eRFdhnWyBzvkRCTbBKGiz8VF8DYzdYe7+m8Gc0zT0J0QQOQ3K7BqSmiDg0Lmi7AE2ZAAUPNk9e4EBT//pz5b9lp4SFCjWu1kEwZqlD8jNViHO086BiwKVzqmJXrd5LmLeWRTWnaTcINwZJQfYugAcOVf9IOjPXIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772052486; c=relaxed/simple; bh=B5/EZkmwLgUMvrBh1PtZ9Q6lfinat+yRr5NIIILMWA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WO/CzVmX4aCP4s5mvVg/un1+UuAdO8UzMAgf0/phe+wLY3PCjvGEt/uQLtUuLK3UoieAr/xo7IqLqINxPOHTjIKvHvQdwudUuIISWQEn5jdmdsuIa4qPB8ChIpJeCLp8Zy51rQsNfs7elyqb2A6cj/YWVkK+1YyuVEy1l73TIEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ot0Ickdq; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ot0Ickdq" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aM6FDbg6Q9fW+D7QpYpZccIUNQZL6CJ90Cl2TVv1hiA=; b=ot0Ickdq0H2zv7aRjB/u/PphPW kaPoVp5JcdZD3mdGJhHgoQ5DbBgWdYqOc3zzVxpv4FuUQyk8yHVOy5RN5jkefUpKv/bdGODnpX3Xg JFKKeORG2jv0jzxg1H2FUo3cSeAxXza7mJLGa5TflOUMm79jb2fC5nAHK1jhXdahQ3V/ALWNMTr7I 7Y1IlKzDEHnGBuMTZWRvbRFEAFJucmCEnKxZdPFK/tUYl+EHmhIbzKVtlKDy8MpAIa9jR06sYaWtv uKNYM8bzdFeCL64H4V0QvofQ3isHhc/5DY41LfYSwP53UYkrGovQFwyouDu6YWHOuZsuQceHFgTe9 ZuuAULaQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvLnD-00000001dMS-29rp; Wed, 25 Feb 2026 20:47:35 +0000 Date: Wed, 25 Feb 2026 20:47:35 +0000 From: Matthew Wilcox To: Tal Zussman Cc: David Howells , Marc Dionne , Jaegeuk Kim , Chao Yu , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: Re: [PATCH] mm: Remove stray references to struct pagevec Message-ID: References: <20260225-pagevec_cleanup-v1-1-38e2246363d2@columbia.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225-pagevec_cleanup-v1-1-38e2246363d2@columbia.edu> On Wed, Feb 25, 2026 at 12:57:16PM -0500, Tal Zussman wrote: > struct pagevec was removed in commit 1e0877d58b1e ("mm: remove struct > pagevec"). Remove remaining forward declarations and change > __folio_batch_release()'s declaration to match its definition. > > Signed-off-by: Tal Zussman Reviewed-by: Matthew Wilcox (Oracle) > --- > Happy to rename PAGEVEC_SIZE and pagevec.h if desired too, but that'd be > ~65 more lines of churn... Although it looks like there are plenty of .c > files that include it for no reason, so could be a good opportunity to > remove those. Yes, there's lots of cleanup work here that I didn't get around to! Thanks for taking on this much, and any more work you want to do in this area will be lovely.