From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A39930E0D4; Sat, 14 Feb 2026 18:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771093197; cv=none; b=Lq3GE1rEBJasZCCp+fJ2lo0GBKhVmYKdvStx7UEv9kqros2GeGtg57Pvvq2yzuKU/WpnVr1roHalWSfpKb3vUYt8pYwADmNmYDJSlvvzhOD1eJRhbZjxKmw9u7OMahXWRhtkw7w4Nt/e8c5lsBC/LHVzDWsuLlYpjNVcPdY199o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771093197; c=relaxed/simple; bh=nlwN7W8dolZXiM1dLKVSUHD6gpvA8g94SZA3JIWgiZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=egPBhpyIUP/GTPqJwv2xeRgyMeEXualns1DI6oeq2Yx5ExvGf7Oo+N5YhCHTGiiT3PoIroEceXW8SSRc85Mth8yh9otgQ7FvZaGtZhSNZqS1gryBAgK69nNMJqaPqVEDAMHEhF2Mteu6I230iKcCDbfxC0VTSq9rMcmMI+mXCS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YRKAU7OS; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YRKAU7OS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771093196; x=1802629196; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nlwN7W8dolZXiM1dLKVSUHD6gpvA8g94SZA3JIWgiZ8=; b=YRKAU7OSxq4hD/tVb+WsKxgH85GohWn4s/bxT6i1sZz/eY3DdcGBWvKx zqzSDJitqRVcW2qYvhNg8tKZ4tO5l409wosVCu5EAHUDyoE6CC61Kilo3 sOAYTi+FkEeTG2NMHYrp8iR+nUzseE+iRzPHri5RpKyMnMGErJHNFkrBw yQmCM+yxs0Zp4vwJyrprRw3oxihzFffBplOeOC7BVIk+hPkSfPtz4iSEl IGisHvPML7uDRFv/WuMdsq1AgIR57ERdUqmZMe5TqN6ZuOaM8qzgn3vsv HBmPdZ0yBitPSgyDGEb+2zE4d7d1E/ONHtn9CC3ZVtEZdkumWzUVcUYFH g==; X-CSE-ConnectionGUID: XmOW+ZrQRnqMpl7W7iufYg== X-CSE-MsgGUID: ZA5/ulyERAigdI4hbTDwdw== X-IronPort-AV: E=McAfee;i="6800,10657,11701"; a="94878487" X-IronPort-AV: E=Sophos;i="6.21,291,1763452800"; d="scan'208";a="94878487" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2026 10:19:56 -0800 X-CSE-ConnectionGUID: LoQrdODdQXWDU0d8Un8Jcw== X-CSE-MsgGUID: 1Gh/ErF/S8aT7PiEZNxCLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,291,1763452800"; d="scan'208";a="218179931" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.136]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2026 10:19:52 -0800 Date: Sat, 14 Feb 2026 20:19:50 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: 434779359@qq.com, David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , liufulin , Waqar Hameed , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers Message-ID: References: <20260207134950.0f064905@jic23-huawei> <20260214162526.01e1e336@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260214162526.01e1e336@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Feb 14, 2026 at 04:25:26PM +0000, Jonathan Cameron wrote: > On Sun, 8 Feb 2026 15:13:23 +0200 > Andy Shevchenko wrote: > > On Sat, Feb 07, 2026 at 01:49:50PM +0000, Jonathan Cameron wrote: > > > On Sat, 7 Feb 2026 17:42:35 +0800 > > > 434779359@qq.com wrote: ... > > Yeah, this is even barely satisfies requirement to put into staging/iio. > > Just to cut off any chance of wrong interpretation: We don't put new devices > through staging/iio any more. There is little reason to do so now that the core > is out of there and mass refactors and ABI changes are a thing of the distant > past. > > Now it's much swifter to clean a driver up on list. > > Maybe there is a reason we might consider drivers/staging again for IIO > device drivers, but I've not thought of it yet! Depends on the quality of the driver and eagerness to have it in the kernel. > > It has so-o-o many style issues and other small things (I just pressed PgDn > > several times within 5 seconds). You need to take your time and invest into: > > - creating an upstream plan (roadmap) > > - as Jonathan said, start with a minimalistic setup (not more than a couple of > > thousands of LoCs > > - be sure the style follows the Coding Style and IIO subsystem specifics > > - be sure the code uses modern APIs from kernel and not some outdated stuff -- With Best Regards, Andy Shevchenko