From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0656821E098 for ; Mon, 16 Feb 2026 06:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771221978; cv=none; b=s0HE+TishxmM/IwOChaZAKD3UlNmrcHvuOMMGsvQMIvKT59E8N1skggfniKZhIP9goGgnC9LUVcnFqC8QvBX7WoX/kUHM7TWjmQSCiQts0nwGTbSmsDRfPgtBcNjRay2oM52DWMa1O3vKWGjfoCWvBpvvXalDexispLfZfRYIW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771221978; c=relaxed/simple; bh=4YmefSX0GwRR0tYsar7+DiwN/P8tBU7V/nz8QCE6CBE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pUjmpqF0cokuK4a4GzEPZklwPCjgg+kwfA6l7k68KwqFKW8fWjDGT1OmG8nWXcyShJKDV5DIYyQEHXr6HOEp0kEIVksS4XSbnnKzs6K+shkjQ/EvuqsG6DewAbEPa8tu9PbiMqfNlx8huHvwkTGXjLVe3tvbXwN8gxR8NL3fIH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WOyCHyyi; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WOyCHyyi" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2aaf9191da3so19023105ad.2 for ; Sun, 15 Feb 2026 22:06:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771221976; x=1771826776; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+1+2hICCHy9jpCc/dQXjjfX/dwmXFH+Uwwb20tfSQEQ=; b=WOyCHyyiuBQim8CjPJTuOULXbDHyKLR+v4PmezkoeeYzB4nYzJU4XthXIEnuVnV6YR 2HMDk4fn5/GNiXoQDVdY+dsJR32T0tCd4nnRTUTZGapaj1Wbe6+5ujZkgnb96KtPead1 5uSZuU5rJJ6PQIYqgIRwMSYGpflsE10LcIg/Wn8vvvgGFE8SsoMJiDI4aBibZYUup1Ju JEnBz82Bt9QYEZF+tE8csICogr6Mfe8zhFWDLiezBKdDVl/MHE6PPgs94KWs+lELuKrQ 8mneu6JOqBiuu2rgevfBinzsCgKIFajpIRpYm3lQKGrPX91FAf3IKJW7fLKf1DXtAATH XJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771221976; x=1771826776; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+1+2hICCHy9jpCc/dQXjjfX/dwmXFH+Uwwb20tfSQEQ=; b=IPi09c8JVnhbBLZ5ZXrRtvcnBtDQVy6kju1u5InigVYlhJDySe/DCcOMnGx2u7ONGT W0HF4lbmz97XGEJxaQGGrKovSQpSdRUyezEG+WFuTI5914+//x3hNfoehktrBW7FfAQh O6Kgzid2zBvXXI02ziIjU1anfe1AqiVo7vt8nJTZfBmfj2LcusYGr+D65+uwos8zu0jD RjM3v42BEtYeGIO0rj3nO1PLLv2TNYUusf4Uxo7zeAvYJFem1nivfBxj7kySTX4EtBpX ceiKf4iXVXg3hlDEFf7KAILvkkmB16tdNSVxwk3wnL5tdOsLQ21pcaw6T5Fp9ntuSyhR I05w== X-Forwarded-Encrypted: i=1; AJvYcCXt0nFPH8jsMq0LYrggfULCdUDjx/QpGQkmsuOGjyPoW58GGceEiIRcRnRobjRvSCdgANDefcyo9uxUgI4=@vger.kernel.org X-Gm-Message-State: AOJu0YzL2NUhf+fBsMjCCxbl0b5gTM8geSNHI2kJb1T/COUNgrbMLW5t jR2292mFU+dzW3F+2fERwTm0iovYBSCJmS3dBqPlW7cNROshQmbMAk+W7DTdJnSLv7w= X-Gm-Gg: AZuq6aJ1hWy5FlrsWnfbpTu+N7YNiggPUuzQbWPwhV9RiGr1FI/luCJA43E8oQUepwS d8HNo4CU2IwNxGvgx8W78btTakV1laiWAyTNMBu2kHsmjpelnGQ1M5nNTws40IHg66XXHT4+VPr UaXNNnOapBluCXn+f0kbFZxXqHwHlEMaHVpJt5ZgAnbHcIzRT+sbJnhsdCKOu6fjXhyB2vUCS0F cw0IyB7sCAOK75L2Z6/NzvKkr70Pf0WsKCkFeqN6FwphxotyyBbEYFAsGrX/QjSt0qyenco2Yb9 dwliR9z3A6xVjkAgYBeBJzKriR+sifyKixuR9FCoCVzWjVB/wn04fafNDUMLPzU4yAvrmhgA28Z RIL3eGY/YG1U5vRd60x/RFJ8uNj0tbkV68pFsVWx+tX02inTJJ88nMNuBbefVKSAzvkHNBKjYki YMQEn7IqR/2Wv8md1iCF6i4HDfYtm9zzyfzjesAk3ho2//zQfKE0vQzeUgu13zTukDeDUxSQ== X-Received: by 2002:a17:903:247:b0:2a9:634d:de98 with SMTP id d9443c01a7336-2ab5055e59dmr101213855ad.23.1771221976325; Sun, 15 Feb 2026 22:06:16 -0800 (PST) Received: from KASONG-MC4 ([101.32.222.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1aadd47csm57750265ad.65.2026.02.15.22.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Feb 2026 22:06:15 -0800 (PST) Date: Mon, 16 Feb 2026 14:06:09 +0800 From: Kairui Song To: Barry Song <21cnbao@gmail.com> Cc: kasong@tencent.com, linux-mm@kvack.org, Andrew Morton , Chris Li , Kemeng Shi , Nhat Pham , Baoquan He , Carsten Grohmann , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, "open list:SUSPEND TO RAM" , Carsten Grohmann , stable@vger.kernel.org Subject: Re: [PATCH v3 1/3] mm, swap: speed up hibernation allocation and writeout Message-ID: References: <20260216-hibernate-perf-v3-0-74e025091145@tencent.com> <20260216-hibernate-perf-v3-1-74e025091145@tencent.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 16, 2026 at 04:43:40AM +0800, Barry Song wrote: > > @@ -1937,11 +1938,21 @@ swp_entry_t swap_alloc_hibernation_slot(int type) > > if (get_swap_device_info(si)) { > > if (si->flags & SWP_WRITEOK) { > > /* > > - * Grab the local lock to be compliant > > - * with swap table allocation. > > + * Try the local cluster first if it matches the device. If > > + * not, try grab a new cluster and override local cluster. > > */ > > local_lock(&percpu_swap_cluster.lock); > > - offset = cluster_alloc_swap_entry(si, NULL); > > + pcp_si = this_cpu_read(percpu_swap_cluster.si[0]); > > + pcp_offset = this_cpu_read(percpu_swap_cluster.offset[0]); > > + if (pcp_si == si && pcp_offset) { > > + ci = swap_cluster_lock(si, pcp_offset); > > + if (cluster_is_usable(ci, 0)) > > + offset = alloc_swap_scan_cluster(si, ci, NULL, pcp_offset); > > + else > > + swap_cluster_unlock(ci); > > + } > > + if (!offset) > > I assume you mean SWAP_ENTRY_INVALID? Would that be more readable? Yes, it's very common in swapfile.c to check !offset since SWAP_ENTRY_INVALID is zero. But I agree checking SWAP_ENTRY_INVALID is more readable and maintainable, I'll change to SWAP_ENTRY_INVALID, also use this macro more in further codes. Thanks!