From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 555462475E3; Mon, 16 Feb 2026 08:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771230041; cv=none; b=k4qK7MnO3vViKrj1VDshD0hcREUEl2AWJ31XXRvGtfSlSRyf2tiBpSnUk+fawwmNErq/cSGbTKB+gytxVi+Aox2l+dvd5oUWQ0Yf4m0uPQiNf3QX9uh9iMLdxfrBy4nYzBEXA+rHOMWgFHY0lDjt4CtWnF1mpYPPMiF9wobBJTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771230041; c=relaxed/simple; bh=PMzp/FOnba2760nShKInNwyy7x93fS/lLvddNbsfwus=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Id2iJ/zdH1JLyabHLPf/9VOkhbahcf01ILJrQqE0Bs4yWlmclSmADTOWJWmA8bfr7VEnUqeNc9ExGnd3yHWiafcrR3JnZ36HzwXzar5BeNbDVS+uebBm9KFQw9aBPnaQCgJAjMwGn8MbsvWamhAAalGbHXtLO5q3KDgxahVvJEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EPX3C6tK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EPX3C6tK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDEC1C116C6; Mon, 16 Feb 2026 08:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771230040; bh=PMzp/FOnba2760nShKInNwyy7x93fS/lLvddNbsfwus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EPX3C6tKXkaQUC5MoArURTewyLAqcdiudV+SrWFZDMY2pVVnE6kFG++UmskL5I9es HfW/fhNrRa8ZD0+vFGuOYzDwZ/ZYcA9c8cjXx5IKt2KtPkOCBWvXKCAU+y4KGRrIxf WZ4AZt3utJGB1CTXwAoYA917/ra/645qN8a3rm6j/ZUy/L0d51XxL0lwhqjts5iZdp XQSBmHK6CeS3U84X7kFHt4OzgXhRyExhLSl/KeNalQEQTrifbZxbJwUF5VKMYbSCp7 WzaVAzQD83ZbJvBZ5V2wIBgL86mMnQEknI5k50zyqdtnoXxZQ3lBZXYiX+WaE7wACj b5pzLwe+8tgpg== Received: from johan by rho.lan with local (Exim 4.98.2) (envelope-from ) id 1vrtqO-000000004Z1-2GG0; Mon, 16 Feb 2026 09:20:36 +0100 Date: Mon, 16 Feb 2026 09:20:36 +0100 From: Johan Hovold To: Krzysztof Kozlowski Cc: Maximilian Luz , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] firmware: qcom: uefisecapp: Annotate acquiring locks for sparse Message-ID: References: <20260215110548.34152-4-krzysztof.kozlowski@oss.qualcomm.com> <20260215110548.34152-5-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 16, 2026 at 09:14:13AM +0100, Krzysztof Kozlowski wrote: > On 16/02/2026 09:00, Johan Hovold wrote: > > On Sun, Feb 15, 2026 at 12:05:50PM +0100, Krzysztof Kozlowski wrote: > >> qcuefi_acquire() and qcuefi_release() end with mutex locked or unlocked > >> respectively, so annotate them so the lock usage will be tracked by > >> sparse. > > The mutex implementation does not use sparse annotation so this actually > > introduces sparse warnings (unless something changed very recently). > > > > See > > > > https://lore.kernel.org/all/ZJ11H8btBhvCx9gD@hovoldconsulting.com/ > > > > for what his looks like for the code in question. > > I checked with sparse and there were no warnings. More importantly, > mutex uses __acquires, so this apparently changed: > > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mutex.h#n214 Thanks for checking. This is apparently about to change for v7.0-rc1: 370f0a345a70 ("locking/mutex: Support Clang's context analysis") Johan