From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
"Peter Tyser" <ptyser@xes-inc.com>, "Lee Jones" <lee@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: lpc_ich: expose the GPIO controller cell's software node
Date: Mon, 16 Feb 2026 11:17:56 +0200 [thread overview]
Message-ID: <aZLgxEZzn_USmlkE@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=Md5sPd=20=mM7H3qM8TQm0kqjoRnKdnBipjY7nbWu8Xpw@mail.gmail.com>
On Mon, Feb 16, 2026 at 09:51:18AM +0100, Bartosz Golaszewski wrote:
> On Fri, Feb 13, 2026 at 10:16 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Feb 13, 2026 at 09:25:24AM +0100, Bartosz Golaszewski wrote:
...
> > > +const struct software_node lpc_ich_gpio_swnode = {
> > > + .name = "gpio_ich",
> > > +};
> > > +EXPORT_SYMBOL(lpc_ich_gpio_swnode);
> >
> > Can we export in a dedicated namespace? Perhaps "LPC_ICH"?
>
> I can't test it so I would prefer to reduce the amount of runtime risk
> introduced by this change. We can do it separately later.
I didn't get this, In this patch you use _NS (And in any case this should be _GPL).
In the other you need to add MODULE_IMPORT_NS(). There is nothing which needs a HW
to test.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-16 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 8:25 [PATCH 0/2] platform/x86: meraki-mx100: create and use real software node links Bartosz Golaszewski
2026-02-13 8:25 ` [PATCH 1/2] mfd: lpc_ich: expose the GPIO controller cell's software node Bartosz Golaszewski
2026-02-13 9:16 ` Andy Shevchenko
2026-02-16 8:51 ` Bartosz Golaszewski
2026-02-16 9:17 ` Andy Shevchenko [this message]
2026-02-16 10:15 ` Bartosz Golaszewski
2026-02-17 7:56 ` Andy Shevchenko
2026-02-13 8:25 ` [PATCH 2/2] platform/x86: meraki-mx100: use real software node references Bartosz Golaszewski
2026-02-13 9:19 ` [PATCH 0/2] platform/x86: meraki-mx100: create and use real software node links Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZLgxEZzn_USmlkE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome