From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42D40255F2D for ; Mon, 16 Feb 2026 12:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771243825; cv=none; b=oiiL79jG3nbe94rTN1nE5+EnNBZ5OwWIjXheZsoSoomhIKCaj/D5yXbBAdquX6QTTK2kyqoAEOZ04K7etVQDe9DdBNrh6kB2IyMlQ5mu7J//R/qdUCiJrekx0ARMVZeSKDetfBEX2mYW6evrX3dIFjmX3iO1pytFBzwX0OVqXQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771243825; c=relaxed/simple; bh=6SSKXQexS1yqS8sN26FO83aeNAo9obWv36BeneynOeM=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NuGMkAvsKc6/Xrb+dJ9a4JUMvOR3Es3mCIlv8a4VxpWHdW3XltWpKnu1L1onom0p4QbSPbBUmQ+A9QiV1N9x32iKfkezQOzkXcSsOFrrn4AgPZujfjc9ITpdJScrUj7vpsZQneHW+OrQAKzPwkPZ0/7z/do5dJpkCBWD5yfksP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=devZmknZ; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="devZmknZ" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c633984fbeeso1884550a12.0 for ; Mon, 16 Feb 2026 04:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771243823; x=1771848623; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1GvC/7lwViA/LhXh3QnEjql7Fe/Y/aDrac39++6dSLQ=; b=devZmknZ1jORQPbCqqhXRpCsH7wN2l3Ce2NSjVfiGqAUCuNbZ4ZlNM01aUtBuA3oX3 qJLTBuCkBu1OJlj6TF3VmKeRhYQJ/Guf/HcLKTqGBCtnX35ur6GWLIM67RO3V2XyhkQd M3t+oDNIJN5dbtD+MEuoOOq0DnpNSnyULBlsssXdlSlu9lf+2GpTAIRWmk8AQms3A4zD C5Ru2BTVmkHr06+8S8NPjOWdAfU3jMNkZFGRp+ggosjJbXjdK1StxPDMBjp+YgetN2zl s1oENgOohct0tYLQIwPi9iVZsA9bhnkG7N5BvPjKyC0PySpT3an+al0pjdT/E1st0lwb WJIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771243823; x=1771848623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1GvC/7lwViA/LhXh3QnEjql7Fe/Y/aDrac39++6dSLQ=; b=lOitL9Zq9OF2CiVOOchlzt2TM74CqLfA9vPc3DfWuUxulDxiDbKqenWeqS6P0GCHLE kGnaFvJkk09epiRoM3QUGgIzHrDocPOg7mIrC6jLLSfSZ9DaQGzlsMBkCrv0ypvDCMG9 UZ4aci7/i91KEgd9yA0P5now4K0f7z0EU0At2te3vrKQWi7DkZT+nDSTas+jirANWJzF BFG/PuKGobbfhaCcsqP4T1hsyRD3Hw1Ktar5PolYQvghY1Ju09+QiskR6AsZ9N5OxPv1 TKo5Vwn7qE+z8IxqX61++3jPcHdYoegD0RYWD1yxMi8WfPBSqvnfHvDnAZREqS4uK8fo Y28Q== X-Forwarded-Encrypted: i=1; AJvYcCXT8Rl8ru8k9KD90ACVpSOcFqcL/ruUmPV0T+a37hCKJsOA9Kars/ZnPRRDEfp8W2exU1x2g7KMJ5F0PEk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp0xtofGc6y9JmaMQdXIXEiureC/83+O7pnwbhbqah8q3jnfOX nyA975hLtmid0nNt7HaXmtcvwuG/fiVzhzq7oipozi0AUrdctOJdhL05 X-Gm-Gg: AZuq6aIuZzPH4nBTpbHSGZm4/oCFHrPQGMrOveQT+8YKJyIZDVScTVXIFVX2snUGA0e wF8lJU2pwEr88HH74aklMJpapwDyGRggmU/C28G8MbH8g07I9J6ub9cBsGQOOMMMOoJbt4ugvwu EX8pyQn7B8e0oYKieJpTeldk0gtgr+grMxfiYS0F2oqRoxG99WANIKKUzk6wtsCrPlT5/AZl2bT W5dqHvACemZMzSH4+p1GtXeP9jOnhjn/0cYI/Qj7+xOH92b9fA+6UvUf/pCrgQDSRjN9P4L4LuY RNvcDqdsSKb46c77G6yMJNqXLoz1UopriSM1OtIvPhpUPi6LAwT0opZNzftsPOIVJSIjlo2UJLc alsgiSuUj+hyb1fbiEbl0+bfWf49IvrWUsUeK2amlsamxwRz32v1B5sEQgqTkZrEMm1D6ltZTB6 4ALYHCU7MsHoPmIzy5XwnLlxBhlj7PqNP8EdVjASw= X-Received: by 2002:a17:90b:53cf:b0:354:7e46:4a8e with SMTP id 98e67ed59e1d1-357b50e2d6dmr7124766a91.7.1771243823383; Mon, 16 Feb 2026 04:10:23 -0800 (PST) Received: from chandna.localdomain ([106.222.234.211]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-356a69ac09asm5573331a91.0.2026.02.16.04.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 04:10:22 -0800 (PST) Date: Mon, 16 Feb 2026 17:40:17 +0530 From: Sahil Chandna To: jikos@kernel.org, bentiss@kernel.org, connorbelli2003@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu Subject: Re: [PATCH v2] HID: asus: synchronize fn_lock_sync_work initialization and teardown Message-ID: References: <20260204182029.278659-1-chandna.sahil@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260204182029.278659-1-chandna.sahil@gmail.com> On Wed, Feb 04, 2026 at 11:50:29PM +0530, Sahil Chandna wrote: >Syzbot reported a workqueue warning where cancel_work_sync() was >called on an uninitialized work_struct. Fix this by adding a mutex lock and >initializing fn_lock_sync_work before marking fn_lock as enabled. >This ensures cancel_work_sync() is only called for an initialized work. > >Fixes: f631011e36b8 ("HID: hid-asus: Implement fn lock for Asus ProArt P16") >Reported-by: syzbot+13f8286fa2de04a7cd48@syzkaller.appspotmail.com >Closes: https://syzkaller.appspot.com/bug?extid=13f8286fa2de04a7cd48 >Suggested-by: Alan Stern >Signed-off-by: Sahil Chandna >--- >link to v1: https://lore.kernel.org/all/20260130155204.96831-1-chandna.sahil@gmail.com/ >changes since v1: >- Add mutex locking between init_work and cancel_work. > >Testing: >- Reproduced bug on local setup and original syz reproducer. >- Tested with fix and original C reproducer, issue is not reproduced >locally. >--- > drivers/hid/hid-asus.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > >diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c >index 1b9793f7c07e..2d6b6e363bde 100644 >--- a/drivers/hid/hid-asus.c >+++ b/drivers/hid/hid-asus.c >@@ -147,6 +147,7 @@ struct asus_drvdata { > unsigned long battery_next_query; > struct work_struct fn_lock_sync_work; > bool fn_lock; >+ struct mutex lock; > }; > > static int asus_report_battery(struct asus_drvdata *, u8 *, int); >@@ -960,8 +961,10 @@ static int asus_input_configured(struct hid_device *hdev, struct hid_input *hi) > } > > if (drvdata->quirks & QUIRK_HID_FN_LOCK) { >- drvdata->fn_lock = true; >+ mutex_lock(&drvdata->lock); > INIT_WORK(&drvdata->fn_lock_sync_work, asus_sync_fn_lock); >+ drvdata->fn_lock = true; >+ mutex_unlock(&drvdata->lock); > asus_kbd_set_fn_lock(hdev, true); > } > >@@ -1258,6 +1261,7 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id) > hdev->quirks |= HID_QUIRK_NO_INIT_REPORTS; > > drvdata->hdev = hdev; >+ mutex_init(&drvdata->lock); > > if (drvdata->quirks & (QUIRK_T100CHI | QUIRK_T90CHI)) { > ret = asus_battery_probe(hdev); >@@ -1343,8 +1347,10 @@ static void asus_remove(struct hid_device *hdev) > cancel_work_sync(&drvdata->kbd_backlight->work); > } > >- if (drvdata->quirks & QUIRK_HID_FN_LOCK) >+ mutex_lock(&drvdata->lock); >+ if ((drvdata->quirks & QUIRK_HID_FN_LOCK) && drvdata->fn_lock) > cancel_work_sync(&drvdata->fn_lock_sync_work); >+ mutex_unlock(&drvdata->lock); > > hid_hw_stop(hdev); > } >-- >2.50.1 > Hi, just checking if there is any feedback regarding this patch. regards, Sahil