From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013047.outbound.protection.outlook.com [52.101.83.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B15219A8A; Mon, 16 Feb 2026 20:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.47 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273364; cv=fail; b=Gmhb2sn/CfBLAwJIjxsLoVXeXZUjmHw0mvLAxD4bY6IZZcGKlaYoqMjHzGGseoDUU2yinprYjNIXrd5EbFrvztHQEZ/b+B3SaX2gbbBuqENUMvzrKq+Ge2WAxr2NoGou1q6cJCiUygZamRfvd0bqEXOl3PSBP5CMQr0ypIOAG6k= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771273364; c=relaxed/simple; bh=9Dzqd0DtzF+t2LNyZmW8bvkIuNWvJrh3vdvaAdWmJV0=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=YIHqRRknUT3tJJCUIqUsPgTiqx2J8mjP0fu1oZW3UDqgL6INxsroe2mvjJJLF2BEs0zMuWc2k402iTf80cW2hcn83EylXRmh+VeUr/NPnnh+YQoOj2tQNsRxhQYmP1kAUBYYXZFOClpApcjUueUjjUeELfLOSkAxxPA+xuM+w/M= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Se8dKZEt; arc=fail smtp.client-ip=52.101.83.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Se8dKZEt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MOL+14PTXgtgCKDuPU0Q7/b6Xt6/Npi9djgrtqv7xnbqv+Ue/cY6WQbe9Y6FPNJ5phdspceoAKE48GCcA/OjYG+KItiFlLjZA6JE6GO+bBkjmCblRdoWjgOlzVEzbNFjVG2O+2hJVTyKKRgrgDVeU5HeTBGTxO3QuX4liK7OlrPs9m1NX+G9Xdlq8iw0IFtwYAPhXtzRpYfMAMYbJl0tEV77xJi1U9S5w053vDbWEbf1U/fZup3iShx5mcIQPPrB1rBoEYVDAeLjpvlOhQtfYXsaM5Yn9O+LAInjtUcJLpDJKVyLtRp6zUN6vt0/vSBLiraZtnJOAcG13t8KaUH4lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wqs7gvB0H/Kb1SOSrr2atgC5c3NkwlOAbP14h6GUMFc=; b=AYOnsVG64SbtW33hq0KKNJsQxfzyJ09keFz4SbTYdtxKgc3QRxp/hobN4uMbAKJpux0mxQdAqkziqKeojsB+8892z0FO0yYBwmkK53J6Zep4hBwvJtrlI+DrSttaJUy16nZFQJDIJAtPrCBzv7L4c/V4Vhw706gRIDImHNWUqK7KHYf6r1QiwuHeZ3kMUOeBNQwHhiS8aqVnZX/n7LbRA0YeGpDNjcqesiPbqZorBht/TFJs69RQkrW0//0tFtNJbktGXTAdg1StMk7gkFnLrESKaawWsYksaxsU2NDTqk5sMM6irdRwPFW40dLa9G730rgSjBJ5EnfXgRNgayLYPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wqs7gvB0H/Kb1SOSrr2atgC5c3NkwlOAbP14h6GUMFc=; b=Se8dKZEt94Aro7NjLuMO1YbErzEuLNX3HRGaJ3RFLed3WfpyEwiV3/KdQzne7RbXGtrucPv4GOnohV5SKD8AM/3/a7eHhvfecdhOmxoBz0rreznvTU8JkVi52EPopPRAJlDzxcZ/rkoWuiE9SKfgYipsSs3lSvlWkiTDYSZdVaHyaIJsqACd1XJwyYG6IwkPD3Xrq0OiYi/0CQDdnh1WBTdRjCdzvxBHFkhr0v1kKrTZF5zGrcq8S+aqoC1xHSbdbB+NPP1aQMHhxCwFK8m3/YUfrOb9kglrkJaNfweU0Oe7JxJyESMcrmNBgZUuS1QXfJ5QDeUgahtj3k/S1rTV0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) by AM8PR04MB7810.eurprd04.prod.outlook.com (2603:10a6:20b:237::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.16; Mon, 16 Feb 2026 20:22:37 +0000 Received: from PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588]) by PA4PR04MB9366.eurprd04.prod.outlook.com ([fe80::75e4:8143:ddbc:6588%6]) with mapi id 15.20.9611.013; Mon, 16 Feb 2026 20:22:37 +0000 Date: Mon, 16 Feb 2026 15:22:28 -0500 From: Frank Li To: Larisa Grigore Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, sumit.semwal@linaro.org, christian.koenig@amd.com, chester62515@gmail.com, cosmin.stoica@nxp.com, adrian.nitu@freescale.com, stefan-gabriel.mirea@nxp.com, Mihaela.Martinas@freescale.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, s32@nxp.com, imx@lists.linux.dev, clizzi@redhat.com, aruizrui@redhat.com, eballetb@redhat.com, echanude@redhat.com, jkangas@redhat.com Subject: Re: [PATCH 02/13] serial: linflexuart: Clean SLEEP bit in LINCR1 after suspend Message-ID: References: <20260216150205.212318-1-larisa.grigore@oss.nxp.com> <20260216150205.212318-3-larisa.grigore@oss.nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260216150205.212318-3-larisa.grigore@oss.nxp.com> X-ClientProxiedBy: PH8P220CA0032.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:348::10) To PA4PR04MB9366.eurprd04.prod.outlook.com (2603:10a6:102:2a9::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR04MB9366:EE_|AM8PR04MB7810:EE_ X-MS-Office365-Filtering-Correlation-Id: cb9abc81-a88a-4b8f-ee7e-08de6d991fff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|52116014|376014|366016|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+SiK2OClYapmfVk0RUw7Vq2OcV4gZ9E6KTotRxw0EzRPrghvR79iKfOJiRO/?= =?us-ascii?Q?BpcJ5pqFGOdDegKIbigihIKw9Xw+S1qY7/bcbis+YK8D2jIdJO00hGxOZDCz?= =?us-ascii?Q?479SsfJBRCwGcvnrNajP+o887vwGZgaQqkEYIhXdzdUaaWI0DymBSLDt2qNv?= =?us-ascii?Q?ePmi/UevzfK2lKrWH/vDddHF2B6npCft61VVcSIvhLFKVciCFksArw/GrP2n?= =?us-ascii?Q?ho7sfMJcu0aKTbXxvqcF7nhb+w8gto2ZeE+x2H6DjfCjBR5mhoDyarHxFafy?= =?us-ascii?Q?lSEdReFb01Y9IhAWCIAjWzQFUbJil6cwsVz7YTQdd1cSXnWHAOUY4M+WkqCX?= =?us-ascii?Q?VEtefAurPCcpsBCERSUUVtxG/SPo9J+QjxO+XjsGvOJZIbMrboz3JZrfQwHb?= =?us-ascii?Q?xO1qupHILguHfsCOydo6BpmZKM+KMcdfZh+jhFWw9vwd3Syxwa6ZJs2i5mUe?= =?us-ascii?Q?J8BO8+HMbOYnJ6jdHjXD1Me7KubuAMhNfOXQrcO34dz8aq7U/u0KyZLjbfl2?= =?us-ascii?Q?Hg4nWpX95Z3q+kHgZylgOa/eZ0n12VBUUe9lwlC3aaxCKK5EDYi82l1Hyzuh?= =?us-ascii?Q?0ePf0BydBEobiW2PRzB1UiB4sQPRnvj9lHaF6qImu025ODF1JBXaJw9jh2ur?= =?us-ascii?Q?ZSXOXrv8D4tEFWmN2L/QhTWJXBPvmvAMhcC1czyWFWP7JkuXLqxJ9OoP3YRH?= =?us-ascii?Q?luR5UyvaqBLIXBEN7/T+TpC9r8Y4C7CGiaoWKSAm60nx8GAzo1WfIcjh9XJV?= =?us-ascii?Q?g0pE7eb9xQoosfeq4jgvD514wreEFTtEAbK2+c0FMNK6zA6Vew0g6E5kGEME?= =?us-ascii?Q?LNpQ877z8nM/PMALcNa6NP3kCfe8n/NKzCj5w+vIMZoTp8EVStvKU27Y7ESo?= =?us-ascii?Q?wuZCWJMyDWPfxMiOypCjD0z4EMshQS8+rKX/bh5VltFXROWZqBUmgw0lviK+?= =?us-ascii?Q?Q4+kXL2seOZcYzHEBzbYfzfy2T3kaWrdIpK4OzpdLUhdCJgMvQ43ccewpUva?= =?us-ascii?Q?8BfByJTyfUsScR+4E4NO2YpNuy2esUAo/AvVt6CklyCnlPJRVVkW9NSqwTTo?= =?us-ascii?Q?7GOwoEKg6RE4G7ULeplv09h4X36hTNG7ZJsEbUZfc75dLYE/n+DYrSzV0yX2?= =?us-ascii?Q?2ePW99XK21Fl9VQJm8Gx1/w4vOpOaHkG+97sn5FBMtyw1nQ5SmpN9S+JHGTS?= =?us-ascii?Q?mWULxFRNjvgnYkLVOdAl+qFwdDgAfrllfSJuUhPrhVQOc7jDji/li15OqD7m?= =?us-ascii?Q?oecVgK9xqjdgF6ChaW3LNjrn/WfNln2VJuq0vbElI2PahpnaBykeNRLzzJbJ?= =?us-ascii?Q?JagzZoLKGgC8GH/CuMBcj7K/EsWJhvvvENIF3ecWBWqTUFRGQPomQW4XYKSP?= =?us-ascii?Q?3QAWWLxHm1E+jDtmXHZBWKlNjFmgblEoBL8f+ShoKkJ+gnHUVogxdhSo7KF9?= =?us-ascii?Q?7vJwzLyBRD18l6apUHJRH+nOS639oteTAtDF4Uab+WPu+DnRlkqHPJUZLNKE?= =?us-ascii?Q?YOAIQxLTZRVwOHzhy6LUOBdKjpzQnQHY6r6VHtDDcpECGSn95nTCL1WBaJkE?= =?us-ascii?Q?IAKUeb/VM4KC9c6AGT0F19TIFCxkuFA1Os0s/tKZyLAMhPjy9IfldPHd7n1B?= =?us-ascii?Q?AgCd9nkgGWXHEFL6dMOVbFM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(52116014)(376014)(366016)(7416014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?76U+bEQJvfChgePqbzV530aCmwVYOCGBpEY0gHf5CwvtX1dTP7ldvbr4r180?= =?us-ascii?Q?qAjN2P2mFMRvxM+0fvq8IUo34XRUra0xGpKRFy0qhWqubS/N1+K5gU65qt/d?= =?us-ascii?Q?qWlMAPSggyZI1ASYLICSinYNGS6R3d9c7GXF4zZiLWdNw4yaFeGlg23+cMUh?= =?us-ascii?Q?+0RofKNAAGcbgCbkvz9v+xrearcV20pxT+H+cTmI5DyPQAkPY+m968iOlgq4?= =?us-ascii?Q?ucgX20rFZtDutP2EhMO9UQlJYyoOTgaJS/u2nY6bj0WaX7UCwuayQGkG+2Dt?= =?us-ascii?Q?x4aWIWW6+5f1rXe0soLlh6tFuynU7Ot03kSwLTCGNT9u3ratO6q6ERbo3Y+i?= =?us-ascii?Q?ZxPW32WVO+k63cF+mJZ9lQshU6B/pQ3j0iUk8veLcIQnyTv5K+HG3c138tGr?= =?us-ascii?Q?y7nfPuEgV1iCiMAyKva2pGuNHi+1UMznYaYRKluq7/BZUQfEmbd8pWiMxi5O?= =?us-ascii?Q?AEwb/p1qnlgkdRkGWWd8kG8driRVFX40pnuMMSBLm+sq57INCgYa7HJMZ3Lg?= =?us-ascii?Q?d1lIU8cite/rdtUhbe30rOPbu6wielG0VgNkRN/QJGu356fSS1960GS9iF6x?= =?us-ascii?Q?1cQ4fMm777RKlotCwo2X6lDZZVaQZ3b34ddIQMF40ig59yeAKi/VoCpYdIBV?= =?us-ascii?Q?0jL6x6ZzUpphp7UaxN0krqWqoTK+O3gEjueSXPc4BQtTbdzOhgjy8k7DqWrh?= =?us-ascii?Q?xDP1WnpxtB3AuMjqPjZt8uQi4hwzmSR8FbJJDueBsutjRvqyidcDYUWWeWyp?= =?us-ascii?Q?eCt5OWr1ghA5sPmQpZIpmYnsltdmZYNePxL1nG8615PsC5Nt7pa8gMLawn91?= =?us-ascii?Q?lffP74cXPWajcRTHHeWPoLJlZACKqAPbgqLFM31ZZ16s/6KT+eF0CE/te2mL?= =?us-ascii?Q?pd3unjvmPa8xomhJgr4V4WV7ixFlOnMM0AVzCwu5pA5mrh9FlyyJvEijpW5g?= =?us-ascii?Q?nRCA7ygNM/LBu+a9xKTfh1+v81JYbJR154+6rOvLnFvXtbgXGit7b7XPHnCd?= =?us-ascii?Q?2SolikgM3lMj3kf5AOJCX5TkF+kxO8hthIhS80/8nCXnurgETEYF2J5JGI2/?= =?us-ascii?Q?aNfhA3Nblq9hlqfUbx08hnc0Mh7oYtYW85h9Lx6zxdR0nuUMNNPHgODUAKll?= =?us-ascii?Q?TKihZhs1zn1+Dmv/hTSJ23H4+S+OGjK+TKPoS+pBoqPSaQsvvxQtm2RflprH?= =?us-ascii?Q?H4LeXbqud9otQbRTZnRRL18wpkDMpTioLHEtl/A4+VVQ3UeIKHuc5W6pldL2?= =?us-ascii?Q?IVqSR9eyZ8R43vGScfiWQMDe8Yuty791OA18ZZh9jkuK109H+MPuuj4g0s7Q?= =?us-ascii?Q?70tRLwU4Foe7444BTjuRV9KjpFknKjxuYIqvw6zM/0HV+Ifdff4l1bp/RPrz?= =?us-ascii?Q?qFyZMUrn86gjyue7h4z9O4vrMggjRlnmjDXJmOBGE6vVg9wmk0OomrI411VE?= =?us-ascii?Q?7oAkVMQSWVUHBdWAql9/7M93hlQyw7nEZ5Ilv6FYQ7H92D281E65Xee713B6?= =?us-ascii?Q?1v0Ozwx8BqQLZJTBiisiWTEzajOXjjsugYTghc97rOBZzA/Xbip5uz2gO4Iz?= =?us-ascii?Q?PJocKlt1E7muP/vBz9KZt3Db6ftXbcaDXOTreFNSMe8TgUQcClswjrdQozFC?= =?us-ascii?Q?eKnggcR7rXlaSlRpk4ms39m9+aK313ukpOToBtE1JPHWzIW+s2Ss6RVsMjnX?= =?us-ascii?Q?+uvJhRnuFTlbWP2gIrhu6R4eQ5arc35Xg2u3d2oX6KxpI0k+?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb9abc81-a88a-4b8f-ee7e-08de6d991fff X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2026 20:22:36.9548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gbTXoTP9Ox3xcmm0EI3b0aUyRb8/Gl2c9ArMuhcrK6sgBn48CBWSTxbe6Pdze7C2q/paYGQH57Y84w/+bIAX/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7810 On Mon, Feb 16, 2026 at 04:01:54PM +0100, Larisa Grigore wrote: > When coming back from reset, we need to re-initialize LINCR1 register. > SLEEP bit should be cleared, otherwise we can't enter INITM mode. serial: linflexuart: Clean SLEEP bit in LINCR1 at linflex_set_termios() Re-initialize LINCR1 register (Clear the SLEEP bit) at linflex_set_termios(), otherwise the controller cannot enter INITM mode after suspend/resume. Frank > > Fixes: 09864c1cdf5c ("tty: serial: Add linflexuart driver for S32V234") > Signed-off-by: Larisa Grigore > --- > drivers/tty/serial/fsl_linflexuart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c > index 5a410e2d56ac..016011fd8760 100644 > --- a/drivers/tty/serial/fsl_linflexuart.c > +++ b/drivers/tty/serial/fsl_linflexuart.c > @@ -413,8 +413,7 @@ linflex_set_termios(struct uart_port *port, struct ktermios *termios, > old_cr = cr; > > /* Enter initialization mode by setting INIT bit */ > - cr1 = readl(port->membase + LINCR1); > - cr1 |= LINFLEXD_LINCR1_INIT; > + cr1 = LINFLEXD_LINCR1_INIT | LINFLEXD_LINCR1_MME; > writel(cr1, port->membase + LINCR1); > > /* wait for init mode entry */ > -- > 2.47.0 >