From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2692232C31B for ; Tue, 17 Feb 2026 23:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771371845; cv=none; b=GVpKkpntXDtK8lGhzqUT9CRfBOtI+yfLndDVLlT+BtwaZz/bP9ufUt+LS5r2/bM7cTVCFdHqSJOgGuAZ9P9tUZc1bnAhHHwx6A4YnHqeREIYkg9XxNBoLckBXfq3by75KlABVB9zA/GM00TdBJdGVH0rX1jSKx/iyFObGygeGi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771371845; c=relaxed/simple; bh=zgHp0rCJ6ISdDX7RasZjHOO2v40C+WfBpA3AMbfkTow=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FiVHfRs9ATA/zC3eHpuLYKpn2n0sOPzLQDl6YFs9TvHRRxjf51zrXXKlqGu4eWrhFOmNBxTAL6wL4vvvRnDza3MNrxiyWOqydicnfTA4BGUB2JYcZEZWUsKI7PdzGbdjKXIdWdKIbAuv+zx+ssIN+4pxvYuNNuLdFG/wSu5LAhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VmuYPTsg; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VmuYPTsg" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2a76f2d7744so51886075ad.3 for ; Tue, 17 Feb 2026 15:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771371842; x=1771976642; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5/aCNMwBAkSYiwoiX/QbH+a9MRbUxIDZiaFVfDQafN4=; b=VmuYPTsgPoDS86sxPc3UaNVd/ivXr+HUYf1uiRRtMu05iUZOSC+U0O1DEIQSSEX1nb yotX1ihBska6ouMLPewnKkCsY7jafTMI13v516OR+/adrOKEsq1U6Qfz9gZIXy0tOTYb 0o4k/ck8SijTHZASzpF9+ZmRudkysYnNafSx2lfMh5PQnQFGkz0h/F6ZhbBJCEvtT8D7 W7mgakuDqjNhSj2bPuKscjjJ87+KVDrRbbEfuFT63dL8N5FrvKWyCvtDKh7Ml3yrESKK sTa7F3+gbLv7dJGTwWREgBYQDgJOY2iaonzuD4C8bhUHKUFsNpwXPzyFIjR/OLAzyJRW Zkqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771371842; x=1771976642; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5/aCNMwBAkSYiwoiX/QbH+a9MRbUxIDZiaFVfDQafN4=; b=ffFDKunL9Xn3IHdoxp9C9/JXecUiejCfBGk4c2xIdoBQi3Io0f7ZukC7qb99ipm1zJ LplBWMfwKey2WyUXVn83+/74Crngfb9U/phCIn7PB+6/rPUe4CySshMehFm1vK2wVwGN t6rhmxvekFD+ERe2j/7+gAznXl1wGbz2P8g64EdBFa9FDuNTjRhXnVhFoNEa6PG10Ely TVw6PvaU2A5HZRUsia3wcwMdcT5jAOEhvE1EitJbQeFCmQv52jWmetuBsJZNXDz8cJxx HN3rX6kZ5jglqoEW3WnCrpLpX4Qp+rEXZlh6UDdREh5oAGhPRe5n4NbNYD/fqGw773VW oFgg== X-Forwarded-Encrypted: i=1; AJvYcCXSIdZltXdR2JpEXQwB32eb6KWABSHAhcTGTlJlT/liq/hPjIJbqhv+NDvli4+nJjnatrnCxQyDptLV1Rs=@vger.kernel.org X-Gm-Message-State: AOJu0YyvFqKgNjR8DjBHdWrEoUw5qp5+onXQRFOVw0BZj/q86g11DOZl 45X4uxkNr7Fw4OTstUTk/1NM858mj1oP3026x4ip535BaF9if5S0s5nDo5f8zNB7VOiJK7O7G2f f/qD9gQ== X-Received: from plsm8.prod.google.com ([2002:a17:902:bb88:b0:2a1:36d4:7f2f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1ace:b0:2a9:62e6:ab11 with SMTP id d9443c01a7336-2ad50ff301fmr202985ad.59.1771371842202; Tue, 17 Feb 2026 15:44:02 -0800 (PST) Date: Tue, 17 Feb 2026 15:44:01 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260212155905.3448571-1-jmattson@google.com> <20260212155905.3448571-5-jmattson@google.com> Message-ID: Subject: Re: [PATCH v4 4/8] KVM: x86: nSVM: Redirect IA32_PAT accesses to either hPAT or gPAT From: Sean Christopherson To: Yosry Ahmed Cc: Jim Mattson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Shuah Khan , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Feb 17, 2026, Yosry Ahmed wrote: > > @@ -2838,16 +2876,7 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > > msr_info->data = svm->msr_decfg; > > break; > > case MSR_IA32_CR_PAT: > > - /* > > - * When nested NPT is enabled, L2 has a separate PAT from > > - * L1. Guest accesses to IA32_PAT while running L2 target > > - * L2's gPAT; host-initiated accesses always target L1's > > - * hPAT for backward and forward KVM_GET_MSRS compatibility > > - * with older kernels. > > - */ > > - WARN_ON_ONCE(msr_info->host_initiated && vcpu->wants_to_run); > > - if (!msr_info->host_initiated && is_guest_mode(vcpu) && > > - nested_npt_enabled(svm)) > > + if (svm_is_access_to_gpat(vcpu, msr_info->host_initiated)) > > msr_info->data = svm->nested.save.g_pat; > > else > > msr_info->data = vcpu->arch.pat; > > I'd go a step further here and add svm_get_pat(), then this just > becomes: > > msr_info->data = svm_get_pat(vcpu, msr_info->host_initiated); > > It's more consistent with svm_set_msr(), and completely abstracts the L1 > vs. L2 PAT logic with the helpers. Either way works for me.