From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EA7322557 for ; Wed, 18 Feb 2026 08:59:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771405177; cv=none; b=AKUGw9eUocys35ACq013AxYjS9ypnzDwBtWkTx5yCON8DIDSwL+wi3QEU5wp1PQlZ3vxlgmoiYt0M0Z3XwYGo0HtUYdlcFdbJEAsc8BxobyNnRPtU0FuCRBZ5c6VmAEiWQOSHMDvCcC7oAQ26sh9T9HKhodlCBkDvDYvIGJtIXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771405177; c=relaxed/simple; bh=bp0SGlOFbs7qaFo3i1X5NVk+cXHP+qamjp/rZmnb9Kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MvH59dunxsmYdCIcJccEUdsqHtXfI/GZFwUTHzhocBdh4wPJHbev1/l4P5CuWxx7/YFHX28Q4+53QadNILGyJkSKIKfG+5djRtfgRhfaKA9+WhwYZ9lgajai0kRKLqILCCcQJ+152bObnA2U+gA59XuNl5QdctabFQfqJPAL9/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P8GcJCEA; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P8GcJCEA" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-436317c80f7so387982f8f.1 for ; Wed, 18 Feb 2026 00:59:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771405174; x=1772009974; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s4xtdZq7ZOIcHdSeKfZqgNu8Mz/fkUqSTcDWpnIDA68=; b=P8GcJCEASBn7BRXqPyrcBhlNhAFFXlJEAMOe4TqqMbQ86gZ0O4x9pXNn04qGQZgIAQ CLlq1mUVN0TBA59Y5vN8cAVHDZnVFKQ+cUqDhtVx/6euowjcRewbinlN+mYdWUQCWDUg 1xOdsewdbDJPelbWWk3VCGBN/W4OCV5qvOMJMdo23fuNUkdN2AmJx4sC/pYMe5MccRgT Te2spoFKi5SJpiIdsUmtqj12X/9+JMAuQD3PAuoYOjUMXbPmcs+zEK1fqz9gYGkqNZ/Y zqbBHv6iFD1GVwBic3USy04QjwC4suH/IkMPXEcEVqfsKNEOoxEwPwzMThKDy3yQblfM SVKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771405174; x=1772009974; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s4xtdZq7ZOIcHdSeKfZqgNu8Mz/fkUqSTcDWpnIDA68=; b=FwgVh7TqvTlQNcRwTmpi/aoQgY2woT5s19mgWKjRijuI8A9W8iU7udfuwuzM1JOmpl yvRpO7lcqq7Vnn5b5iYIK+iUBJWQsNs7WaP4dPGBQWBa4YVffk8awxLlr0JG/TNE5Gq8 DmBaUlUFrlAom+9Y/uedW7eIc4VMsDa6s2MXOlpLYeQBH+u8N82PSK0c845H4nnMEEa8 KzIFqEf39ZCVWy8wyNWkntHVF2qwaP+Q/X08wM7/hbrvz8PwPFe69Cg3SvCAoDixWmrE D0JtEey1OOtC9Yqh8NoZVS8V7ZLi4q6ulzLdElPkJyqL/WQmqvRJgImyjJP68JeIcHRI Hslg== X-Gm-Message-State: AOJu0YzXVq+atbQeljvitO7IUcgKC7zIhc78QtCKu7wNwRcTPDOykUuk X0FqAT1qvmvLa/UshmtdYbB36aI6svt3FCbpDnwYZsBq/h4Gkutw3XdT X-Gm-Gg: AZuq6aJRvX/RUYUMyHfIDHPEdWFsKBLuK8nm3dESAijqrdpJ+G1D8iwaRoyl3RXV84w LTX54scmsu7xPWEZBNmhRhnwneb3NpnzYTv0IiYZ5mz5Q32XO5eRN/zEUBWeqflFdwPQ+jMy7Sq Cx3+fY1NXkTql+vqAabkpeFYG+i4acyFpFhVNFO5a+HF7fWroXNSKyUuYAGtvUvBmPrQIDrgqHP 60kYtka1+hP9wD8v9R5uTAId0zcLz0sG2CPDJW/bd0WSSf7XgGH2ZrP5Oznww60udCtS7RxzeX7 Zq/1vWOL/vL78EbNN7izJgyJ/bZCPcycN8td8hreDOycr6bY79yB/8s+coZR9/0jyf5oQ7d9CSG XZMKxGpGaewUC3dfmSri5oPU1622FsUi/2oszuMZOfkWqY95R7jYg7LF7s2TQl2413NYsBAFQ43 Ap/WZN+03R40tfxXWT5EuxfQ0Fb8Ex/YmvbS4Oj/cKPrEvQgV9hucgo5JVZyjotZ96eIg5Z3OLD QNl71wWsXVrYPLbUN8aYlNMZ+UfDq6faXtoUWkCc9zgPvk= X-Received: by 2002:a05:6000:2410:b0:437:6b6e:d108 with SMTP id ffacd0b85a97d-43958bfe6a7mr1881588f8f.8.1771405174240; Wed, 18 Feb 2026 00:59:34 -0800 (PST) Received: from Lord-Beerus.station (net-188-152-100-94.cust.vodafonedsl.it. [188.152.100.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796abc85csm39968574f8f.22.2026.02.18.00.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 00:59:33 -0800 (PST) Date: Wed, 18 Feb 2026 09:59:31 +0100 From: Stefano Radaelli To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefano Radaelli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Subject: Re: [PATCH v1 03/11] arm64: dts: freescale: imx8mm-var-som: Update FEC support with MaxLinear PHY Message-ID: References: <3b984b93a43a07bc9c4f6414a08a3a0f45daaaa8.1771353301.git.stefano.r@variscite.com> <31f30651-7c99-42cb-9e27-e4806529d137@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Andrew, On Tue, Feb 17, 2026 at 09:43:16PM +0100, Andrew Lunn wrote: > > And here you loose me. RGMII is between the MAC and the PHY. The PHY > is on the SOM, so there is no need for RGMII to leave the SOM. > > MDIO is can understand going to the carrier, because there can be > other devices on the bus, such as an Ethernet switch. > > You say the LEDs are not on the SOM. So they should not be listed in > the .dtsi file for the SOM. It could be the RJ45 is a cheap one, > without LEDs. The colours will depend on the RJ45 socket. It could be > a single LED is connected to the front panel, which is typical of STB > etc. So the LEDs are a board property, not a SOM property. > > > > > Two LEDs are defined to match the VAR-SOM carrier design: > > > > * LED@0: Yellow, netdev trigger. > > > > * LED@1: Green, netdev trigger. > > > > > > Where are the LEDs? You say "carrier design", so are they on the > > > carrier? The DT properties should then be in the .dts file for the > > > carrier. > > > > > > > The LED signals are driven directly by the PHY and originate on the SOM. > > They are exposed on the SOM connector and are typically routed straight > > to the RJ45 integrated LEDs on the carrier. > > The problem here is 'typically', not absolutely required, otherwise > the magic smoke will escape making the box useless. > You are right sorry for the confusion: RGMII is internal between the MAC and the PHY and does not leave the SOM. What is exposed on the SOM connector are the MDI pairs towards the magnetics/RJ45 and the PHY LED output signals. Given that the actual LEDs are implemented on the carrier side (RJ45 with integrated LEDs, pull-ups and LED supply), would you prefer that the LED description is moved out of the SOM .dtsi and into the carrier .dts? My idea would be to keep the Ethernet controller/PHY node fully described in the SOM .dtsi (since the PHY is on-module), and add only the LED subnode/definition in the carrier .dts where the LEDs are actually present. If this is the right approach, I will apply the same pattern to the other Variscite SOMs where we currently describe PHY LEDs at the SOM level (e.g. imx8mp-var-som, imx93-var-som). Thanks again for the review. Best regards, Stefano