From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F3B1A9F91 for ; Wed, 18 Feb 2026 22:37:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771454259; cv=none; b=KpBHuylXTzWdg8xVkxvshF+rdFAd0uvwqr2TOesMhAobd7oVE45SplVOaF7N4d6ZuSoPaIguJMf6RpVMK0v2M1jqLD0p7IxZtNnLWj79qTjK8kCKIKTO94cJ2Dd47idPOuUQA2UHeOpTFzgaR9/8CeKFZDCk4USCvsO64vASZ1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771454259; c=relaxed/simple; bh=9dVqXDY0LTUqLurnaE5POkAkdNIedxmUa8hwO20EQWk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MxkSecPAEu2NnPeKmb7Z2YVJV4RsFAhBXGgvEWcWlPXgAwivwk8uQaHKkMiZMo7ba8lxFxQzKOSayCSBoQaNurxJPcxMUZlZzn/f19fX3GRHxRFrLnTx8uAYfWOZYR+x+NW9Az4KiBfgcyk6Br2Zl/pC6vnjwXJefi/WuX7V40Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KQUEKXCB; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KQUEKXCB" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b884d5c787bso61723966b.0 for ; Wed, 18 Feb 2026 14:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771454257; x=1772059057; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=88VC8PAAdqBSKkHPJCPW55gpFIgzZNDj1Z17Jhhh5Es=; b=KQUEKXCBGVeR294t9YRPRW5BYy2/uHw1mBj2EHjy6eUEd6Vx+rT48J7G+iB8XAbmDQ 33jcyfTfDtMwC2zMjDiLC/yKvE/feKuYM1CP8yTOoW1LsZNGUct0gdbQRTye9Qvloccw r9c5YpQ/tgR4UtV3Oqdrn2TUTvXjeWybiG5a96uKbxaMY5MPP+tUYQZxybe2Db0PjN8p wWR2bDAGsYGj3k+WEZAwiKrZUxF254oOtQofe0FkVMV3/UFX5P4nhdkBFsD68TZJgLNB 8nR5Qznn+8drundU4F7039a3XaWLtkjpHBs/q9MIN92ssNoE87zQUFkfwHM2Fbn/Z3Ib uu8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771454257; x=1772059057; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=88VC8PAAdqBSKkHPJCPW55gpFIgzZNDj1Z17Jhhh5Es=; b=KjSCV8xJV2vSOKbe1tVUu93qtcDlvf+VSf/XrXOos5i/XQ+JIlsiiz8jTdNlOxRZiX oTWdnBWf+7kYRgSNjV03Nx8vBEo3DCVq/IBjGdWO6G6M+YIrXhmXRSoUm/YMnYBlx24v mQsZ84510O9tqFj2APh1JnWB8YyIiECTHRjxJMnf0hqydElgkNInkzrlgcRDBn5J3QNh w00wgbyru7M9VNTfp+yLglo1BUu3B2EVItVnBf4PQLIevuHDgEDPwrpcqeLpnNZOPL2k QWJFSAGDIbo0eE1/qjJk055rZcnHXurhHsNWgIylz96MpfCz0UR9kpTIWshii/905nPI Ppow== X-Forwarded-Encrypted: i=1; AJvYcCWZKMY79WCT2kg0/F89UALzUmFZYvEShZ73XYXiGy/WPbItmvuB2jy9wMkOfI6RvDp7MaoDDTKkPFuW3z0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3GBrgHWFa1ZW14oO/WrUxC4KK3nuZjlTo1ZIpBHfmvl288P/9 /84GYvB1RPGzV/fgDe4aXXSHrAlPcC5wEBObWdT2Nfd7jToXFvCMwB5P X-Gm-Gg: AZuq6aLDK5+V4T7wS0pTSltIxVc3Yx2qkm8I5A27EF1Ba5U7TP1dXfAB28HD0WPQa/O 4Nv4IOemxrrNinHSoesbKb9yd+VrFf8vNCsEFIU1cy9WWZ6pVP1qTjSXlELWFERoBhYnOICEVwJ WQQzDMneMn4VkmqN4iErbTss6zjVFNXJDq+dIa4pnI9Jy9k74/NAOubj8i+EG0l/EL4VkD4eO2S Nn4i2RHJEaoZjTfSpERDc2f8h7YeFKbD55IH1yTFKfMPv9+G7bQIqZevyyzdLQejcV67z0c2KjS g5GuKe/pJZovlsNYW3vmS7k42MVo2I2al2tzwpcuRQe6WhWAIc6U+q8B/ljKaXN7hZFRRY29FO5 hV/FYnoaOkrIzLRmd/L3WJpoBionUQz2roR67VE/KmLFl7SJoDEZd2mz0k5/hLOrNPMmCaB1giB fzeyLZc+VMhw6HKw== X-Received: by 2002:a17:906:794d:b0:b87:756b:cfb3 with SMTP id a640c23a62f3a-b8fc3a32d80mr851341266b.19.1771454256440; Wed, 18 Feb 2026 14:37:36 -0800 (PST) Received: from jekhomev ([46.251.53.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc766519fsm475142866b.48.2026.02.18.14.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 14:37:35 -0800 (PST) Date: Thu, 19 Feb 2026 00:37:35 +0200 From: Yauhen Kharuzhy To: Pierre-Louis Bossart Cc: linux-sound@vger.kernel.org, Cezary Rojewski , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH v1 1/2] ASoC: Intel: cht_yogabook: Add driver for Lenovo Yoga Book tablets Message-ID: References: <20260217231324.1319392-1-jekhor@gmail.com> <20260217231324.1319392-2-jekhor@gmail.com> <218a9abc-87ab-45e2-8ec5-355cd6bd627b@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <218a9abc-87ab-45e2-8ec5-355cd6bd627b@linux.dev> On Wed, Feb 18, 2026 at 11:31:38AM +0100, Pierre-Louis Bossart wrote: > Thanks for the patch, looks mostly good to me, see below a couple of comments. > > > +static int cht_yb_hp_event(struct snd_soc_dapm_widget *w, > > + struct snd_kcontrol *k, int event) > > +{ > > + struct snd_soc_card *card = snd_soc_dapm_to_card(w->dapm); > > + struct cht_mc_private *ctx = snd_soc_card_get_drvdata(card); > > + > > + dev_dbg(card->dev, "HP event: %s\n", > > + SND_SOC_DAPM_EVENT_ON(event) ? "ON" : "OFF"); > > + > > + if (SND_SOC_DAPM_EVENT_ON(event)) { > > + msleep(20); > > + gpiod_set_value_cansleep(ctx->gpio_hp_en, 1); > > + msleep(50); > > + } else { > > + gpiod_set_value_cansleep(ctx->gpio_hp_en, 0); > > + } > > It'd be worth having a comment on why you need the 2 separate msleep. > IIRC for Broadwell we only had a common 70ms sleep for both enable and disable. Actually I don't know, it just a copy-paste from the Lenovo Android kernel code, and I didn't check what happens if this sleeps are removed, AFAIR, if there are any sound artifacts or something else. Will check. > > > + > > + return 0; > > +} > > + > > +static int cht_yb_spk_event(struct snd_soc_dapm_widget *w, > > + struct snd_kcontrol *k, int event) > > +{ > > + struct snd_soc_card *card = snd_soc_dapm_to_card(w->dapm); > > + struct cht_mc_private *ctx = snd_soc_card_get_drvdata(card); > > + > > + dev_dbg(card->dev, "SPK event: %s\n", > > + SND_SOC_DAPM_EVENT_ON(event) ? "ON" : "OFF"); > > + > > + /* Black magic from the Lenovo's Android kernel > > + * FIXME: Check if it is needed, an original comment: > > + * "use gpio GPIO_SPK_EN to enable/disable ext boost pa > > + * use mode 3" > > + */ > > + if (SND_SOC_DAPM_EVENT_ON(event)) { > > + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 1); > > + udelay(2); > > + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 0); > > + udelay(2); > > + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 1); > > + udelay(2); > > + gpiod_set_value_cansleep(ctx->gpio_spk_en1, 0); > > + udelay(2); > > + } > > That seems weird indeed, never seen this before. What happens if that block is removed? Sure. Will check, I cannot remember if I checked this during initial porting... > > > + gpiod_set_value_cansleep(ctx->gpio_spk_en1, > > + SND_SOC_DAPM_EVENT_ON(event)); > > + gpiod_set_value_cansleep(ctx->gpio_spk_en2, > > + SND_SOC_DAPM_EVENT_ON(event)); > > + msleep(50); > > + > > + return 0; > > +} > > + > > > +static int cht_yb_codec_fixup(struct snd_soc_pcm_runtime *rtd, > > + struct snd_pcm_hw_params *params) > > +{ > > + struct snd_interval *rate = hw_param_interval(params, > > + SNDRV_PCM_HW_PARAM_RATE); > > + struct snd_interval *channels = hw_param_interval(params, > > + SNDRV_PCM_HW_PARAM_CHANNELS); > > + > > + /* The DSP will convert the FE rate to 48k, stereo, 24bits */ > > + rate->min = rate->max = 48000; > > + channels->min = channels->max = 2; > > + > > + /* > > + * set SSP2 to 24-bit > > + * Looks like strange black magic because ssp2-port supports S16LE > > + * format only, taken from Intel's code > > + */ > > No, SSP2 supports 24 bits in TDM mode. only SSP0 has firmware restrictions to S16LE. Thanks, I even don't remember why I added this comment. To be removed. > > > + params_set_format(params, SNDRV_PCM_FORMAT_S24_LE); > > + > > + return 0; > > +} > > + > > +static struct snd_soc_jack_pin cht_yb_jack_pins[] = { > > + { > > + .pin = "Headphone", > > + .mask = SND_JACK_HEADPHONE, > > + }, > > + { > > + .pin = "Headset Mic", > > + .mask = SND_JACK_MICROPHONE, > > + }, > > +}; > > + -- Yauhen Kharuzhy