From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 086C0EEBB for ; Thu, 19 Feb 2026 02:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771469015; cv=none; b=FpRaAGAZl1261hYGoSS3bXuVwzFzAC34wIg7HzXHct1lkFyvU4IgCS6ga6e4VnlFK0T8PUm23e9DTnEF8uxDTgXfLkV/HI4PEfS+kroucUMDrLFDhjqVV4Ew8wVFaPV4sEQcFfzIhR9Ve604FOOHQStCVYYfOREUvQ3VvT6Z6PQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771469015; c=relaxed/simple; bh=KqGg5WSPpAb6AJ2Q67bzsJbSdSO5yc4vMcgZLK0hulg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sgYCQcMPKRQ+nubefPWZX9FiqQ+WfMK5MoypSATxKI/Bo3e5xtd1UL06XRvVp+ruqIyvSQx6s2gpY0Yflc1Ei/KjJ3OsJ+uaLTCJJkuXmDlQDITKSytOAPmFW39Rzsn5cAfhqrXOnZ0G5PaGSsTmMIl2CFRP+PiBLvFAWRxK8wE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hRt7OXsk; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hRt7OXsk" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2b4520f6b32so573548eec.0 for ; Wed, 18 Feb 2026 18:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771469013; x=1772073813; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gTKrUTqUdwYFHuwWVgZXgaQ8n3QIp5eyNYtOEVUSSHU=; b=hRt7OXskXZbGmTnNI+o3gVtG9MEG7NTSUzObi+apxAyVPIc2plNQ5Zh0yOXzgc2R6F FSIV+nT/jmNBbQl+kuqmSLVD0Da8CB3c/mmIiJM4NEr1I2YGh745zgaD9Xt5osDRU1CM FN6dq12jnqw1aFvGI+Xu3opJYZMVcE0B5A1vqgSN4FRoAcS86hWgqFc36RRf9apltGd9 E4tx+Gq7LsEEdXO1LrJqSasElsglk2X14BYj/SHNbBE7Umkl8RTHMWmAGVFOEmxjxtO4 Hyq16L3vMME5L4KYlHhpg9OmHTJ7G9Y5RgR/2YXsivmC3OVzI7tlKUvOUgzbDouxHwKq JGUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771469013; x=1772073813; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gTKrUTqUdwYFHuwWVgZXgaQ8n3QIp5eyNYtOEVUSSHU=; b=GEx8SGoD4IUutuP4KVy+7Ne5W96I5ATACbp9YXOSET7lh9yieQ0e+ptT0QoFOK0okB CBEycJ0TpacQTSS6YiEPwBoWyHSfKURxUJL780qPNHHIVUUdxyA4ZzoE8I5K5E9WC/Sj O5AxySm1fWBzNjWDyKEf4hGlVQbxyu4r5wiKFt6T2ckFCItm4XVS2N9uzaZeH24nYehF wtH7gvZHnWMdMXkmx6CBgz9i13zcGzs4g2d5UB22FsXAsgCBR8vmRhp7F9ajBizrXPAK GQK+KrJ/FBi3FGB92KoNDToMO/jOC9PYDjM0zyoXbk2EirW/+Qbb7MseVfODv0+ivlZ1 e/8Q== X-Forwarded-Encrypted: i=1; AJvYcCVWcXbGtydBPd3SIatO9eQdlwX9GYXWtErR1Yl1HIXsR7eLAehpBOn7CrKckU0MUZY+rt7e7yNvcXO7VX8=@vger.kernel.org X-Gm-Message-State: AOJu0YyrHEfruoF1fC9zmXFrL/F11HHJDWVzxPpxL14XnEVEsEoWQeqo MxDxj+8ma3zUyC4P7KFi0WsMk8klJzsdWt8T1Lkrlj5nDqUEl+ktXr6A X-Gm-Gg: AZuq6aIkoKPKc9gitJhjDCNUTPbXTLZ2zvZcPySe4k1C4faLFTO387MlM6e56DMF6La MGbAkhe9aXAChV6TQtN9SEg5F/qg7hCUv/SXHVAo7hyQqWngEA0bWXN5JNjBPcihTlnZkxAYpU9 tHLxU5C7LyJWuvOYKDLM2iZKVa3n8+HiSOGFwBWDg9KwOjiuTii1tdSmcP2ncsB0CaNu8QId/++ K+b7MRLnKVhG5Uwtw2J6NlqVnprjPiiRprPzi84lIYkDEyl5+6xSUvTg0TTI5zG2j2nFUcMqgPu 5b9L6862JEi8o+XQSvQ7+VJVuW0dx+FFvfJao2j7YclDNNRrNo3Fk0QfPx1ACeNg6jeq3c/bqNj kRGGm+19T/ph81xxD9BssePf2Ps8W0GPEUNIaQQQz5xNeS8I3YDfeZjd50TwFDNFmAthFcGg1Hb d27at+foCBeDCjG5QRf1citbKra1duy3OZumlp3WD6zC/JSYXel+MCLpHLUD234Jmk X-Received: by 2002:a05:7301:6091:b0:2b6:fa0c:6c44 with SMTP id 5a478bee46e88-2bd50009ef8mr1690376eec.12.1771469013002; Wed, 18 Feb 2026 18:43:33 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:265b:f5ad:9e03:677e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb543e8dsm20020155eec.5.2026.02.18.18.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 18:43:32 -0800 (PST) Date: Wed, 18 Feb 2026 18:43:30 -0800 From: Dmitry Torokhov To: Yauhen Kharuzhy Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH v2 4/5] input: drv260x: Fix unbalanced regulator_disable() call Message-ID: References: <20260215141435.727872-1-jekhor@gmail.com> <20260215141435.727872-5-jekhor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260215141435.727872-5-jekhor@gmail.com> Hi Yauhen, On Sun, Feb 15, 2026 at 04:14:34PM +0200, Yauhen Kharuzhy wrote: > +static void drv260x_remove(struct i2c_client *client) > +{ > + struct drv260x_data *haptics = i2c_get_clientdata(client); > + > + regulator_disable(haptics->regulator); > } This will result in power being shut off the first thing during unbinding, which is too early. I switched this to devm_add_action_or_reset() and applied. Thanks. -- Dmitry