From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C64538E5E6 for ; Thu, 26 Feb 2026 07:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772090432; cv=none; b=HrJSY1gp7O5kSJoLLLplV2/dKAjCX29J+bJrGSuJe8yHaXzj365bU3DJ0I7mfDXIzoGWbA4FIIcwWz0BMnThyhQqxQpJwd9Yu2321zJmnQ0rdW6Ip7JDKhDFI03eW2l5CtolW7XiPN9Rsc4LcJLsXb42Mva3v6aMRLsDKVIUHXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772090432; c=relaxed/simple; bh=9de9cennl/VkLfcdKI+tiocL72hO2WSdjd6RPZcIHvM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aY0ENEySHu7rgyk1ibuU9tuvhnTyfP1wHARoFLkM5myKmXoaVa58zBzx5PLBI1CCasuKeD7Ts36Yd96teKocX62M+YryA0OxIkevCNNL1POpZdBxSBgdCA2MMMHFyrabYNzAm3yXqf9ZJJnDTmgJRmUwtZhAMhtPR6RpkdmquyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GKRp+zFO; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GKRp+zFO" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-483487335c2so4329775e9.2 for ; Wed, 25 Feb 2026 23:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772090430; x=1772695230; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jbJIiDdbcCatfQeAaNBXFJN6hczMbqAEzSc1JtFci2E=; b=GKRp+zFOqBFYMzM7Uohm82p7P0ofSRAphE6JroOHP5xpVn/Wxn6WhLdMeINlh9Ntaj dwMBBrrl++n2wIZxOy+T4gB4t7mw9bl3g06F0Gt8WENNbXg0S3wM8DOb8Jv+tIXg++BR wXlTCSudyD2CEMW8bvTPmEQTLIHcEzNkxHzI3xziU7DQcdrbvmSWcL4qyrMaNzUHoTcx MAiDumOzOcnhNeNFYH3sJM4LgFgfgUsZckN+XHvGMLK0FP/ADPMvkkI/G52avE12cK4z Og5jtzxFGUgeeblfqsytJEXXjsnlVjtSDIAG2bF+FWndF1TkeHf2Xiuk33y7+h4CiAaU oenw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772090430; x=1772695230; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbJIiDdbcCatfQeAaNBXFJN6hczMbqAEzSc1JtFci2E=; b=hymb2C5npjdXIrD3y5y+yD3ax5j7WePjI02bZzqOpCvcpIP8a96pYCMp/SziKT9EzE r41/MRDMp/svJDUm3x9TWuNEQDyHODKa99wjCzv88pksnhIdAyPd6TQNqwv/IqUiuSn4 OnN8Zw1U/UQ2F9MI+4+6TBWkG8jO9GR36VoIyO3yVJ2OsJIQjr4T0FNDTBAA8DDbZMf+ 1dC/1VvQ937I9nmgjWQ8Zpb7oSms9zTfttpWe/UgwtphbbC5ZwFcROV61CaVdbkj27eH xOFkE8dVrwHLDRYfW/oYZcp3xf7JS270NDPE4srwRPVZDYtGLv6CkcLq2i6FksLIyPKW do+Q== X-Forwarded-Encrypted: i=1; AJvYcCWBYr1JPPTJTh07qAuPY+bTu6jwEkkfIwIZXpSCy5RE74uLYdlCoaaPCkaLGui80QZtCI4NpryqNjLkPi0=@vger.kernel.org X-Gm-Message-State: AOJu0YzdGX6TbzDxxvtHUnvA4Etsmw5ZIv02jclNc1FgP0bFc/2pzioi 13OJ4ldYlGv9EyyHuLOX8UrQjb1BXq2za3UTZkbgdhnTHRiktMYqi/nTR/FxqDcUuqQ= X-Gm-Gg: ATEYQzwoEdi2s0obrYuTFQpyP/4aduLoJMYcFTB3jH5gF/z9II4GEtz85vjNvTUs4dp NxV2bpPo7gyUoalRR6VHawGZUEkuDvLHFhqok9IP3pDOaRbbdQcZlLgsg7LhOKE0JXRCIAgd4SG NbdO7SegVl+PMaSHSHFSaPqvh+2DN48gsea1k2JQU0dMMJsi4jXW+n6Bv1rmjlnKQRvUOrwwDhN mj+kd2Xh7PTwowInZRDFjewrVLXwCuI/boK3w5+y5WA3s19e3V2DKKkuUELhpjFElr3Bct2MNIQ Mkg20KMSMNGPYg9j89ONOlQ2YiiVS4vNStDeLDOmRL2CjbhTdpOGeX5+BigZNWdPagGQRBnaXzY CN9bchAq5+7Q9c3FX2wA5CaMIMvfHUxyJv3y0B4H2HFqLaCHyDwE7M2XIl1OTPh6BhT+qJna13L ez3vbtsJuzqbAzB0H35FgwKXHajT4L X-Received: by 2002:a05:600c:8b44:b0:480:6852:8d94 with SMTP id 5b1f17b1804b1-483a95eabccmr307599365e9.27.1772090429880; Wed, 25 Feb 2026 23:20:29 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00d95sm37432448f8f.13.2026.02.25.23.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 23:20:29 -0800 (PST) Date: Thu, 26 Feb 2026 10:20:26 +0300 From: Dan Carpenter To: Keith Teeple Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, s9430399@naver.com, andriy.shevchenko@intel.com Subject: Re: [PATCH] staging: rtl8723bs: split chained assignment in xmit_linux.c Message-ID: References: <20260226001019.1100684-1-keithrteeple@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226001019.1100684-1-keithrteeple@gmail.com> On Wed, Feb 25, 2026 at 07:10:19PM -0500, Keith Teeple wrote: > @@ -15,9 +14,10 @@ uint rtw_remainder_len(struct pkt_file *pfile) > void _rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile) > { > pfile->pkt = pktptr; > - pfile->cur_addr = pfile->buf_start = pktptr->data; > - pfile->pkt_len = pfile->buf_len = pktptr->len; > - > + pfile->buf_start = pktptr->data; > + pfile->cur_addr = pfile->buf_start; Please don't do it like this. Do it like this: pfile->buf_start = pktptr->data; pfile->cur_addr = pktptr->data; Otherwise we have made the new version harder to read than the original code. regards, dan carpenter > + pfile->buf_len = pktptr->len; > + pfile->pkt_len = pfile->buf_len; > pfile->cur_buffer = pfile->buf_start; > } > > -- > 2.53.0 >