From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86AEE38A732 for ; Thu, 26 Feb 2026 05:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772084419; cv=none; b=djmkqT4FJyVU8lny+rl+KQh62rNF8uiLOHukAw3mI+GjfcyG16Ua0LhKdmzytLhzpam5aBkDMInUdU3JJNNQaZFo6yIjXJ+Or+dhWm7mkOmq1Asadyz0JujFK9ZWE3odFYZ5gFdyiEyZEb/ky71v+fDk7I9IsssD9hxkiM5QfGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772084419; c=relaxed/simple; bh=0e+CSqkJrh+3JxODLUgXItiizLAX8whwzjyyf34mztg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b4mGDfSkJUQZ+/VFsFMFQ9NiHkrRG2rSBfXrbR9G7fSMCzzORRCAJTGpUtBXW5jIm65TWlx7RPRvNuxQTvepizOfuzLW672uptD8bYC8eOl6Yjz7GESgeKydmZFx+7+2gIYgwb9eI0zJPRMyA8pQm7HJNI3q5qVN5fzq/8bjXBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MFymoI+W; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MFymoI+W" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c70bc5b4e86so184004a12.0 for ; Wed, 25 Feb 2026 21:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772084418; x=1772689218; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WdCopaZOQhauzeHIWCcMqPcRan0hj6MnkfirmBvy3bA=; b=MFymoI+W8U1O8eUxTemzsql0d6tBHevPI/SPXox/UgTe72/rH5Bqqi/OBhsKwZ87JK 4n1ykhrNBcO2WZe6pqW8lzIT/30rqgUpfX5+s+x+8BQJPUeSSMNgSEsJYcGX23CjPKeN olRxJDyOUAiR28CL5NRNc3H0FWGb3jMHzD/hy+2LWLEe6+r2MwFb698rOqs9m6esqjeO JFTJAA22iW3TxrbY84OJ4JeIN/9/nu/n4MkYxUWRBqRBMmC0cOSzzEI6YKyGjbKvtWUJ Jitp7vEhL5EB+8ogW5S1ADH0wIaGeKtDw9tO5sFKI/o0FjA57k0ME4m+mxw1V0fzQeTO s0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772084418; x=1772689218; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WdCopaZOQhauzeHIWCcMqPcRan0hj6MnkfirmBvy3bA=; b=oEtcl2CmUdLx3JO/DARnPeewgL8svY6DkzVZ69cKa4rhDOff8YxzBLS73ORnQANKRJ kg2VbUYjbVHhaFSHJcOOr0DoueIWIo1bWGYqMq1UgqIDfpt0qIFko5V84Ov/2ISQYmq4 8QhA5bzkv/vKxaIIWL9gJ6NbXOlJFmqjB2ZgM1z+ySf2mUIfNjqud/lVgl7LPpVCQtTI shzY9sDdimS8avtXlatnCORSjmfRfBVqFwRPZxvnecDRIIUkc1GcdSreXsGPutU4juXT VQFRQgImYv3UZRqpJXgeXzFJHcDvJ6s+8ez1KTmE1msYA41PwJ9uCpC6Kn+NqwIXxqLn Ip5Q== X-Forwarded-Encrypted: i=1; AJvYcCWCqb79hPwC18U7TjAUU6sLEtOMaOqND23/exUIlnHRi5sIHwemUI0i9x26ri/cxq2gBRR4HYIKzrX1mrw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf+fmcSfY+UkWvpwPEcBEbo0F589afaRgC7R2QYHL8bKw0x+Lu pCSz1qZYvp6xTzMFEvvPTYUaFo0c6/3OHRAEfkpcibkSIJKJrqzBeTFAB/LK+g== X-Gm-Gg: ATEYQzzVdGKNb3o4dgtE3J9P1W88OYL3RX5EVUMHk9wchGgn6rtduVTEPHjvQETRuUT udINgJv3JdF/Q9UBG+N6ChJm5e4GPb52RcLMpbpgyn98MTJ9deS41EJrIDUYQ6krFJq4aA5/Yea E2CjG+n0o3K+TYKgVY6Z89GMWDF/KrHqbpQRf6YRPqyieMi86jWmLtIVH5IMLunqeTdTI3lSWOz Aqx2cMZU8hFrjRCg/ZO9BMn0VSHjqVxh6PlGMQL4O3cHU6yLuhiPs7C91gpKnNBoU0XX3bgEptv GDgQ5ePLbLycfMVVQkO0hiR+qQwa3ruS7TbdjnXtNxvuvuVqmDX8igS1sb3gLEtgmdJ0n8yDkKc HjevpzPXj7OmZ42GvVxn5jpwj5H08eqqsoa3JLl037T0SJ1GoD9WvzH5fR74TKMl/AlWOHr/AIp Ymsg/MkpgYm8zu8g== X-Received: by 2002:a17:902:d549:b0:2a9:3396:738 with SMTP id d9443c01a7336-2ade9a55354mr27972395ad.44.1772084417854; Wed, 25 Feb 2026 21:40:17 -0800 (PST) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6f3436sm16994115ad.88.2026.02.25.21.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 21:40:17 -0800 (PST) Date: Thu, 26 Feb 2026 14:40:15 +0900 From: Hyunchul Lee To: Ethan Tidmore Cc: linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ntfs: Remove impossible condition Message-ID: References: <20260226040355.1974628-1-ethantidmore06@gmail.com> <20260226040355.1974628-3-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260226040355.1974628-3-ethantidmore06@gmail.com> On Wed, Feb 25, 2026 at 10:03:55PM -0600, Ethan Tidmore wrote: > The variable name_len is checked to see if it's larger than the macro > NTFS_MAX_NAME_LEN however this condition is impossible because name_len > is of type u8 and NTFS_MAX_NAME_LEN is hardcoded to be 255. > > Detected by Smatch: > fs/ntfs/namei.c:1175 __ntfs_link() warn: > impossible condition '(name_len > 255) => (0-255 > 255)' > > Signed-off-by: Ethan Tidmore Looks good to me. Thanks for the patch. Reviewed-by: Hyunchul Lee > --- > fs/ntfs/namei.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fs/ntfs/namei.c b/fs/ntfs/namei.c > index cecfaabfbfe7..2952b377dda2 100644 > --- a/fs/ntfs/namei.c > +++ b/fs/ntfs/namei.c > @@ -1172,10 +1172,7 @@ static int __ntfs_link(struct ntfs_inode *ni, struct ntfs_inode *dir_ni, > > /* Create FILE_NAME attribute. */ > fn_len = sizeof(struct file_name_attr) + name_len * sizeof(__le16); > - if (name_len > NTFS_MAX_NAME_LEN) { > - err = -EIO; > - goto err_out; > - } > + > fn = kzalloc(fn_len, GFP_NOFS); > if (!fn) { > err = -ENOMEM; > -- > 2.53.0 > -- Thanks, Hyunchul