From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A313332EBE for ; Thu, 19 Feb 2026 08:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771489129; cv=none; b=fObiwOp3EZVjuvpTiDpUTU0FVR9KMD3M2Rw+sJf3jlBjqWz4PFoNnonnqYpYhvK3NHLDriPPxlmQLTkygbAAJ13OBiR8K8yCm3HXbByq/yWseqpNwTADcC5yL4PLfStpsCwidEJhKkH/0tLfn2RHsNHVB/DK202GvP7Kr9HaFsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771489129; c=relaxed/simple; bh=25fFjG+D3oG6/FHvCcw1tDZoI+FYC8FVCy1xsCiumGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XIqmvXdlZG7BrzZwV6lCWMGgzGdUZHnu33dRpMF9AeIn71vhlSqxTMjhGDYQkB4730YtZeg/eOAy6hGjnnj+xKNVojXWTCqu/56k+EmmcYiQbg/caqK0ePnMIDEuZDHXLXXDBAUSzbXACIBvJtMlhlpUN/DRg2pwdLTL7hJYW+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JXH2dOvp; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JXH2dOvp" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4358fb60802so511691f8f.1 for ; Thu, 19 Feb 2026 00:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771489126; x=1772093926; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d07fJbkwY2gCz5xybwCJxh4H8QxouBn3MykfLYVImdo=; b=JXH2dOvpwdA34rHvdwTzAAJ/r9b3tt7c+q6s9rZJr0jiEjefxzL+pcVetdM7HN4ssJ lqruk1mEvOZ58HQ68Jjzqe2q8xRasS+44iPvZOAaDwQ7QR4/FYpAMtSKFXrJO0AGVlJe UULFR5VnqZLj9Lpiee0Yncx2cHIxIigAgViR1OGsUwQ6Zfg3vzoDgnU/H6Lv8dw3JqSP RJE6gBINsY7WrAvsV19QGnC/gl2nkmtUVfHHBoZnCrZjg4/EU6dhaWuZkvZWLWnfqjTr dDx9h5mpI58HVWUkTU4Yn6kXMbg5kvBCuQ9onWVa6CadiYtVETWf7mg51mobLoj1ecmo +GWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771489126; x=1772093926; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d07fJbkwY2gCz5xybwCJxh4H8QxouBn3MykfLYVImdo=; b=ikRaM8mTvWxGr1b3TUkKpL+hkQcAEp9uO6+pj7aBm0yscFxx+e2LxOsGyO0XmoFyFJ eIvA6lLr2YiNyo/hQwOACK42WFXHJmRY+7U7DqbxFMJRY87DxgtWFu+ZLJUKolJ26q29 yDnUoW9B5aMLRw7SXr7rACUsDr/4ZsaR7s+kJXohq6QvPGiXG6uLmBOY4SKZ3BTaUBet uQvc3HtrQFT7mJjxPlJjdmIDM9p2+NlxweNUEegbW4dIEz0XIz6HPHn3Q/B8958m4nq7 xXfs0BQdMbglS4eXve09N9l7LlJ2XE4tK2vmr/QnRp0eXwNrg+Hr/kNccXPoHa3tJbc6 +IHQ== X-Forwarded-Encrypted: i=1; AJvYcCWkBp6+gKNHbaMNOtV4z0nsUx50rI6oMq52JCEF2+wxixfCVkusO0o2yhMMBK2qQC+SSS0Lb/Bx0T3IitY=@vger.kernel.org X-Gm-Message-State: AOJu0YyQbbHBeLzOMXV5Dn+VL9h8BJ9dBqk3bKCJGJh/OcfuslC1o3mG F+Yk0b4iFSz4Omc1MUr7OC6P9nnkSQf/qf21D51tuPAvWDEC7Uk+5JJYwXDP1WXVw5k= X-Gm-Gg: AZuq6aJd+8mcqw8xVT6Fzsr21g7xpP1t6CFKJtVk3ovZqNoQh/w/9oah1O4GOIzDxma KU7RrA063fZa9dud3o0I1SMg84X0XNFz4EFScy3PCeArQnydsOtPF4uu8tBNyrZP/JGRSTccuyl 584fJV+iN78wGCrh7vCnVoZ+REdBYe4tLyY8caXapz0++9nLmY3BGNgeZ23+ZFsRvauQsX2fMxX i70wnwv+XQHP/Sv2Qt3LWGG0To5c8ZTbavPnP8O8GekQpHeRTVUxHDA30+uCW2TPB9yuCehBEih OMl0PbIFRg2oyUCWbDq/TD9o/KKTkmrhGR6YOImh6bvdMD2uojVGDhrokhNrZExuC2hDWP2mwmJ NF4mM8G3WJeFi+C74o540M3+PL15QhAbZot340KYstof7mcEiUuDah6ftVDTonIFjzVF6lIPrLx RTffp6+b43iHL5pxr8xMzqufZYvOX5 X-Received: by 2002:a5d:5f82:0:b0:436:36cb:70b7 with SMTP id ffacd0b85a97d-439626c745emr1549552f8f.7.1771489126216; Thu, 19 Feb 2026 00:18:46 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a74918sm47314947f8f.17.2026.02.19.00.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 00:18:45 -0800 (PST) Date: Thu, 19 Feb 2026 11:18:42 +0300 From: Dan Carpenter To: Artem Lytkin Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: most: dim2: fix error handling in fsl_mx6_enable Message-ID: References: <20260216201921.1788-1-iprintercanon@gmail.com> <20260216201921.1788-3-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260216201921.1788-3-iprintercanon@gmail.com> On Mon, Feb 16, 2026 at 08:19:21PM +0000, Artem Lytkin wrote: > Address several error handling issues in fsl_mx6_enable(): > > - Replace IS_ERR_OR_NULL() with IS_ERR() for devm_clk_get() return > value checks, since devm_clk_get() never returns NULL on error. > > - Replace hardcoded -EFAULT returns with dev_err_probe() which both > propagates the actual error code from devm_clk_get() and suppresses > log messages during probe deferral. > > - Remove an unnecessary string indirection in the clk_prepare_enable > error message. > Some of these are unrelated things. regards, dan carpenter