From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EA4532252D for ; Thu, 19 Feb 2026 10:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771495912; cv=none; b=iGRcrzHxnF+mRIvRjLCExOmnVTc6IQ3MQ/KxxVwUnDyXvVNszXpNlpyTxFQ2BWzB/hnExl8UGSW6URlDTuhwsQyiz651KHxU6BvSLkKweNHQ37sqAAFmFW8AH2W8C8tjsY4FK3TZ9Cwz7oVH7gIfNi4igmdG9SgplzmMbTW0J4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771495912; c=relaxed/simple; bh=4PP28JTi4vSYXKVlJie/fjCnni0V/SyFvW/cSYUEEak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UwwbMW1v754OYPC6UNvzHdZMIfDEUF/2QJtmT0S2V4Sz9qQhAHR43Mrpj9IUfGKgecPoB71dTGgErUFl8c7ic2UzCK0LIJI7NM+HDeyMN/8kzGmf115hY74uYvxDk4ZFYd2G/Y7nbp3H2NPgKOqKVhQxE5xy+re435yb/QJHElU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BrpJnF36; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BrpJnF36" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6581234d208so1229928a12.3 for ; Thu, 19 Feb 2026 02:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771495909; x=1772100709; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nCgIobwzKfkS2/wNucv6X5nIS/1dp0j/HP/5gpbPJ9Y=; b=BrpJnF36RLWRy4E6VE2MbNv8FWdOqbmZ/toRwy6h17UZuQuhW+wUs3oCivOU/GrE/w MQpFSIf6ZHN8amBF6IxHKokUW7Y9Je823UhVy+6IF37mFbRKI0zBp7/hje3h5OZZPi+s pO8z04mrQ+afkNk4N8C/SDqVUOzYSORPbWAUeZv8rYza0t3WUoa5ugkudPjWHmOoR6Ce wWNUg8TTxkOYsGMmFo3bn2cq8IW5RFMuCdbMf5pl+wLcaWrDmwMZnDz/HkWjWFvJZJD1 qKoeRp7GnN3dRtWekdTpZ0iLGBDXqe/bCNCLqhKEQkreWuyo4fxJRnqURX6WriSiH3fT 8+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771495909; x=1772100709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nCgIobwzKfkS2/wNucv6X5nIS/1dp0j/HP/5gpbPJ9Y=; b=UBxPggwlutwbc2zQEDiAGVNa/uxi6/kIYZ6eE3+IFO+BqXaKtgEoZRYLrz4TINF1G1 akckfeTZirpIw1fOLpIfTJkPEkQBeVuY1i+fHaqMsQ0SZoHUxIvR8cc4qPTedjOx1J/I gn+3zqbvlnb3nnfV5Q3zI4pDU24Wxi9wjOCTTsg3Crf5VPdURUzopxdoBZGHjZgi4Upc Gd/f6USfsrbUnmS6ol5Px0eEqqTFHjkmOnB2eFwdyFXqEPIEDutHUIxyXfGnFnIwQQVM sMrKh/bdk195gR7E7KqbUIL4I995ZlsRg3R6EEm5zR4YcHdd3QJg9U9qfrhz6iWvoULF 2q5A== X-Forwarded-Encrypted: i=1; AJvYcCWfX+XjfCVKOV3NQiz+AFIJZtticCyKQA7KZEz/k9vYFuRZ4oe5fH1VlTwhOlXeCvNmxlWVUF4bhAIISdI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk35unn1GUJWwPCxCaB6mUb3dZwK63ZaTXD0i3abRfPnI1sA9I 2c9A0+nZxzlReOkdB/cufXGQDFRYsownsVddBRY5pdb8tADSbbYhnuZ6 X-Gm-Gg: AZuq6aK86a9RcwAshpiqpY+guoVZhYBLtEqtyS0+noKqoOC9UcgZ1/Uz/DE1bH8I6HM 8sYSL8YAEQxo+pZ+gNN1o++260C0aAKNF6km4aJX20+aSJGKJQNLnoQ48/RAMZQu00nVgD8Vq0h HyrBPkguc6WHQzQkGQCWmEf0cHzrIzFzR3tFX8rpzBXaR+kN0HZFly0w/qUo8DBEVBBrmczYqHT OWd39fKAS6My32OubNs0+0QG8Uh2XfEBY5hm27T5xZLcjcJwqiyde9sYOC1C1o5sGvRbDsg/NkN XdVmxotcX5sgTE/6VrqI412KN0aVJntAauBEcGzcgyVjb1PE2EcWO5MGe1v9ZgXc239JW3R3j8g bvvDrxS7r4phXYH09yhytYkkvPHgYMveKPLxRuIPynhMy0O9Wd/vwSNCRzqBpf9SyJzo8YatNws wSSyVFZRHXhCV3BA== X-Received: by 2002:a05:6402:1470:b0:65c:63f0:a92 with SMTP id 4fb4d7f45d1cf-65c63f00e8bmr4409640a12.23.1771495909325; Thu, 19 Feb 2026 02:11:49 -0800 (PST) Received: from jekhomev ([46.251.53.180]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65bad19bed1sm3736600a12.7.2026.02.19.02.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 02:11:48 -0800 (PST) Date: Thu, 19 Feb 2026 12:11:47 +0200 From: Yauhen Kharuzhy To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH v2 4/5] input: drv260x: Fix unbalanced regulator_disable() call Message-ID: References: <20260215141435.727872-1-jekhor@gmail.com> <20260215141435.727872-5-jekhor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 18, 2026 at 06:43:30PM -0800, Dmitry Torokhov wrote: > Hi Yauhen, > > On Sun, Feb 15, 2026 at 04:14:34PM +0200, Yauhen Kharuzhy wrote: > > +static void drv260x_remove(struct i2c_client *client) > > +{ > > + struct drv260x_data *haptics = i2c_get_clientdata(client); > > + > > + regulator_disable(haptics->regulator); > > } > > This will result in power being shut off the first thing during > unbinding, which is too early. > > I switched this to devm_add_action_or_reset() and applied. Do you mean that, in this case, regulator_disable() may be called before any devm_* registered actions? Good point, thanks. -- Yauhen Kharuzhy