From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E4D51ADFE4 for ; Thu, 19 Feb 2026 12:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771504740; cv=none; b=Zh2/vIDPb3lg/b4YNA7YM0+LV3fCjr7koZtMaqcaNX/TGxxUqypTL/s4dY0GovZNfbKJ2I3wuJAJzrFBQyM4LIOhTSp+opJhn9ajRNNwtzUkwsQRBM85WZ6pJnJks303848wx0pFjCcEKTp9upN7qj9LC4jHnvEzJSnj4qTgMyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771504740; c=relaxed/simple; bh=zaEyoKufr8kJjMPlauNC6hFcaNXmh0VL7nMLWJY7Dms=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=il7hePE+AzLp53fFiaxxsKzAgsQzT3VOuLpHhWA+2unOePy8wHngRIYceQrVwmQoTypw8/YMqRjsb/UbHpDwBR6oPernqNwsHPHGRECozDCjo/M97f9FcAMvLiX9tjX3KiD8FWF066Wmxjt7yKCSn7sJjNUNsqwQG5DGGqRpFU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OIZSOYoD; arc=none smtp.client-ip=209.85.221.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OIZSOYoD" Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-56641200d6eso1098465e0c.0 for ; Thu, 19 Feb 2026 04:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771504738; x=1772109538; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b/Yeq/h1sK2QWMwvAHMWW/0uWsIY9PKo2xaxo2nKMJU=; b=OIZSOYoDia7EmFVoG/umYjRoJBDojJiGAhfJ2qIV0YfcFtDj2LOzj7355Y9RyCy06+ 6R1e0lQpXVUktj6MSO0XosuRbH3vD6/ymlv5R2erRNRish3i8SUtPYfB0GQgHR10t71T ctai1O588nyTR+igdUDogAr1KWcBG8UQqhZbwT4HrumZjPnoW66YYEWpSKujmFGsNNwx h+a44NyBcqdFQUgl71rMn5ZPylsTHkoxAkpKOSDzDYmuEnvkHIhwtRjdho3dpjG1s7O3 ADspgEDvZDyT0Lq4A3QGMjfeCaxTtyZuwcf8RBqipgZjIm+0dZP70Stx9q1aHD+us2XI +W4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771504738; x=1772109538; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b/Yeq/h1sK2QWMwvAHMWW/0uWsIY9PKo2xaxo2nKMJU=; b=skuMkZ5mqsrfQJ3Oe6NF2w5YYrgvnHj+xqOsEvhXE4gxmfiN7wCNSnPLvy2z85zyGD nht9PErHy5kT9OFURl1VGTEuqbPCDw6NjVBc8dmVi6tqrBh5sn6DS9jX4Q0clKUYhD4Y A4dEy1Qd28yZbaVIXz0Uxgexv26K5jFYK6ZtnJ2zc1ENB8HpxRibm+CJBrQ9hFuh8yvY bPmQVQ2CNbsMhXJiMSBToWrQEEonV97XJFoDWeJgWsKf3ik2mlmA8w75uEpClw4x2yIS f86vs8HwOAnhqrmUEZzc3ALtm4ETXdgLYapK0SHGazfmATUfX7VZRQnNMdLJOScJznDe DXuA== X-Forwarded-Encrypted: i=1; AJvYcCW2+Dsa6McPKX9dAxXaWfzHM+LP7H1nhqWYXiUkpDx3FkU8aaO/dSylP398lYLcr7LrX9G3CujNk255rJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YySx5tgwnDGnUYa9M0UiaKDluXpCggxdxTXLoz0fcGS9s9YkPGz k5nGcjNebBn46eLWXgLudZnzr1iKK5/2RKtD9k+ps4ail/XvU+clEjez X-Gm-Gg: AZuq6aJxp2vT/p1vLxTSreimQY9yBwEp5f8qEUDNNFFoDB8SuBxQ+eMzRE6E3gEXfvi 2A0E2y9fAzzGpne1S/4KeNx0Lj2lf0YO9fJpR2PhJpi3YV7N5OIaEB2+uk3Obz3CiIKAj4JSL49 pNuF7QZPi4f1tpPdQc5u5wLMMGKkzUxZ4fxEpW28HMvELI4emZRD6K8msqgPvd6oZMcxPM/Zy/M sXhKqfj2/frFBE0/SEZQ8qOE5l//stMcabgq1cTasCnrVWjUww9DezYLxXAI9PMNcgNmz06Ljb2 Vso8EqVInez8PNLPicoYqvBhvjlYE3MpAPUSW5kolRIZOV82FDBuq4IeEznUDibCzd8yW4a3CBT nBYJO9PIVA4lkZsw7Trgnu4U8Vn/sxxKnDZRSeDDAkMysAfl1wIWAyuR0p7FG1ZRUc0OkPH52rT 3uf60RpdoGQsKjENBPl8y0wVDBbtMqq08= X-Received: by 2002:a05:6122:3214:b0:566:271c:b48d with SMTP id 71dfb90a1353d-56889d4a600mr7345546e0c.18.1771504737800; Thu, 19 Feb 2026 04:38:57 -0800 (PST) Received: from localhost ([2804:30c:942:5700:6773:2626:ab8c:582e]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5674bfe5ec0sm13742463e0c.5.2026.02.19.04.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 04:38:56 -0800 (PST) Date: Thu, 19 Feb 2026 09:39:27 -0300 From: Marcelo Schmitt To: Andy Shevchenko Cc: Marcelo Schmitt , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jic23@kernel.org, michael.hennerich@analog.com, nuno.sa@analog.com, eblanc@baylibre.com, dlechner@baylibre.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net Subject: Re: [PATCH v9 7/8] iio: adc: ad4030: Add support for ADAQ4216 and ADAQ4224 Message-ID: References: <39ebbb49619d5d588efe590560046d747dd46ad5.1771253601.git.marcelo.schmitt@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Andy, On 02/17, Andy Shevchenko wrote: > On Mon, Feb 16, 2026 at 12:01:12PM -0300, Marcelo Schmitt wrote: > > ADAQ4216 and ADAQ4224 are similar to AD4030, but feature a PGA circuitry > > that scales the analog input signal prior to it reaching the ADC. The PGA > > is controlled through a pair of pins (A0 and A1) whose state define the > > gain that is applied to the input signal. > > > > Add support for ADAQ4216 and ADAQ4224. Provide a list of PGA options > > through the IIO device channel scale available interface and enable control > > of the PGA through the channel scale interface. > ... > > +static int ad4030_setup_pga(struct device *dev, struct iio_dev *indio_dev, > > + struct ad4030_state *st) > > +{ > > + unsigned int i; > > + int pga_gain_dB; > > + int ret; > > + > > + ret = device_property_read_u32(dev, "adi,pga-gain-db", &pga_gain_dB); > > + if (ret == -EINVAL) { > > Actually instead of custom error hunting, this should be rather Sorry, I messed up when preparing the patches. "adi,pga-gain-db" is not going to be a dt property and this should have been just the 'GPIOs for PGA control' below. Anyway, thanks for reviewing this. I'll hopefully recall this error handling pattern in future contributions. The other suggestions look good but I'll wait a bit more before sending v10. > > if (device_property_present(dev, "adi,pga-gain-db")) { > ret = device_property_read_u32(dev, "adi,pga-gain-db", &pga_gain_dB); > if (ret) > return dev_err_probe(dev, ret, "Failed to get PGA value.\n"); > } else { > > > + /* Setup GPIOs for PGA control */ > > + st->pga_gpios = devm_gpiod_get_array(dev, "pga", GPIOD_OUT_LOW); > > + if (IS_ERR(st->pga_gpios)) > > + return dev_err_probe(dev, PTR_ERR(st->pga_gpios), > > + "Failed to get PGA gpios.\n"); > > + > > + if (st->pga_gpios->ndescs != ADAQ4616_PGA_PINS) > > + return dev_err_probe(dev, -EINVAL, > > + "Expected 2 GPIOs for PGA control.\n"); > > + > > + st->scale_avail_size = ARRAY_SIZE(adaq4216_hw_gains_db); > > + st->pga_index = 0; > > + return 0; > > > + } else if (ret) { > > + return dev_err_probe(dev, ret, "Failed to get PGA value.\n"); > > + } > ... > -- > With Best Regards, > Andy Shevchenko > Thanks, Marcelo