From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF42C340275 for ; Thu, 19 Feb 2026 14:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771511522; cv=none; b=PU+ApQoldKAnHgZJj8FVny8SMb4GrVbeyR6a0VorlLhRVnrgh52J5TK5XTlCj2N/9xj5VC2N3PMvkRX3fUoj7ViabJdWQ8I7Qll2UFpcX+XSVkuNJflwleYnuogrItxzGFTHkRaxdrww+thkjOmohlCWZJlX8hoy5ISdqo7sPeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771511522; c=relaxed/simple; bh=0SLhbTg1yYmb9zAVPKw8xoKnLQ9qB2Jhy86nwGzc9Mg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AX1dhQF/r2gKS6yqqKQzNFeOkaf38/24xT2kbloGpi6oCvYMalH0GxXNAZ+gEFvdaEnLaAshNGasPi3v0/sTaF9QlUGRKsOz+TW2zdI1AjBPx5GCmhjmw3QorAy0ad/YllQ14NorRQX6yOnOS+rAu71Zr56CAXC3QYAIHMKbPso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GkBuSdWu; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GkBuSdWu" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-48329eb96a7so6173585e9.3 for ; Thu, 19 Feb 2026 06:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771511520; x=1772116320; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=i+qKFoabRqEgBnmXyIvDdSokcUG88HYAtO4ot0il4iw=; b=GkBuSdWufwWvAqxf08SLIykdd9QFfydizMIrJQnhpcUuSHa7G5ye7d3xkVYspazs9/ JXqIcf6lrvfdcqSauPCc+oo/wxlYXWwuUAdo4DYP7H3Ofg4+GAVGvp2lEc0vvD8OmVhG TeSqsWXZwEkhlX1lrh7QcKN169Z6XPSQvzNeiQAJtYSbMZgUjV24M/fIT72z+gtaD5EV nul4PfF4/cLnYwLXwwQjjdElciSNvPZlOwI1pM7J5up97nBij/Op03ETvvT1Z+qFAAde U3PySzNcUlWqpgKju6F79YDIp/zYj757UmAtal/gu0nW7swqjWN6t05Wk6zBgSRWUjDn A1Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771511520; x=1772116320; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i+qKFoabRqEgBnmXyIvDdSokcUG88HYAtO4ot0il4iw=; b=ob0Z18gFmi3xdMQbMO13iq8QQVXoH/nOJkLcihYrOKdo49i7p7Lw22Qh7O+ShsumBS woVWJOmHwZaBE7nrUOBvCkqREiVGthuwUspWnOY2K3UnQalthnuGNvlzjraUScSI8Xoo MisDonObp9LLRvjyWnX4/3XHPg0lpzl+3hU7sWF4gArILs9QDXVlLoKbVFo6rLYtSWQ1 i9mPCd0XyjdZ/+SMi9cLdKHMd8jo6BAbJnaRj2wheZlZjHNMB8HSUal3zCbPQxqEzY39 aF/3B8yScb1SJs4F/SkWbrfAXdztUE4Kc7YqDsrqwNmN9D5c7vlOWoA3EcvpM2BriWrg j3kg== X-Forwarded-Encrypted: i=1; AJvYcCUXoL7TyKJLIvEuN0HFNRJsixmpNND22zz4D8BHZlzAiJ0M3OOCGrlxjunbuo1IGWZb6NuP5QXy66bZ7TA=@vger.kernel.org X-Gm-Message-State: AOJu0YyjDtUntBRbuC90JU1txaGcG8h3zYiUxEIlsglQy9Ln/i+es1oY b7T1P4ElLM+y7rSN9rHy23N3BUyR1zhUhYCL/QSqDpMEZWzihtszH9e155x8tJX6vcE= X-Gm-Gg: AZuq6aIkewooZJl9APvxuHniWE4/1vMuX5KRcaPJ3uJMwPCKi9iyfX+8snj6L0bxciP w3oaqz2PJ5TJ4Tsw+/3RSoG0LDgZZ+7pEURbLDkYG5+5ILC/6y1DeiHNLz79mR53tz0AtLJxm7I F2SVSiwMZiQzFGhhmB7aLMCq84Me48tvtyqxsd1i0Ovqok7A/KimAD6ellZbnLZmQveXfPgqmQp 0Pbs7NN1nUFbf4HKI7/OPqpIqKlkMret27SfLG4Z3ToUP4k8O1sGqiF5EWULAp4f5YE0WkcYkAE OK6GUqqSt+upSwEtwNuYLjaJE35trvRnzvocqePujlK/h09SRxY9bs+MKCsG0kEbNRxiR+kschL VaaCNN8bxUNoiJT3YWf+7le9xim3D6qxhA8WVwDelRL8zEn0wZQ5HaIoPMkrhbTcXTXGP8ymDHF R5n7CPtgwEnKaSN5darCJHdUGdUR6H X-Received: by 2002:a05:600c:a51:b0:480:1e40:3d2 with SMTP id 5b1f17b1804b1-4839e6682a2mr41932915e9.29.1771511519890; Thu, 19 Feb 2026 06:31:59 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a5b2d1sm52919229f8f.4.2026.02.19.06.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 06:31:59 -0800 (PST) Date: Thu, 19 Feb 2026 17:31:56 +0300 From: Dan Carpenter To: =?utf-8?Q?Bart=C5=82omiej?= Konecki Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: document codec mutex usage Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 19, 2026 at 02:28:19PM +0100, Bartłomiej Konecki wrote: > Add comments describing lock and register_mutex > in struct gbaudio_codec_info. > The lock protects the codec runtime state and module/DAI lists, while > register_mutex protects hardware registers. > Improve readability and clarify locking semantics. > > Signed-off-by: Bartłomiej Konecki > --- > drivers/staging/greybus/audio_codec.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h > index f3f7a7ec6be4..90dd3426d4a4 100644 > --- a/drivers/staging/greybus/audio_codec.h > +++ b/drivers/staging/greybus/audio_codec.h > @@ -70,8 +70,9 @@ struct gbaudio_codec_info { > struct list_head module_list; > /* to maintain runtime stream params for each DAI */ > struct list_head dai_list; > - struct mutex lock; > + struct mutex lock; /* protects codec state and module/DAI lists */ > struct mutex register_mutex; > + /* serializes access to codec hardware registers*/ No, it doesn't. regards, dan carpenter